Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <007934281451e843a0428dc1e674f9dae149b75b.camel@linux.ibm.com>
Subject: Re: [PATCH v2 02/11] asm-generic/pgtable: Adds dummy functions to
 monitor lockless pgtable walks
From:   Leonardo Bras <leonardo@linux.ibm.com>
To:     John Hubbard <jhubbard@nvidia.com>, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org
Cc:     Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Arnd Bergmann <arnd@arndb.de>,
        "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
        Christophe Leroy <christophe.leroy@c-s.fr>,
        Andrew Morton <akpm@linux-foundation.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Nicholas Piggin <npiggin@gmail.com>,
        Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Richard Fontana <rfontana@redhat.com>,
        Ganesh Goudar <ganeshgr@linux.ibm.com>,
        Allison Randal <allison@lohutok.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mike Rapoport <rppt@linux.ibm.com>,
        YueHaibing <yuehaibing@huawei.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Keith Busch <keith.busch@intel.com>,
        Linux-MM <linux-mm@kvack.org>
Date:   Mon, 23 Sep 2019 17:48:24 -0300
In-Reply-To: <cb7d4196-c646-82c7-d61f-b28ee9ab47b9@nvidia.com>
References: <20190920195047.7703-1-leonardo@linux.ibm.com>
         <20190920195047.7703-3-leonardo@linux.ibm.com>
         <cb7d4196-c646-82c7-d61f-b28ee9ab47b9@nvidia.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-gscBM7V3X0iJvvOlmKSv"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-gscBM7V3X0iJvvOlmKSv
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks for the feedback,

On Mon, 2019-09-23 at 13:39 -0700, John Hubbard wrote:
> Please remember to include linux-mm if there is a v2.

Sure, I will include on v3.

> Nit: seems like it would be nicer to just put it all in one place, and us=
e
> positive logic, and also I think people normally don't compress the empty
> functions quite that much. So like this:

I did this by following the default on the rest of this file.
As you can see, all other features use the standard of=20
#ifndef SOMETHING
dummy/generic functions
#endif

Declaring the functions become responsibility of the arch.

> #ifdef __HAVE_ARCH_LOCKLESS_PGTBL_WALK_COUNTER
> void start_lockless_pgtbl_walk(struct mm_struct *mm);=20
> void end_lockless_pgtbl_walk(struct mm_struct *mm);=20
> int running_lockless_pgtbl_walk(struct mm_struct *mm);=20
>=20
> #else
> static inline void start_lockless_pgtbl_walk(struct mm_struct *mm)
> {
> }
> static inline void end_lockless_pgtbl_walk(struct mm_struct *mm)
> {
> }
> static inline int running_lockless_pgtbl_walk(struct mm_struct *mm)
> {
>         return 0;
> }
> #endif
>=20
> thanks,

--=-gscBM7V3X0iJvvOlmKSv
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEMdeUgIzgjf6YmUyOlQYWtz9SttQFAl2JL5gACgkQlQYWtz9S
ttQ/dxAAmqh1JwzGgrYEa6AI0XaKTKXfH+bFIB1fqsi0Gli4dmGUVNOz/qhFJa4d
HVBKm2Xq2FoNnqNfrihl527mry0pJnpUZTJLHiga3Pu9c6oY8bdSAeqfTh4xR74S
FIP+zgEvZBk6IKZaNit1tlHCkD1dRaPLcCaYUBmSVf0nsya+5zE3hkCgHU0vcsRc
ttmSNmOtglF+Y5zrOhBDrXcHUkHR5242AraOWaqAEh++ijgu4zMP3gsUitjtPPOF
4ZDNSg9/98JUZWd15+29J1f6Zknn8XhCQpiKCzAZQecNZ3xkWiWf0Mtgl7XDKZn6
bHOKBEyKXXLcgwlljlhW5QBHmmwGwPYhOuUhl49eM00jIebyU9JZFjyFR7907dGT
eziIXPFrQDndRxZNbpjTKH9bO7+MUj3X7fdL4RqPM3dJghMGD3SsfQpHVydMCod6
VHNxF3x/uHuqY0lH7zJt98v+qk5TycFFARZGOO0IZ5OCsqNzKxkPqCyVZlK1PiIY
vs0FExh8GZbJ2g2rX0QZqKY4OcgNxKpKRlpAhIHGIV1GQchV8PHcj1icghNzXzX9
7bNyoczCO5atCCJDlrGaNLVE22+LKCciaDKFAN8noZFzhMGGWzGhrfQ/mSbOvAxt
3IuAflLfYMrYZRlyu+Zx8YVXlG6nqzyJpIK2rlTQ/YR2IR19bno=
=ZXCk
-----END PGP SIGNATURE-----

--=-gscBM7V3X0iJvvOlmKSv--