Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1698049ybn; Thu, 26 Sep 2019 00:23:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqxPEfO0JoamOVKA4HKdGEdLqDVAJ06mFmNSIeSsxZSIBH5fKfdTDbxCk0YUGIK8BINV6VHN X-Received: by 2002:a17:906:d185:: with SMTP id c5mr1805175ejz.139.1569482620773; Thu, 26 Sep 2019 00:23:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569482620; cv=none; d=google.com; s=arc-20160816; b=WIzJDzjmNv7ZVmye9mzN0EupxbuRm3NVoRvoeK5Fh/9PEFJqVHlRIZ/RJ78xv+Hrvt sZyp4vfDdjCiHWOKYIjh0CDyDjxdNhvW2osiynZoWrkxBA+pHcdcjTEhBhQqKIVIdbPr fmwkXWSz1wAFzkE8buxU9kUdPrlaPTDbkqELaIR8lSMYcOhfA7xBaGoCpDBj82+7KPul awh+8ttQ84pVZ9ZA9CKSvLn7C3ZNESfg+v7B6KL61YsBlPES3i7N8mXORVsKptlKtWAZ c3qjejxopWo2UY+VtqS04Vmo+HFN8M1OiLQRP8Dwf9eixdDr2e5hNMguddKI19YBoZ4p Y2Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=o+akF7DOMY9SBVYbLbU9Zgr2//80q05MCuvDfuMDj5c=; b=J9jM3pv2UNNcke1I08s7BuNANraXg+pMfFZaMK0D+iEZwtdE6Kjw2ZSian2CBXdUY0 uTuJhOou3YmYcx8Y8OE9ZwvcSRBS9nDVSIoaWlC+GaA356Gy0JdLrV5oXT0ssVAmxnV+ 7tmCXNV+dg3bVdj2Er491F5GX2BUOLxSnwPxNTmE1xfdPKIplpU/0xDocwJjpYkKJtKU /PNqNSuVWNDmPbSMcH65UcvNITSQXZQaeVpK3zOCkyteJ5zlw7buN6VFyUkMIv8CpJIr tbfaqyg4X1xhZXjHPNsRE9cOrLFoDavmjM1RsIsHw48sPRDgyOsKQDkjtsXrfPK47Ixb cJ+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p10si540261ejz.391.2019.09.26.00.23.17; Thu, 26 Sep 2019 00:23:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408605AbfIXC3k (ORCPT + 99 others); Mon, 23 Sep 2019 22:29:40 -0400 Received: from inva020.nxp.com ([92.121.34.13]:38828 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406127AbfIXC3i (ORCPT ); Mon, 23 Sep 2019 22:29:38 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 2EADC1A0A01; Tue, 24 Sep 2019 04:29:36 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 6B1521A09F9; Tue, 24 Sep 2019 04:29:28 +0200 (CEST) Received: from titan.ap.freescale.net (TITAN.ap.freescale.net [10.192.208.233]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 9D3964030F; Tue, 24 Sep 2019 10:29:17 +0800 (SGT) From: Xiaowei Bao To: robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, leoyang.li@nxp.com, kishon@ti.com, lorenzo.pieralisi@arm.com, minghuan.Lian@nxp.com, mingkai.hu@nxp.com, roy.zang@nxp.com, jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, andrew.murray@arm.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: Xiaowei Bao Subject: [PATCH v4 03/11] PCI: designware-ep: Move the function of getting MSI capability forward Date: Tue, 24 Sep 2019 10:18:41 +0800 Message-Id: <20190924021849.3185-4-xiaowei.bao@nxp.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20190924021849.3185-1-xiaowei.bao@nxp.com> References: <20190924021849.3185-1-xiaowei.bao@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move the function of getting MSI capability to the front of init function, because the init function of the EP platform driver will use the return value by the function of getting MSI capability. Signed-off-by: Xiaowei Bao Reviewed-by: Andrew Murray --- v2: - No change. v3: - No change. v4: - No change. drivers/pci/controller/dwc/pcie-designware-ep.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c index 55b23ce..c3bc7bd 100644 --- a/drivers/pci/controller/dwc/pcie-designware-ep.c +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c @@ -624,6 +624,10 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) if (ret < 0) epc->max_functions = 1; + ep->msi_cap = dw_pcie_find_capability(pci, PCI_CAP_ID_MSI); + + ep->msix_cap = dw_pcie_find_capability(pci, PCI_CAP_ID_MSIX); + if (ep->ops->ep_init) ep->ops->ep_init(ep); @@ -640,9 +644,6 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) dev_err(dev, "Failed to reserve memory for MSI/MSI-X\n"); return -ENOMEM; } - ep->msi_cap = dw_pcie_find_capability(pci, PCI_CAP_ID_MSI); - - ep->msix_cap = dw_pcie_find_capability(pci, PCI_CAP_ID_MSIX); offset = dw_pcie_ep_find_ext_capability(pci, PCI_EXT_CAP_ID_REBAR); if (offset) { -- 2.9.5