Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ran Wang <ran.wang_1@nxp.com>
To:     Alan Stern <stern@rowland.harvard.edu>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Mathias Payer <mathias.payer@nebelwelt.net>,
        Dennis Wassenberg <dennis.wassenberg@secunet.com>,
        "open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: hub add filter for device with specific VID&PID
Thread-Topic: [PATCH] usb: hub add filter for device with specific VID&PID
Thread-Index: AQHVcfycJPrHn/IcK0qf/xic1GWPZ6c5W4SAgADPjkA=
Date:   Tue, 24 Sep 2019 03:32:37 +0000
Message-ID: <DB8PR04MB6826516958DA6083192250CFF1840@DB8PR04MB6826.eurprd04.prod.outlook.com>
References: <20190923105102.37413-1-ran.wang_1@nxp.com>
 <Pine.LNX.4.44L0.1909231059260.24712-100000@netrider.rowland.org>
In-Reply-To: <Pine.LNX.4.44L0.1909231059260.24712-100000@netrider.rowland.org>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e3b1e3a7-c3cc-429b-9239-08d7409fd8cf
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2019 03:32:37.6623
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2D5CbC74VG5nmaNiaVGlu60scwG17T9vxwjIcQ3lTyCZ4BzlFZSueiLET5A3fy+GumsLHOuyajpr6Ka1uTNguw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5897
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Alan,

On Monday, September 23, 2019 23:01, Alan Stern wrote:
>=20
> On Mon, 23 Sep 2019, Ran Wang wrote:
>=20
> > USB 2.0 Embedded Host PET Automated Test (CH6) 6.7.23 A-UUT
> > "Unsupported Device" Message require to stop enumerating device with
> > VID=3D0x1a0a PID=3D0x0201 and pop message to declare this device is not
> supported.
> >
> > Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> > ---
> >  drivers/usb/core/hub.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index
> > bbcfa63..3cda0da 100644
> > --- a/drivers/usb/core/hub.c
> > +++ b/drivers/usb/core/hub.c
> > @@ -4982,6 +4982,18 @@ static void hub_port_connect(struct usb_hub *hub=
,
> int port1, u16 portstatus,
> >  		if (status < 0)
> >  			goto loop;
> >
> > +		 /* USB 2.0 Embedded Host PET Automated Test (CH6)
> > +		 * 6.7.23 A-UUT "Unsupported Device" Message
> > +		 * require to filter out below device when enumeration
> > +		 */
> > +		if ((udev->descriptor.idVendor =3D=3D 0x1a0a)
> > +		 && (udev->descriptor.idProduct =3D=3D 0x0201)) {
> > +			dev_err(&udev->dev, "This device is not supported:
> idVendor=3D0x%x idProduct=3D0x%x\n",
> > +				udev->descriptor.idVendor,
> > +				udev->descriptor.idProduct);
>=20
> There's no need to write out the Vendor and Product IDs.  They already ap=
pear
> in the "New device" message.

OK

> > +			goto done;
> > +		}
> > +
> >  		if (udev->quirks & USB_QUIRK_DELAY_INIT)
> >  			msleep(2000);
>=20
> Shouldn't this be implemented as a device quirk?

Yes, I was also looking for the way in quirk but not quite sure currently.
So we can stop initializing a device (with specific VID&PID) in quirk, righ=
t?

Actually in drivers/usb/core/hub.c function usb_enumerate_device(), it will
call is_targeted(udev) which has below implementation:

54         /* OTG PET device is always targeted (see OTG 2.0 ECN 6.4.2) */ =
        =20
55         if ((le16_to_cpu(dev->descriptor.idVendor) =3D=3D 0x1a0a &&     =
             =20
56              le16_to_cpu(dev->descriptor.idProduct) =3D=3D 0x0200))     =
            =20
57                 return 1;   =20

The ID is very close to what I need to response. So, do I need to add code =
here?

Thanks.
Ran