Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
From:   "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>
To:     Liviu Dudau <Liviu.Dudau@arm.com>,
        "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>,
        "maarten.lankhorst@linux.intel.com" 
        <maarten.lankhorst@linux.intel.com>,
        "seanpaul@chromium.org" <seanpaul@chromium.org>,
        "airlied@linux.ie" <airlied@linux.ie>,
        Brian Starkey <Brian.Starkey@arm.com>,
        Mihail Atanassov <Mihail.Atanassov@arm.com>
CC:     "Julien Yin (Arm Technology China)" <Julien.Yin@arm.com>,
        "Jonathan Chai (Arm Technology China)" <Jonathan.Chai@arm.com>,
        Ayan Halder <Ayan.Halder@arm.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        nd <nd@arm.com>
Subject: [PATCH v2 2/2] drm/komeda: Adds layer horizontal input size
 limitation check for D71
Thread-Topic: [PATCH v2 2/2] drm/komeda: Adds layer horizontal input size
 limitation check for D71
Thread-Index: AQHVcqlbZ+q1ta0ytEW/DVb0H7fVog==
Date:   Tue, 24 Sep 2019 07:26:18 +0000
Message-ID: <20190924072552.32446-3-lowry.li@arm.com>
References: <20190924072552.32446-1-lowry.li@arm.com>
In-Reply-To: <20190924072552.32446-1-lowry.li@arm.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=Lowry.Li@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: git-send-email 2.17.1
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 7d6458bc-cc38-485b-a7c1-08d740c08477
X-MS-Office365-Filtering-HT: Tenant
X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR08MB3199;
X-MS-TrafficTypeDiagnostic: VI1PR08MB3199:|VI1PR08MB3199:|AM0PR08MB5121:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <AM0PR08MB5121562EF9CE187D18958DD09F840@AM0PR08MB5121.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:4941;OLM:4941;
x-forefront-prvs: 0170DAF08C
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(376002)(366004)(346002)(39860400002)(136003)(396003)(199004)(189003)(6116002)(71200400001)(50226002)(6512007)(3846002)(6506007)(4326008)(66476007)(476003)(14454004)(66946007)(386003)(52116002)(66556008)(486006)(2616005)(6636002)(6436002)(14444005)(36756003)(2501003)(99286004)(110136005)(64756008)(2906002)(446003)(256004)(66066001)(54906003)(71190400001)(76176011)(81156014)(6486002)(8676002)(478600001)(55236004)(66446008)(5660300002)(81166006)(102836004)(11346002)(86362001)(2201001)(1076003)(8936002)(26005)(186003)(7736002)(316002)(305945005)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR08MB3199;H:VI1PR08MB5488.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Message-Info-Original: e387BRipFUQslMY7fImmJpYXFX30B+6G6iRyQFJ4KVcj6HRUnt3YHEfFnqRQwnwwCAeCx7pQYfAtsGTsfP7fJWp4DmyI8RHOje2RqD8pPxFGw0y1RHu8IQ21/ncLi0Rc4MtmXdJhJZ8QvZqJaSbfNb5A1DxMRlax/X4bgDi3jwQGGFLMLn4mfhQvKv1i8gg1EyZ29YL4291gWnrNO9XyHYjIhuMJiCLCXJ15hhc9eDaLgKj8URcDKFF00e0YeiJeC/zrmkanrNcG7o+B7C587d1slY0tO3C25rv38AI6D5AOOtDlz5B6YGRP/nJRRy2Se2/DlwYFUTQhWmR/X4PBTTfcv9wFjCRo6NY5kYl4pIHBM3NcxN0pdai/KaNOzqdwHm34B7OhWv04mUDeuOGlf3YAVnLMnpqSki0b8K+m4MM=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3199
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Lowry.Li@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(136003)(346002)(376002)(396003)(39860400002)(199004)(189003)(2616005)(8676002)(50466002)(476003)(66066001)(50226002)(11346002)(70586007)(36756003)(356004)(6486002)(86362001)(70206006)(26826003)(14454004)(81166006)(22756006)(1076003)(63350400001)(446003)(81156014)(8936002)(8746002)(478600001)(54906003)(6512007)(305945005)(486006)(102836004)(99286004)(6636002)(110136005)(76176011)(316002)(23756003)(3846002)(336012)(7736002)(386003)(6116002)(14444005)(5660300002)(186003)(2201001)(126002)(2501003)(25786009)(4326008)(76130400001)(47776003)(6506007)(2906002)(26005);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR08MB5121;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 3f63e72f-865e-41b2-9866-08d740c07d9f
X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(710020)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:AM0PR08MB5121;
NoDisclaimer: True
X-Forefront-PRVS: 0170DAF08C
X-Microsoft-Antispam-Message-Info: OBHVkqcv9R8jj+DpP4Xn2CNvmmv3ZBr2MNaYIqODCZiqL2LA1532ur0lFE1f6pAhRnUmKMsM9oKE1vmEdpn/BeuK7j6jIZq/N8HpZWn0LlwDQx12EUuwB/x+qvuBy68WIX7PJ1NB0l05rr2Tcq31JsKiSgf291GmOqIYid2FFfkM+iJRJe6EHd08SKb6tAm8LWbNUo0Zl6dS4XcXOjnNSP4JZ7c2Lw+3MUURBWk1NKJbBOvInfL24gAuG4pzZh4whl65M0R2Jf/WSGYIobIcg1UtSda9U1SN19xljExo8YzC8YgEwUvTJq3sgFQgKe+FR8msp0oMt48bFk/gEYcQIe0qFp1VCM7bo3npldSAK9m1J3SOQzfP8x/su/QF/Hs/dQQkyTDDgJsEfP0a06nIcqSG0bolC90sPT1QaYyx8k0=
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2019 07:26:29.6036
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d6458bc-cc38-485b-a7c1-08d740c08477
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5121
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>

Adds maximum line size check according to the AFBC decoder limitation
and special Line size limitation(2046) for format: YUV420_10BIT and X0L2.

Signed-off-by: Lowry Li (Arm Technology China) <lowry.li@arm.com>
---
 .../arm/display/komeda/d71/d71_component.c    | 49 +++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drive=
rs/gpu/drm/arm/display/komeda/d71/d71_component.c
index 357837b9d6ed..6740b8422f11 100644
--- a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
+++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
@@ -349,7 +349,56 @@ static void d71_layer_dump(struct komeda_component *c,=
 struct seq_file *sf)
 	seq_printf(sf, "%sAD_V_CROP:\t\t0x%X\n", prefix, v[2]);
 }
=20
+static int d71_layer_validate(struct komeda_component *c,
+			      struct komeda_component_state *state)
+{
+	struct komeda_layer_state *st =3D to_layer_st(state);
+	struct komeda_layer *layer =3D to_layer(c);
+	struct drm_plane_state *plane_st;
+	struct drm_framebuffer *fb;
+	u32 fourcc, line_sz, max_line_sz;
+
+	plane_st =3D drm_atomic_get_new_plane_state(state->obj.state,
+						  state->plane);
+	fb =3D plane_st->fb;
+	fourcc =3D fb->format->format;
+
+	if (drm_rotation_90_or_270(st->rot))
+		line_sz =3D st->vsize - st->afbc_crop_t - st->afbc_crop_b;
+	else
+		line_sz =3D st->hsize - st->afbc_crop_l - st->afbc_crop_r;
+
+	if (fb->modifier) {
+		if ((fb->modifier & AFBC_FORMAT_MOD_BLOCK_SIZE_MASK) =3D=3D
+			AFBC_FORMAT_MOD_BLOCK_SIZE_32x8)
+			max_line_sz =3D layer->line_sz;
+		else
+			max_line_sz =3D layer->line_sz / 2;
+
+		if (line_sz > max_line_sz) {
+			DRM_DEBUG_ATOMIC("afbc request line_sz: %d exceed the max afbc line_sz:=
 %d.\n",
+					 line_sz, max_line_sz);
+			return -EINVAL;
+		}
+	}
+
+	if (fourcc =3D=3D DRM_FORMAT_YUV420_10BIT && line_sz > 2046 && (st->afbc_=
crop_l % 4)) {
+		DRM_DEBUG_ATOMIC("YUV420_10BIT input_hsize: %d exceed the max size 2046.=
\n",
+				 line_sz);
+		return -EINVAL;
+	}
+
+	if (fourcc =3D=3D DRM_FORMAT_X0L2 && line_sz > 2046 && (st->addr[0] % 16)=
) {
+		DRM_DEBUG_ATOMIC("X0L2 input_hsize: %d exceed the max size 2046.\n",
+				 line_sz);
+		return -EINVAL;
+	}
+
+	return 0;
+}
+
 static const struct komeda_component_funcs d71_layer_funcs =3D {
+	.validate	=3D d71_layer_validate,
 	.update		=3D d71_layer_update,
 	.disable	=3D d71_layer_disable,
 	.dump_register	=3D d71_layer_dump,
--=20
2.17.1