Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1718088ybn; Thu, 26 Sep 2019 00:48:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqzCfLpKTYs/cTQBcAMyPjmgZjZy+wxJP+6PaCOTCDptCI51LyZWWKaGgbXLhLkBDFCPLuJp X-Received: by 2002:a50:eb03:: with SMTP id y3mr2171950edp.194.1569484127166; Thu, 26 Sep 2019 00:48:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569484127; cv=none; d=google.com; s=arc-20160816; b=ydYkm2z9d9XnziP0f9PA538wAQpQbCb+n3fKD3k9kpxY/kiJPLUe/q+GU9q9eFiy9T 5fS5lcdZFvcpOkbi58ItC0hgOAPmxRpKRo8zPi+IPPQUWVpN1PECCDx0qWV58/9VD9es tXpDmBs9a6SekURscUWEmMVJV6vzryDMZTmPaIMYEXlkvFRCW09HtT5oR2NdFJ9bK9ry Q4TVWzlCpfwqeYpw7Mg8JT3Rcr3CmVsS1xDR2XbhX71cVVO+rE/e+lyrFocZBckNNNpd iGQl+G6W5DJ90nQGAMOdFg7HC+YxLgAU5dQicIWsm4iRhxSRd/9i/N06DIgEfSkrp7x5 P7+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=zTAIzBlG72evi2cgoET66WS7OLBiEq9wKfjo4akk6iY=; b=hMmRtcR0HTnj0aNlJjh59ycY8e9ODweAYSY6hMVU154TkTPP2pBYS6/DHJtuhlhpGW B2rgvSZk3w+mBdaajdPFASj50H4OYuQ/xEEYHvkHEexix4T3mn2ROHIBw+EBYXSUyVzz nzJ4VSi8koz2/WAWWfaFKpGsUHOhVTO2PQCewnzyl8tdjvVbJYj28wBIoUTLGQbfaquW FKAVbw5bg2EpOT7uTQeq9QvG567g0dji1aZs12KzW7FtSEZZy1aubHNnA65jH81J/qJw rX5f/NgSyNMm19AoOXCLjOxr8XbIZZon8/faVDHu78No1kBV6Nv45TqsvkJviW2v9+ou 3gDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FZ+Hh60K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l22si588626ejz.239.2019.09.26.00.48.23; Thu, 26 Sep 2019 00:48:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FZ+Hh60K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504496AbfIXKxE (ORCPT + 99 others); Tue, 24 Sep 2019 06:53:04 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:51138 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387644AbfIXKxE (ORCPT ); Tue, 24 Sep 2019 06:53:04 -0400 Received: by mail-wm1-f67.google.com with SMTP id 5so1702639wmg.0; Tue, 24 Sep 2019 03:53:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zTAIzBlG72evi2cgoET66WS7OLBiEq9wKfjo4akk6iY=; b=FZ+Hh60KUFlgTLWM/xD3fFBsnzHbq9FsaV4vHvWIIQHTkJ+goAjqbWkTl0lD5q9lVu TQ/y/HbMpPwwN6A9pkuEWagjZlURawBTa8Xbfcpn6YllYwnrDtupck0W8U9WIVFN0hzo es9q/76FyXW1dxquq/tjOS+BM3y317aYFSyNDq5jqZmngaTwQ6LFIoPsQFwxg1PNbWDF ZQKn7sBXgX/7Cmu+SUyAvmTcH9odT4QJI3hXaZsODv/KN7c1TQZDMrPCE44goFQ/7rFy kVx7kCmjR82j2y7Vhyo1c4AWTkUzybDBcTz4w4yxgnTIwoSPKZpLkzF/V51pjtx71khF iNdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zTAIzBlG72evi2cgoET66WS7OLBiEq9wKfjo4akk6iY=; b=a9F4z0MeUJXcVW+BS4iMbeQqZIrl6UaQpmezcxaipiFWdmsz9irC5dw7pyle/Zn6VR QPVafAoRolk5PnG92LRSDbzpICd1mkkuB3YakmLXFpmbtKC8E8E9pM11VlB2jwU7OsMN lo94wjSbRdl8myVHHf6HV2K5RXO9IU2TM+zGMTutJVDiHxgHKQ8y/26WszGaWBoqoPO5 xRIa+xoUiAIhKUKObceplP4BLClaWMd1JlfmavlS4IMudEJQ4x6h0EaoS7cAiCHhQ56s jI9wdK1hi9Ah4nhAklWdmoIAr+16FHtGCoCWp8cD9sxASw9Pwmyjp1LYyY/+kKFNjg0P QKsA== X-Gm-Message-State: APjAAAXQvtZKyDaH9iRMobNlc6gyL/evBnGsK4yhCHzwvHLPZw6BQwOh EF/Mtrai1toarE9JgHZeHak= X-Received: by 2002:a1c:2144:: with SMTP id h65mr2310421wmh.114.1569322382016; Tue, 24 Sep 2019 03:53:02 -0700 (PDT) Received: from localhost (p2E5BE2CE.dip0.t-ipconnect.de. [46.91.226.206]) by smtp.gmail.com with ESMTPSA id y186sm3817474wmd.26.2019.09.24.03.53.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2019 03:53:00 -0700 (PDT) Date: Tue, 24 Sep 2019 12:52:59 +0200 From: Thierry Reding To: Anson Huang Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH] pwm: pwm-imx-tpm: Use 'dev' instead of dereferencing it repeatedly Message-ID: <20190924105259.GD14924@ulmo> References: <1569315667-1525-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pQhZXvAqiZgbeUkD" Content-Disposition: inline In-Reply-To: <1569315667-1525-1-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pQhZXvAqiZgbeUkD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 24, 2019 at 05:01:07PM +0800, Anson Huang wrote: > Add helper variable dev =3D &pdev->dev to simply the code. >=20 > Signed-off-by: Anson Huang > --- > drivers/pwm/pwm-imx-tpm.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) Again, positive diffstat and doesn't gain enough for it to be worth the churn, in my opinion. Thierry --pQhZXvAqiZgbeUkD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl2J9YsACgkQ3SOs138+ s6H7EA//c+M1K7oG4eadkixheMYBpEIjyymh8PkLi2meN3+11V9d0zFBvVRjuoUQ WyoSvQevjdLRO7oiD00k3Eq4oq12pW1nDKkYie2q/KhK/BkHxO9nZppcGmjxp2l5 vf8g076NvJ3Fuwg8e7aWiNPGDHuy+fSrF2wzX174wMZ6z08s3iCFfkfF68PqxYAx uO6/QC0Ici6CvltPqVrIMYLtn89BbQYVm5GivwAbzkfoukfcvEyMnPRtsMMLPwys vuHSVpAy6BaQ0q30fqjErVEMDv/nBmBnK+Wk0S4mkt+31rBARoqhoAxPqU2RTsFT xekt/OoywxVDS4VsFulovvTSC4MRzFFN39z0IiWQq4nlfpVZqYTPm5+Gh0vIRhtl Yk6ASiRKbLVBfHTMVKoM2ojwHzLoRu7k6P78POdHdiVVdO2LCCdQQZIfW9mOApO3 fEwqdKaRSfQY/MCv+nyoNYB+Slx+2h6qKon6uracPgaYKPasZILcgWQAummpP2OL yRox2Bk1NDjkXk0Rb/OcQkG5OwoPh/FIbfsoZHwUl2GxO3tJKZcOnCDTcu9B7aEf txM17yl9fcS166Ir1yhdna/l1mrC+/Rysc7jfYpUC5D26V1K1zwODYlELFGqGY6Q 21LKYO/js44tPqj0CuJz8DHnGS4RLcn7mQr7b1MXN01ue01DwGk= =AXDg -----END PGP SIGNATURE----- --pQhZXvAqiZgbeUkD--