Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1740537ybn; Thu, 26 Sep 2019 01:15:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqzw5f6nNLuruaJCXY/GLJqHUjQVOcQfGn4rR6XdSeq7CLYNk5cEO/mXWcERyXzeuvXJxBXB X-Received: by 2002:a17:906:3108:: with SMTP id 8mr1944053ejx.11.1569485759839; Thu, 26 Sep 2019 01:15:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569485759; cv=none; d=google.com; s=arc-20160816; b=eLjNdOrmXv2ZJ4ijiylNDLmWllwBid8uByF5G1ypVe9cyuTm2VSsDTJLZLmET3YqBl IoM69r2KcRRh8RmYLiekSScFkhwOrXccgvcVSAwp9YvOrZczSXC/IpSsjqs8VPBRud59 L6yxH3fq8NIKh58k2apDv8KhoYWihJ39hx2/C8pYrIlaTCYwwS4BGb3u2l+ACtIDVVeh rhM/1/lrpV9vpLBTwKszYLmTUxCWCEDTAWLXqt/H3PusGud3ULKDYcKDyZCtnE6tK9IZ RjJnclkBLFoQgqVdPXUsH4+RbCknZoz0KHZgPgh+1IGRAn1Bxd7+jqsHycKX+suZ8uyi 1xWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=edbhVmlmroheHUTOyrQhNd1DTonC9VasBufzyh4r8vE=; b=JhqObcfssBByCEGKZTOtOCeT+o7U1LnjZaJB2zEAgibd7SB79P3ORahbkpu8l9Jvtj L+Y3EregtuAHk/r8NNs4zyllUuxAR0THhrATzaPSawOXDpC9wdTcls5GvP6bZvpoOrBQ nR4h8sqT968wuAhKvNgl74UrhvSSe/KBODzP13oMRjfpGFVgXPohguwl+iuI+4EfhdeQ Tij5zEBaPZxswHFb7dD/seVf9SIqemktkf1IMWCvPN4L993tFZYjr4Pw/E79cRH9Ocxg Q6xtUbqblKNEsPEzJGh8rV0rDBFp84y++YRFhjhVKADYzdBXkF0gI/1PtLqVY09D8kL6 ikeg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8si902755edd.355.2019.09.26.01.15.36; Thu, 26 Sep 2019 01:15:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2441423AbfIXOpb convert rfc822-to-8bit (ORCPT + 99 others); Tue, 24 Sep 2019 10:45:31 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52592 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbfIXOpb (ORCPT ); Tue, 24 Sep 2019 10:45:31 -0400 Received: from localhost (231-157-167-83.reverse.alphalink.fr [83.167.157.231]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id DB0881527F8DE; Tue, 24 Sep 2019 07:45:29 -0700 (PDT) Date: Tue, 24 Sep 2019 16:45:28 +0200 (CEST) Message-Id: <20190924.164528.724219923520816886.davem@davemloft.net> To: uwe@kleine-koenig.org Cc: talgi@mellanox.com, saeedm@mellanox.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] dimlib: make DIMLIB a hidden symbol From: David Miller In-Reply-To: <20190920133115.12802-1-uwe@kleine-koenig.org> References: <20190920133115.12802-1-uwe@kleine-koenig.org> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Sep 2019 07:45:30 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Uwe Kleine-K?nig Date: Fri, 20 Sep 2019 15:31:15 +0200 > According to Tal Gilboa the only benefit from DIM comes from a driver > that uses it. So it doesn't make sense to make this symbol user visible, > instead all drivers that use it should select it (as is already the case > AFAICT). > > Signed-off-by: Uwe Kleine-K?nig Since this doesn't apply due to the moderation typo being elsewhere, I'd really like you to fix up this submission to properly be against 'net'. Thank you.