Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 24 Sep 2019 16:52:40 +0200 (CEST)
Message-Id: <20190924.165240.1617972512581218831.davem@davemloft.net>
To:     esyr@redhat.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        ubraun@linux.ibm.com, kgraul@linux.ibm.com
Subject: Re: [PATCH net v2 0/3] net/smc: move some definitions to UAPI
From:   David Miller <davem@davemloft.net>
In-Reply-To: <cover.1568993930.git.esyr@redhat.com>
References: <cover.1568993930.git.esyr@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Eugene Syromiatnikov <esyr@redhat.com>
Date: Fri, 20 Sep 2019 17:41:47 +0200

> As of now, it's a bit difficult to use SMC protocol, as significant part
> of definitions related to it are defined in private headers and are not
> part of UAPI. The following commits move some definitions to UAPI,
> making them readily available to the user space.
> 
> Changes since v1[1]:
>  * Patch "provide fallback diagnostic codes in UAPI" is updated
>    in accordance with the updated set of diagnostic codes.
> 
> [1] https://lkml.org/lkml/2018/10/7/177

Isn't it way too late for this?

These definitions will now be duplicates for userland code that
defines the values on their own.