Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jeroen Hofstee <jhofstee@victronenergy.com>
To:     "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
CC:     Jeroen Hofstee <jhofstee@victronenergy.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Marc Kleine-Budde <mkl@pengutronix.de>,
        "David S. Miller" <davem@davemloft.net>,
        "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/7] can: rx-offload: continue on error
Thread-Topic: [PATCH 1/7] can: rx-offload: continue on error
Thread-Index: AQHVcwhCgRg367Eiu0mUgNTGybynuQ==
Date:   Tue, 24 Sep 2019 18:45:38 +0000
Message-ID: <20190924184437.10607-2-jhofstee@victronenergy.com>
References: <20190924184437.10607-1-jhofstee@victronenergy.com>
In-Reply-To: <20190924184437.10607-1-jhofstee@victronenergy.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: git-send-email 2.17.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 831b48af-d289-4e34-e504-08d7411f646d
x-ms-traffictypediagnostic: VI1PR0701MB2847:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <VI1PR0701MB28477A5A9A9DA7CFD6843FB3C0840@VI1PR0701MB2847.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6430;
x-forefront-prvs: 0170DAF08C
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(376002)(366004)(39850400004)(346002)(136003)(396003)(189003)(199004)(81156014)(86362001)(2906002)(2351001)(14454004)(305945005)(478600001)(8676002)(2501003)(36756003)(7736002)(6116002)(25786009)(8936002)(50226002)(81166006)(46003)(76176011)(11346002)(66476007)(6506007)(6916009)(446003)(102836004)(186003)(2616005)(4744005)(1076003)(6486002)(66946007)(64756008)(486006)(476003)(66556008)(66446008)(5660300002)(54906003)(71200400001)(71190400001)(14444005)(5640700003)(6436002)(52116002)(386003)(4326008)(256004)(316002)(99286004)(6512007);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0701MB2847;H:VI1PR0701MB2623.eurprd07.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: victronenergy.com does not
 designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: rnzeSONcOL3+zeHGHhT9JawLaAVOBUb/S2kKw6de6dI2c9enh7ynOJ8Tiu5V73brF/p7B1rZH6hFuhkAuqZawM/8Qz2ce1tzWwI1GDIPZ2M2d0+dfQjjaGqE5UZn+el4msRvxhfQw8hdGjqGspZeYmJAVCmXM66yFzkjA8kNfI8hZK3+kIspc7w7/Dpjp/quyYurV3+sY0XTUFLAJmGRUoMEgpyujwIJYFwuXUS+/y+B3U3NCvjmzNVsWsc7hrdI9iSU7mgkhsd7XFiHxemFd2f1rWB30roW9eqquyoKS6893I1MBlWMYnzLjl5bqU2kaBospgE6oHfGTPsI57rLZM0vxZynW8C5+nFgBE+vjZNvA2VOFbZoXLhrB0CCuDQlKJDV1X8utGtBrizP21OG7TAHgwPV9PooxWsQuU/ajEk=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: victronenergy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 831b48af-d289-4e34-e504-08d7411f646d
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2019 18:45:38.3318
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 60b95f08-3558-4e94-b0f8-d690c498e225
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uxXy8/7x37aT6eP0T5EBgFj6tz6+6POZNJ+6CJyl1nUEJp03O9/RyFIajJPCgAWpUkMwDStu5KVn+5vUl6aySWjABMlOOAHsFmshx5P64tA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0701MB2847
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

While can_rx_offload_offload_one will call mailbox_read to discard
the mailbox in case of an error, can_rx_offload_irq_offload_timestamp
bails out in the error case. Since it is typically called from a while
loop, all message will eventually be discarded. So lets continue on
error instead to discard them directly.

Signed-off-by: Jeroen Hofstee <jhofstee@victronenergy.com>
---
 drivers/net/can/rx-offload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/can/rx-offload.c b/drivers/net/can/rx-offload.c
index e6a668ee7730..39df41280e2d 100644
--- a/drivers/net/can/rx-offload.c
+++ b/drivers/net/can/rx-offload.c
@@ -158,7 +158,7 @@ int can_rx_offload_irq_offload_timestamp(struct can_rx_=
offload *offload, u64 pen
=20
 		skb =3D can_rx_offload_offload_one(offload, i);
 		if (!skb)
-			break;
+			continue;
=20
 		__skb_queue_add_sort(&skb_queue, skb, can_rx_offload_compare);
 	}
--=20
2.17.1