Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1768622ybn; Thu, 26 Sep 2019 01:49:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqwOaCCrMiyDqPsQw/+UY629eYmOBznj9aBDF4wCQ+eWs6v0FmO7nfwAVeJOPm/wRtBE/WYy X-Received: by 2002:a50:87ca:: with SMTP id 10mr2312876edz.77.1569487754538; Thu, 26 Sep 2019 01:49:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569487754; cv=none; d=google.com; s=arc-20160816; b=eZL++3dr1lt9eTg0tdZNQT3tjWknPAfMPtHjDRcIOJkaZIoqxo554QN3w90pPffsQw /XbuapOFyBZ/ssjT4Go8NhKL+JwZaoEQuJkO87gnGoOWcMo82qqnStIN/sUDE2Sf87eP ERYfVaU/RNW9H35r6ZAdrR2OqLNIFVP6L81upZr8QDib3tSo9jH5Zni7SUWJYPymx6Ne 3PJx90Qrx0/C+twu6VSfWZem5T54TsKZajFgTnsEoVV4UCL2k2e7IFnEmHys4epSJMLR ZIALiCOq4Cs+CsCiCsWCMxzRDwrlkMFcWFAiE+hKrpU7AYf4tilJ2tPoxy32Upy3DTh3 ETFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=oYp4h4DDWj4+o1E157uiUupbT+7DvYD/91YZ9IAk9f8=; b=hfEahe3mhnkWZl7J4GSry91l/hak81f+TAYe9hN8DUtTtsMzSL6ILjveGX3pgasdhB 6bkRsuD/Ujh/bhB7En3wVpHVWgcFZoiYv+Vlju760YSZRO4IeddVunQKA7VOSQFzw6JW jQeP4LMRqzKlatg+E6yGTGQmLOVmuhW1Km3qNVCAVHt2fJ96tAxFgBEwdJ+OKw21Un7x 8/U7sesJ1FniIntXZzLVQxdj8QAJMS/f/QQ+NldtZ+ZznFZS7E2VXVzJ2Kf73uojghj6 FXud8G3JIi9a9JIlYgzCasFKMaozREk9dWQDnFOHCxq9b7SZKn3qDLIVA2SjPAHqzYKs qx9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r18si647878ejr.189.2019.09.26.01.48.51; Thu, 26 Sep 2019 01:49:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2442010AbfIXUrx (ORCPT + 99 others); Tue, 24 Sep 2019 16:47:53 -0400 Received: from gentwo.org ([3.19.106.255]:49372 "EHLO gentwo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726236AbfIXUrx (ORCPT ); Tue, 24 Sep 2019 16:47:53 -0400 Received: by gentwo.org (Postfix, from userid 1002) id 513AF3E9FB; Tue, 24 Sep 2019 20:47:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 4FE343E9E5; Tue, 24 Sep 2019 20:47:52 +0000 (UTC) Date: Tue, 24 Sep 2019 20:47:52 +0000 (UTC) From: cl@linux.com X-X-Sender: cl@www.lameter.com To: "Darrick J. Wong" cc: dsterba@suse.cz, Vlastimil Babka , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pekka Enberg , David Rientjes , Ming Lei , Dave Chinner , Matthew Wilcox , Christoph Hellwig , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, James Bottomley , linux-btrfs@vger.kernel.org, Roman Gushchin , Johannes Weiner Subject: Re: [PATCH v2 2/2] mm, sl[aou]b: guarantee natural alignment for kmalloc(power-of-two) In-Reply-To: <20190923175146.GT2229799@magnolia> Message-ID: References: <20190826111627.7505-1-vbabka@suse.cz> <20190826111627.7505-3-vbabka@suse.cz> <20190923171710.GN2751@twin.jikos.cz> <20190923175146.GT2229799@magnolia> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Sep 2019, Darrick J. Wong wrote: > On Mon, Sep 23, 2019 at 07:17:10PM +0200, David Sterba wrote: > > On Mon, Sep 23, 2019 at 06:36:32PM +0200, Vlastimil Babka wrote: > > > So if anyone thinks this is a good idea, please express it (preferably > > > in a formal way such as Acked-by), otherwise it seems the patch will be > > > dropped (due to a private NACK, apparently). > > Oh, I didn't realize ^^^^^^^^^^^^ that *some* of us are allowed the > privilege of gutting a patch via private NAK without any of that open > development discussion incovenience. There was a public discussion about this issue and from what I can tell the outcome was that the allocator already provides what you want. Which was a mechanism to misalign objects and detect these issues. This mechanism has been in use for over a decade.