Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1773106ybn; Thu, 26 Sep 2019 01:55:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqyHEtEWiT4q4CmKSS9/WxRwFN94bSYfdjJsRg7z88GSa8IlIN+nOJUhEChp3ANIvCEFJdx9 X-Received: by 2002:a50:8a21:: with SMTP id i30mr2245286edi.229.1569488106519; Thu, 26 Sep 2019 01:55:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569488106; cv=none; d=google.com; s=arc-20160816; b=NIht27sI/f+OlBazj0C1VuYkMf7L/VSZiEHGWdz8rZ8Ejdy8bnuGKqsP1ZvoLLX2T7 hc6WMGowjC9Jn5xLvHOqXDPkNVqwk+fHlkcdwC8sirFrZLUZDNcBDxhAklR5JbOrTTl8 30YgeUHGYRIQbBjD7UPp2tSoS2bkNS+G98O+8/qiClqu/mNobTv4aOyqw9IWa5y+rskn t8SlkCV32gbV9NH5o/bbderM0g73n1ExDLtgPpPFZRHp4Rv0MPyM68lzzuUT7mKzgiji UGw6DXuDVBih9pwGBn8n103AU5KEL7b9Zne83DHh7n2Bva9gSQziMC6qjWIpgTdlRT6C v7zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=E1xMc24hYDUgJip/G3+nSaUWwisuKmB+ZHuc94zHHzk=; b=tXZX8O0YHJuVNaYUXDBYXjGAzaDPkNM3C/ie2lnyl/6giWBuYE1wzHikKSWnZ84LMC E+K1S826UxD/AX8UHyE6YYWp5QoTo1IK7aB/IJ73qdaRL2JkH9sv2BBzgBZKtc3LrCyp /9faBxx37Qk6JSjdvixVLgWPw76MsGFcpUBbC07NS7C6z2GENoNckXevF/jgyRrL4y4E Yo1lRl3nIvzuBIeAC0gnRBUiuR2gPhtET8/1m0J0kU6Ee2B2VdROhaDu8IAH9pj6NoBH 0IkaxO6Og4aJqFi2nydLwuYtgbTUcVTcyZWEeFmrDsF5ulrcqB2c9t9iwgrd0PDMYxyU htaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=d0ptLuEY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q10si898290eda.293.2019.09.26.01.54.43; Thu, 26 Sep 2019 01:55:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=d0ptLuEY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438749AbfIXVw0 (ORCPT + 99 others); Tue, 24 Sep 2019 17:52:26 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:35927 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728183AbfIXVwZ (ORCPT ); Tue, 24 Sep 2019 17:52:25 -0400 Received: by mail-pg1-f195.google.com with SMTP id t14so1586877pgs.3; Tue, 24 Sep 2019 14:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=E1xMc24hYDUgJip/G3+nSaUWwisuKmB+ZHuc94zHHzk=; b=d0ptLuEYVEam1DP6UXz3ufvlKv0Rh2f7QGWIYd0pimxpen92m1nCjH63Y3oUmfgXdM e9vRofKj6tTXOAtvr+g2/9a4OV7tQDiVwVV3Kh3Sve7pqmIzmgRUghHnaZynH67SHnHW rIgf7ruRl3rhqnhyBHw02V8XZZKblWPDyB8D3/iet4MIZpE4iw5EZtcTjUztACEmkZLL 1qjjugP3Ww2u7zIQkdavyfSi2BMnClZMrdlHfrmnhP4EwsJZcIS9b6CNLzqrxxbn7x7b fO0hIcWTRFU/XT3rix7PftJL6Pji5+QETeii4ZwTtvNk/+xxeGBV169AGXUu6Hlki8Xd onNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=E1xMc24hYDUgJip/G3+nSaUWwisuKmB+ZHuc94zHHzk=; b=nZ+hFJF7PBiAnu8O3Ub6k/bUgpr68NjurfcNV1ml/sNdFncFYz4BOFNaBFa7CUF0da HvaO8S7g6EbxRcbcevftnj7O6NDCFksFwlyw+V5wazU5Y7NT/YSU4QimKQBK0uPaGhDF S7Ik1fEUpx4O/BoJTk28UvMHW/XOixy0jFR+lC/aXu6cq7GthRIAi/59Kt9+R3UIFc7u +EMCKNqCrkv4P4Leulf1vfICIyHP3fVroAhakHKAiZtU8rQTP6KMhrKp1rB6Og1VvKXP X3gcdyr+kGh3jiCdau4yNqVb7/sL1dm6gWvtna7cDScg7tSFnAxEHS6IyOHLlV6hRXIc hX+A== X-Gm-Message-State: APjAAAVgIuQC9bvgqGCPGeqnXj7v8jSWVMpqMs9/p2Ob9KvrvtJ4sS17 RK1v1NjrEMrNd863p9v3xEg= X-Received: by 2002:a63:20d:: with SMTP id 13mr5329837pgc.253.1569361943377; Tue, 24 Sep 2019 14:52:23 -0700 (PDT) Received: from Asurada-Nvidia.nvidia.com (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id h2sm6197465pfq.108.2019.09.24.14.52.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Sep 2019 14:52:23 -0700 (PDT) Date: Tue, 24 Sep 2019 14:51:35 -0700 From: Nicolin Chen To: Shengjiu Wang Cc: timur@kernel.org, Xiubo.Lee@gmail.com, festevam@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, lars@metafoo.de Subject: Re: [PATCH V4 3/4] ASoC: pcm_dmaengine: Extract snd_dmaengine_pcm_refine_runtime_hwparams Message-ID: <20190924215135.GA2277@Asurada-Nvidia.nvidia.com> References: <4d9aab898650c68ea57c10067830dac884eb7439.1569296075.git.shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d9aab898650c68ea57c10067830dac884eb7439.1569296075.git.shengjiu.wang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 24, 2019 at 06:52:34PM +0800, Shengjiu Wang wrote: > When set the runtime hardware parameters, we may need to query > the capability of DMA to complete the parameters. > > This patch is to Extract this operation from > dmaengine_pcm_set_runtime_hwparams function to a separate function > snd_dmaengine_pcm_refine_runtime_hwparams, that other components > which need this feature can call this function. > > Signed-off-by: Shengjiu Wang Looks good to me. Reviewed-by: Nicolin Chen