Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1782245ybn; Thu, 26 Sep 2019 02:04:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqz7dl6B71irX1TbtAY/pRKGz2TMpPdHvnSZFDHWt8drBFC3PJtaXHyjOQpBL3TV1FMnej7u X-Received: by 2002:a05:6402:7c1:: with SMTP id u1mr2381172edy.198.1569488693874; Thu, 26 Sep 2019 02:04:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569488693; cv=none; d=google.com; s=arc-20160816; b=gjUyWMz5ESG9CsakLL5VUJAYGaofIqXlf2iWY1QdI3D9wxNTpabjAFzFhmQ8GC1eLN Xdz0+UgLrt6urDnw6s7pvz0UJ2v66mOWMHC8dBrHNs0FLKIYwEXQve5CZkJrpqRM58U7 QuRaAw2yP5d34Ql7EMx1tT9VAf9+9/3xbRO75Mq41siRMe8wc8kac8HSttD0mlwXGQda 4QB1r8pHaObcycdYOueqqRJzWing6rCNkXk+qivAL++OWcn/bqZNHBnceYW6f4+m2XWQ I7+cecII/6Ge3tign1KECBCSjigIyXKWwoewqi8Mi6u6GpJVbqH7v5xNYGOLmJ7BRHSm R0ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=UBZs2NXpZFnZ92bWRT1m6QMl78ILPonr+BO0OqAxbFI=; b=U7AUcfpNwWp7ODLtM0YCoc4QbVFjsdu7F6N3gKHJRp8RhhjnpV/0yORbLYoGpbW8eZ DHlrGhprAWhGaJp2kTYU8jPScpVtVLvN0s6AQL4rVh3tfchatS4w4eriAeECUEss6Xs1 Go340Mp9kpmV5rKwCwkRvNS0I+w4mtqv60RFdB9BFTkOD7+vd7/n+yN34axRuae9oCxT 9xjt+FIk8GOeRkjn/z/zeacOfX4/EJVea7lcLgDk9+Z8uxMGp2g9m1u4c3R0/ZHvRNMZ xAYYPz7/cscP9BPLdw/UQ3tsp3JMkdXPaU9I+kn6Rhx1xV1wb3UjeAj4IxqZOn1LLG// Aang== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d4si661149ejy.154.2019.09.26.02.04.27; Thu, 26 Sep 2019 02:04:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2633618AbfIYBpT (ORCPT + 99 others); Tue, 24 Sep 2019 21:45:19 -0400 Received: from mga03.intel.com ([134.134.136.65]:20126 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727329AbfIYBpT (ORCPT ); Tue, 24 Sep 2019 21:45:19 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2019 18:45:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,546,1559545200"; d="scan'208";a="218832982" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga002.fm.intel.com with ESMTP; 24 Sep 2019 18:45:16 -0700 From: Wei Yang To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Wei Yang Subject: [PATCH] x86/mm: fix function name typo in pmd_read_atomic() comment Date: Wed, 25 Sep 2019 09:44:53 +0800 Message-Id: <20190925014453.20236-1-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function involved should be pte_offset_map_lock and we never have function pmd_offset_map_lock defined. Fixes: 26c191788f18 ("mm: pmd_read_atomic: fix 32bit PAE pmd walk vs pmd_populate SMP race conditio") Signed-off-by: Wei Yang --- Hope my understanding is correct. --- arch/x86/include/asm/pgtable-3level.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/pgtable-3level.h b/arch/x86/include/asm/pgtable-3level.h index e3633795fb22..45e6099fe6b7 100644 --- a/arch/x86/include/asm/pgtable-3level.h +++ b/arch/x86/include/asm/pgtable-3level.h @@ -44,10 +44,10 @@ static inline void native_set_pte(pte_t *ptep, pte_t pte) * pmd_populate rightfully does a set_64bit, but if we're reading the * pmd_t with a "*pmdp" on the mincore side, a SMP race can happen * because gcc will not read the 64bit of the pmd atomically. To fix - * this all places running pmd_offset_map_lock() while holding the + * this all places running pte_offset_map_lock() while holding the * mmap_sem in read mode, shall read the pmdp pointer using this * function to know if the pmd is null nor not, and in turn to know if - * they can run pmd_offset_map_lock or pmd_trans_huge or other pmd + * they can run pte_offset_map_lock or pmd_trans_huge or other pmd * operations. * * Without THP if the mmap_sem is hold for reading, the pmd can only -- 2.17.1