Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1787669ybn; Thu, 26 Sep 2019 02:09:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqzJZMbDc4cJ3NZD5Gm0+RwMAgZbemAGtX7/lalhgkOM0ju0G6XtAcTF6vxDZW/aBiD6KfEs X-Received: by 2002:a17:906:82d3:: with SMTP id a19mr2034937ejy.151.1569488988438; Thu, 26 Sep 2019 02:09:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1569488988; cv=pass; d=google.com; s=arc-20160816; b=Br//qiZJ5vtFsBmQI9QAtfAV+6zZag4/OrP/+U4rp65P6OITeHdC1GvNgp6QR9Bvqg 3zZbpaT5mEnb2Mak/999XN0POnySATN6rxthZGWYiJLhW744BchCx3MLeBQ3pZSX/ies pORbePHwlyrbo4fInoyfX0vCbwOCkCaqSPkw6LP3pcQjbJLryFK7WidBzpeyerkYwzzm ocdBUSCjx4bQEjB+ta6alEFd0I3fiXglDOkchMMU/ZemnDob81I1ci+yejUG1ZYxg8I6 r8ZFuBDHjbP5yqDty0Drnk18lQgPI5EweKLhuKHUp6GUtF6d9qROfACFBQdlW1nX52UH 8y8w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=9gPHhrxSS5RyrbR7T8Oh9S5esSP6LfVKH3fYxdNWa/I=; b=NsUOS2xhQ83w0x1SZkl8DJjg+SBRQ5LbF5cVK4+CjyoWaJCmw5tGxgSGHLzd8p3sO4 6Cq53ox7s7iJFGTssQnL62HFJsom8YKtJW3m/lFK1cxurVpAHblPfqEosjgoTsm/WzCm 91bQAVSXPtek6+yg2wx0Sm1/gda1QIU93eArv7liv1qshZDAAXQ3sccuSOJbcbj7kFsE 2nl+56dV21nk1gfkATOgw2S8L/5fAEJ54E3xftxaze7B3N1UTBOijD+7z8QqDvl/lTeY URoZQrP3ZMifCEwBmui0n233d8je4hMk1ljs4qwGsMzqDhvlfwlKBqS9KW0+hPjib4lI TMPQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=ageJebil; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id oz25si637072ejb.175.2019.09.26.02.09.24; Thu, 26 Sep 2019 02:09:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=ageJebil; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2411450AbfIYDNw (ORCPT + 99 others); Tue, 24 Sep 2019 23:13:52 -0400 Received: from mail-eopbgr00057.outbound.protection.outlook.com ([40.107.0.57]:63367 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2391325AbfIYDNv (ORCPT ); Tue, 24 Sep 2019 23:13:51 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gZt/p+meZcs9bTqCAS+LVS2t8lUQVOjQxOAicCpo28CC6hFP/tNbIkCSYjKgoUlc5Xa/WSV2tUFfBQDJpjpeAI42dt4FfIIWWo0ZgCARPYOTzMfmHBfUSKuKJnEsOkg87cElJLnqQHg38SNfgLlmGHjHcimCNJDGqXIl4A+cRPdbNg3BUcOaGrThlJp32CzYEziQyhWbdJCFkRafOgcBuAhXhdIce/xHfFOm8Tvw9KTfjO5qxLTlK0+FiuxfSHxTGFilrCN/THXzq2aT5vV0i0FWaj28+FMIMBeEai5VFchjrookY4dn6oZF0Myxee3XFu6W41kKZ3QPviM16Hbp2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9gPHhrxSS5RyrbR7T8Oh9S5esSP6LfVKH3fYxdNWa/I=; b=Qu98TRwRabPNHMh+rwU0oJV1TAtEfNaGdGQqVgBV44Qsp8OhrGc1LVKI3Svi4IbtTl7rf6yx4xOtDsSgAARH0kaTiQGYAnrGw5QQOe4XzVs1tcBi6nT11m3MDHBdjJZtJgQmh7ZrrNz24WGVPFcRYdN8mKx0g5p9Qqyv74Bnu01HQNRIGeX/splCfhsAAAYKZymiNS2Mv9wsSyq69LJP2pu+I17m8rOfWk40uSB9D1CuxXHBwbWpZIV2uOC6xHoBPbgw3FBLQYE+QYTBEZ2weBfDwhwoL2LOqsRjPyRAo/5TY/E/cYiCZcSo0oTzdIxI4ln3UmMTJokkGXaGFAT8MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9gPHhrxSS5RyrbR7T8Oh9S5esSP6LfVKH3fYxdNWa/I=; b=ageJebilx9+uO8ZDHRp4WpElodreLQWZebpAqG9yTio1cqn+QJ4EDWs5ayFNK53H9QvX+fXrwR4c/w8TbsgAscaykz3eT5rp9b6vBxsJrWLBgVqvmokHlsGAs/QIE7vGmT8WpEdPunwAZJBm09lna+tVES3pPSNkDJEl9G+kC6E= Received: from DB7PR04MB4490.eurprd04.prod.outlook.com (52.135.138.150) by DB7PR04MB4713.eurprd04.prod.outlook.com (20.176.233.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.20; Wed, 25 Sep 2019 03:13:08 +0000 Received: from DB7PR04MB4490.eurprd04.prod.outlook.com ([fe80::4427:96f2:f651:6dfa]) by DB7PR04MB4490.eurprd04.prod.outlook.com ([fe80::4427:96f2:f651:6dfa%5]) with mapi id 15.20.2284.023; Wed, 25 Sep 2019 03:13:08 +0000 From: Biwen Li To: Leo Li , "shawnguo@kernel.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , Ran Wang CC: "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: RE: [v3,3/3] Documentation: dt: binding: fsl: Add 'fsl,ippdexpcr-alt-addr' property Thread-Topic: [v3,3/3] Documentation: dt: binding: fsl: Add 'fsl,ippdexpcr-alt-addr' property Thread-Index: AQHVcoOnab7d5ysBNkWsXmY0PrfSuKc6/L+AgAC3JZA= Date: Wed, 25 Sep 2019 03:13:07 +0000 Message-ID: References: <20190924024548.4356-1-biwen.li@nxp.com> <20190924024548.4356-3-biwen.li@nxp.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=biwen.li@nxp.com; x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 382b4caf-c68b-46f1-f8a8-08d741664a10 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:DB7PR04MB4713; x-ms-traffictypediagnostic: DB7PR04MB4713:|DB7PR04MB4713: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 01713B2841 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(366004)(136003)(39860400002)(346002)(376002)(396003)(189003)(199004)(9686003)(55016002)(6436002)(33656002)(14454004)(229853002)(99286004)(71200400001)(71190400001)(76176011)(256004)(102836004)(7696005)(6506007)(6116002)(5660300002)(3846002)(64756008)(66446008)(14444005)(66556008)(66946007)(66476007)(2906002)(76116006)(52536014)(26005)(316002)(54906003)(110136005)(486006)(25786009)(2501003)(478600001)(44832011)(476003)(186003)(11346002)(446003)(6636002)(66066001)(8676002)(4326008)(81166006)(86362001)(81156014)(8936002)(6246003)(305945005)(74316002)(7736002)(142933001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB7PR04MB4713;H:DB7PR04MB4490.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: UGiv/bNKp5XgxrqM7wAW4gqocxz2dt3Af46/b2DN0ctneUVjCpaioQcF6pyZ3x8vJBW6hT7icUvFXSExiVPeQctZjeSJrzZjGN6kN9aF2WgzNk0qzwER5boKx4x5xkxuXTbQrw2PqK2Ubv4sOgaLMUBCQc2Eaqom53ogmpKAxSGXdkVd/I0nP1Tgcq5Yf9XNzW3LRAlA8Dbg1m5WdyFHM6w1OaSyIO1Zxbp4aq1cjFTduH/9o0sKBJsDbuGVNdWBMHcCvzsh//Pb8XYbEPuY7a8rj1c0+OK5JKVpryOJ4dAVQRUQ59B+nUUq2sBdOI7y8X3YUuHijTn9mrfCGj0KVfyCKjx1un5kWQzQVvFmSE6vh11uGql7oQ1LN+MnU51TfL1Dt1umL9I1x8gpSFmo7zsXXKStlcpMd6SYkn9I/gM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 382b4caf-c68b-46f1-f8a8-08d741664a10 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Sep 2019 03:13:07.7962 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zUYo23gCzHkhcFC+g3kwNSqUITfR5n0ZRynSq2s6Qd+K1q4sYJQURPy8FIqfFtnb9BbBcD7aNV/2hKQ6N63SHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4713 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > > The 'fsl,ippdexpcr-alt-addr' property is used to handle an errata > > A-008646 on LS1021A > > > > Signed-off-by: Biwen Li > > --- > > Change in v3: > > - rename property name > > fsl,rcpm-scfg -> fsl,ippdexpcr-alt-addr > > > > Change in v2: > > - update desc of the property 'fsl,rcpm-scfg' > > > > Documentation/devicetree/bindings/soc/fsl/rcpm.txt | 14 > > ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > > b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > > index 5a33619d881d..157dcf6da17c 100644 > > --- a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > > +++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > > @@ -34,6 +34,11 @@ Chassis Version Example Chips > > Optional properties: > > - little-endian : RCPM register block is Little Endian. Without it RC= PM > > will be Big Endian (default case). > > + - fsl,ippdexpcr-alt-addr : Must add the property for SoC LS1021A, >=20 > You probably should mention this is related to a hardware issue on LS1021= a > and only needed on LS1021a. Okay, got it, thanks, I will add this in v4. >=20 > > + Must include n + 1 entries (n =3D #fsl,rcpm-wakeup-cells, such as: > > + #fsl,rcpm-wakeup-cells equal to 2, then must include 2 + 1 entries)= . >=20 > #fsl,rcpm-wakeup-cells is the number of IPPDEXPCR registers on an SoC. > However you are defining an offset to scfg registers here. Why these two > are related? The length here should actually be related to the #address-= cells > of the soc/. But since this is only needed for LS1021, you can just make= it 3. I need set the value of IPPDEXPCR resgiters from ftm_alarm0 device node(fsl= ,rcpm-wakeup =3D <&rcpm 0x0 0x20000000>; 0x0 is a value for IPPDEXPCR0, 0x20000000 is a value for IPPDEXPCR1). But because of the hardware issue on LS1021A, I need store the value of IPP= DEXPCR registers to an alt address. So I defining an offset to scfg registers, then RCPM dri= ver get an abosolute address from offset, RCPM driver write the value of IPPDEXPCR registers to these abosolute addr= esses(backup the value of IPPDEXPCR registers). >=20 > > + The first entry must be a link to the SCFG device node. > > + The non-first entry must be offset of registers of SCFG. > > > > Example: > > The RCPM node for T4240: > > @@ -43,6 +48,15 @@ The RCPM node for T4240: > > #fsl,rcpm-wakeup-cells =3D <2>; > > }; > > > > +The RCPM node for LS1021A: > > + rcpm: rcpm@1ee2140 { > > + compatible =3D "fsl,ls1021a-rcpm", "fsl,qoriq-rcpm-2.1+"; > > + reg =3D <0x0 0x1ee2140 0x0 0x8>; > > + #fsl,rcpm-wakeup-cells =3D <2>; > > + fsl,ippdexpcr-alt-addr =3D <&scfg 0x0 0x51c>; /* > > SCFG_SPARECR8 */ > > + }; > > + > > + > > * Freescale RCPM Wakeup Source Device Tree Bindings > > ------------------------------------------- > > Required fsl,rcpm-wakeup property should be added to a device node if > > the device > > -- > > 2.17.1