Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1789062ybn; Thu, 26 Sep 2019 02:11:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqxq0TMRn8NmV3spnbv5q120bDAGlKrJXFkqCymr1khWeHMv3FLL6nEcY3Zufc59Jw7N1YjB X-Received: by 2002:a17:906:1e57:: with SMTP id i23mr2125371ejj.204.1569489068372; Thu, 26 Sep 2019 02:11:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1569489068; cv=pass; d=google.com; s=arc-20160816; b=BR6l5WHmWptX9ra5p4hf8372fhlz4zmO7CDOI+FYG6/VgBSgqXzSlFqykrLwDk8kAc z2YASTeyAtVoGY4JoMt06Czk3HkqXfwvEXA3dmReOft2EC48/SR92fcoxEkhts+eRPPS gL0a1psmoeak69eFf4Ur8iikpTjd0+Vi9XVMoGu+UDTFxequCi9KcBpFrHOCaktCVD8w f5oxnXjhG23Qdyb7mN3sIaCb3yJAV7+/TYdYZVrqgJxT9fkW2lfj9Vc76X9BR5lFqctl t1snggUCkEah7deNLlEKvEcSn1RSnOXoigB0hZdA1iJ+OGM4Vm0YNr2HUgNJd1Z7Fylr GcyA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=WJHf4cOdXiiqBk6AS5aUPVrCa2I3IEU1o/S0NqZdua4=; b=ra3tqJs96FKrw6ymtZgENRnaSwglIu3c/CriguEDro11giCy6MMGPkX63TFpFML8eR ZNNUPBksBRxCjchhbDzf1l89HaT4HOoFlytVaOYxgN5E39emTCYKJnMY6TCuEMzj961q W6BQ75f7D9yLuXTRNHTfkvZzKl0z3bbEVDxaTgXbbRCMgdf69K1pZzNBqcLGr9qGkw4C G3lmNHNQ4pFKHsdyrHARFmYQDNXIF8bR9Jnlb9TBLk1rhanJw+cXATpcARpIJUkvdMfl hHhmgBwt+xrjujWxyTsEHlPJCyJoko6UwTRpUu9lod1/PLOV4NAbx/BO2stqXpGUEPY6 dLMQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=lOjdsjA8; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f14si831358edt.92.2019.09.26.02.10.44; Thu, 26 Sep 2019 02:11:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=lOjdsjA8; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2411565AbfIYDe4 (ORCPT + 99 others); Tue, 24 Sep 2019 23:34:56 -0400 Received: from mail-eopbgr30055.outbound.protection.outlook.com ([40.107.3.55]:9185 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2406366AbfIYDex (ORCPT ); Tue, 24 Sep 2019 23:34:53 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F5wemOo0R5LmM7a1sMQSY2DaWN3VH77rjBof87syT80kmHCSZ2NEer2FlBqSZLaxYjgCjP/yob/g2d/ru4c7AfaCLrSviELRQCawc+I4NcTT7hAG+MJ5Ja7D7ndXkNDM68dsuJsnEinV3AwAyvuKzYSkNcUn4hgaVT6tg0v+GBbq629rSfBVMeqozCNQfGOPHAK3BGemyLzwCdwikrqTnnWuieyg9Ikn+Ng9ZcSAY6TB0C/jjsSdEN4QQdVsHeXKAj3OlmzdGQ9rEM13P8/gbzXtRUeHfecoTzh0VOxK8EQyhgImMLMkHlFWoyFjSa42fvZXVv5PBS0JxeF4SeW8yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WJHf4cOdXiiqBk6AS5aUPVrCa2I3IEU1o/S0NqZdua4=; b=eRvzBj2uWOUMYFAWzDRQ/9th2lnJPcNzgCw1IP9T9ci5kI82G37H7YcQvtfvKiYlB6pbU7xoPanmNm9ujm/ENeyV0+IM+xc9Cg34UieSgna5qAX6UkQLHi8K+e6inXa02sZk1CGCMLoeJ2xBPLEdF+IAAeGeWQCafJcv5miyVKa3sYfHDpZUqg48KSJpATid/SklUYQ1jZl/FRZImRozEpx1KkflGREekArzGSGS5M/h4hHHI52slv48uog7WA8PNrTTGW1LfDmFHBcWtwRBs3Jl7wg5nX4x6ukwSsuDXfnaQRM4FSqr5GJP5NfV3Uofqw18fHyyaRkp6CLGUW+MbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WJHf4cOdXiiqBk6AS5aUPVrCa2I3IEU1o/S0NqZdua4=; b=lOjdsjA8x/aNzPwzlL6PVpi9XdXajN5ms4E2inK4PL2k9xOBR6LT1STITLo1Ex9nLHKl4rx7MSC/bxu4YedZWOH/oquYIQ/xgu846B7p0bXO3+VSZzArwjpS5+X96NoJScfVPLVLnR/DqktPWUKqgz4hUgvrXl9EcD9JWtM5flE= Received: from AM0PR04MB6676.eurprd04.prod.outlook.com (20.179.255.161) by AM0PR04MB6019.eurprd04.prod.outlook.com (20.179.34.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.20; Wed, 25 Sep 2019 03:34:47 +0000 Received: from AM0PR04MB6676.eurprd04.prod.outlook.com ([fe80::5c26:3c5f:17e0:8038]) by AM0PR04MB6676.eurprd04.prod.outlook.com ([fe80::5c26:3c5f:17e0:8038%7]) with mapi id 15.20.2284.023; Wed, 25 Sep 2019 03:34:47 +0000 From: Leo Li To: Biwen Li , "shawnguo@kernel.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , Ran Wang CC: "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: RE: [v3,3/3] Documentation: dt: binding: fsl: Add 'fsl,ippdexpcr-alt-addr' property Thread-Topic: [v3,3/3] Documentation: dt: binding: fsl: Add 'fsl,ippdexpcr-alt-addr' property Thread-Index: AQHVcoOnKERg3NBKWEeinvrVMNtD66c6+UIwgADABICAAADF0IAABAEAgAAAioA= Date: Wed, 25 Sep 2019 03:34:47 +0000 Message-ID: References: <20190924024548.4356-1-biwen.li@nxp.com> <20190924024548.4356-3-biwen.li@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leoyang.li@nxp.com; x-originating-ip: [136.49.234.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 244ac947-6b62-49b8-028a-08d7416950c3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:AM0PR04MB6019; x-ms-traffictypediagnostic: AM0PR04MB6019:|AM0PR04MB6019: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 01713B2841 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(396003)(346002)(39860400002)(366004)(376002)(189003)(199004)(13464003)(2906002)(33656002)(99286004)(66446008)(53546011)(66946007)(76116006)(14454004)(66476007)(2501003)(186003)(26005)(64756008)(6246003)(4326008)(86362001)(478600001)(102836004)(7696005)(6506007)(76176011)(5660300002)(81156014)(3846002)(6436002)(74316002)(6636002)(6116002)(8936002)(66556008)(486006)(229853002)(8676002)(305945005)(25786009)(55016002)(81166006)(52536014)(7736002)(256004)(9686003)(14444005)(66066001)(446003)(316002)(110136005)(54906003)(11346002)(476003)(71200400001)(71190400001)(142933001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR04MB6019;H:AM0PR04MB6676.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: NIRYLUMbmXbE6RcfcSUVEjgtQDTCjQVlkJWzmpPFuOHTTqtE4NcL3bgUJqRCIxaLXMBUdXuZkoyL05D6Nc0FWoDgMfJ7VL2Egvd8VggOl2Qn5NQygf1rwk3LvvMs82KzBUZs+Tn8vnlRZpADkTbTeF9w1xR4jmcyYW+Nc8sKk1ZUvQsSJNkJzRtoaC35oPV/nqq6uaS44jV5YO3VnBFjJGMUyWv4UpKETb/BvphduxehV1t1Z7efZWcTJYVPdtw3jRa27e4Gqv6FPTucP8Zmuz8p7IUI+iLlfxLwWG8jMvgt18sHIc12UvKn80xdXfE5veVO/nsWgDPucSt/QSQ/RR8m5wsmGRN7C05ybJL9cY82bZIu9z0D1Or9Kft7ydCmFfWLVgN6gwjh3ilW9pnMaJ1KNsgroHTs0b0vl/Ienic= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 244ac947-6b62-49b8-028a-08d7416950c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Sep 2019 03:34:47.7354 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B/3QpLyK63NZ7vS97FLW0OYAO1UBAD5oa5+fzVWUs0RdnDNi0QFUc6Oz6nHrodtJjAiIcoDZVqPXtSlbM9oWZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6019 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Biwen Li > Sent: Tuesday, September 24, 2019 10:30 PM > To: Leo Li ; shawnguo@kernel.org; > robh+dt@kernel.org; mark.rutland@arm.com; Ran Wang > > Cc: linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; devicetree@vger.kernel.org > Subject: RE: [v3,3/3] Documentation: dt: binding: fsl: Add 'fsl,ippdexpcr= -alt- > addr' property >=20 > > > > > > > > > > The 'fsl,ippdexpcr-alt-addr' property is used to handle an > > > > > errata > > > > > A-008646 on LS1021A > > > > > > > > > > Signed-off-by: Biwen Li > > > > > --- > > > > > Change in v3: > > > > > - rename property name > > > > > fsl,rcpm-scfg -> fsl,ippdexpcr-alt-addr > > > > > > > > > > Change in v2: > > > > > - update desc of the property 'fsl,rcpm-scfg' > > > > > > > > > > Documentation/devicetree/bindings/soc/fsl/rcpm.txt | 14 > > > > > ++++++++++++++ > > > > > 1 file changed, 14 insertions(+) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > > > > > b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > > > > > index 5a33619d881d..157dcf6da17c 100644 > > > > > --- a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > > > > > +++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > > > > > @@ -34,6 +34,11 @@ Chassis Version Example Chips > > > > > Optional properties: > > > > > - little-endian : RCPM register block is Little Endian. Without= it RCPM > > > > > will be Big Endian (default case). > > > > > + - fsl,ippdexpcr-alt-addr : Must add the property for SoC > > > > > + LS1021A, > > > > > > > > You probably should mention this is related to a hardware issue on > > > > LS1021a and only needed on LS1021a. > > > Okay, got it, thanks, I will add this in v4. > > > > > > > > > + Must include n + 1 entries (n =3D #fsl,rcpm-wakeup-cells, suc= h as: > > > > > + #fsl,rcpm-wakeup-cells equal to 2, then must include 2 + 1 en= tries). > > > > > > > > #fsl,rcpm-wakeup-cells is the number of IPPDEXPCR registers on an S= oC. > > > > However you are defining an offset to scfg registers here. Why > > > > these two are related? The length here should actually be related > > > > to the #address-cells of the soc/. But since this is only needed > > > > for LS1021, you can > > > just make it 3. > > > I need set the value of IPPDEXPCR resgiters from ftm_alarm0 device > > > node(fsl,rcpm-wakeup =3D <&rcpm 0x0 0x20000000>; > > > 0x0 is a value for IPPDEXPCR0, 0x20000000 is a value for IPPDEXPCR1). > > > But because of the hardware issue on LS1021A, I need store the value > > > of IPPDEXPCR registers to an alt address. So I defining an offset to > > > scfg registers, then RCPM driver get an abosolute address from > > > offset, RCPM driver write the value of IPPDEXPCR registers to these > > > abosolute addresses(backup the value of IPPDEXPCR registers). > > > > I understand what you are trying to do. The problem is that the new > > fsl,ippdexpcr-alt-addr property contains a phandle and an offset. The > > size of it shouldn't be related to #fsl,rcpm-wakeup-cells. > You maybe like this: fsl,ippdexpcr-alt-addr =3D <&scfg 0x51c>;/* > SCFG_SPARECR8 */ No. The #address-cell for the soc/ is 2, so the offset to scfg should be 0= x0 0x51c. The total size should be 3, but it shouldn't be coming from #fsl= ,rcpm-wakeup-cells like you mentioned in the binding. > > > > > > > > > > > + The first entry must be a link to the SCFG device node. > > > > > + The non-first entry must be offset of registers of SCFG. > > > > > > > > > > Example: > > > > > The RCPM node for T4240: > > > > > @@ -43,6 +48,15 @@ The RCPM node for T4240: > > > > > #fsl,rcpm-wakeup-cells =3D <2>; > > > > > }; > > > > > > > > > > +The RCPM node for LS1021A: > > > > > + rcpm: rcpm@1ee2140 { > > > > > + compatible =3D "fsl,ls1021a-rcpm", "fsl,qoriq-rcpm- > 2.1+"; > > > > > + reg =3D <0x0 0x1ee2140 0x0 0x8>; > > > > > + #fsl,rcpm-wakeup-cells =3D <2>; > > > > > + fsl,ippdexpcr-alt-addr =3D <&scfg 0x0 0x51c>; /* > > > > > SCFG_SPARECR8 */ > > > > > + }; > > > > > + > > > > > + > > > > > * Freescale RCPM Wakeup Source Device Tree Bindings > > > > > ------------------------------------------- > > > > > Required fsl,rcpm-wakeup property should be added to a device > > > > > node if the device > > > > > -- > > > > > 2.17.1