Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] virtio_mmio: remove redundant dev_err message
To:     Ding Xiang <dingxiang@cmss.chinamobile.com>, mst@redhat.com
Cc:     virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
References: <1569309666-1437-1-git-send-email-dingxiang@cmss.chinamobile.com>
From:   Jason Wang <jasowang@redhat.com>
Message-ID: <ccce7b48-d8a8-bbf8-7192-cefa77f51993@redhat.com>
Date:   Wed, 25 Sep 2019 11:49:17 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <1569309666-1437-1-git-send-email-dingxiang@cmss.chinamobile.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2019/9/24 下午3:21, Ding Xiang wrote:
> platform_get_irq already contains error message,


Is this message contained in all possible error path? If not, it's 
probably better to keep it as is.

Thanks


> so remove
> the redundant dev_err message
>
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
> ---
>   drivers/virtio/virtio_mmio.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
> index e09edb5..c4b9f25 100644
> --- a/drivers/virtio/virtio_mmio.c
> +++ b/drivers/virtio/virtio_mmio.c
> @@ -466,10 +466,8 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
>   	int irq = platform_get_irq(vm_dev->pdev, 0);
>   	int i, err, queue_idx = 0;
>   
> -	if (irq < 0) {
> -		dev_err(&vdev->dev, "Cannot get IRQ resource\n");
> +	if (irq < 0)
>   		return irq;
> -	}
>   
>   	err = request_irq(irq, vm_interrupt, IRQF_SHARED,
>   			dev_name(&vdev->dev), vm_dev);