Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1802816ybn; Thu, 26 Sep 2019 02:25:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqzqc2fiez7t64EJN6b2pKHN+dbE6WqK09uSf6DRbNWZ1zvddQvXWiw4PNI6sM7IJ8jnRkFe X-Received: by 2002:a05:6402:1549:: with SMTP id p9mr2423210edx.221.1569489943249; Thu, 26 Sep 2019 02:25:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569489943; cv=none; d=google.com; s=arc-20160816; b=lB//eBrFvh/WJXGnCWmXqPVadstI3YmvctAxgotZDhW0UFiernxxc12x3A2YRC36l/ TFLCmoEqYBLW/BbIGd6ONtzV/yfnz4NPjiz3w9puqNXyKpvMy4hYb7Tm1XSCeGQIn4Zr TzTb2N4P6kfJd1ZRiba/4AUB4tq0wec09u1d1iWYpl9Ca8i5TmiU7g9npc6u89pfbpED x1oU3qFnLV+A6cwvn/mzIXyqiGB/XpnvyuzIDGBBmCFCQmckQZ/BM8Sacip78R66jCEJ CYU8Mqdhy35au/i86ft18alVkgzdzWj9RwzNq+wF34j9INBaAxbY5vMeGgZkv5gC2wea oTlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=ALfzM0tirTtMAj9pK6xGt/ILwW7DjDr+MUD+nHnzYk0=; b=JrNkLePvWvsAWj9Io4ZFNwZsi6TqM3NC0NoSUSzoXSEfaEXjwza9tMUD0nXk4Srjtz kFcHsv7OPCYV4Ot8nF+sXwK64ReFScC7+bPmXwRWjcNHH5qQ4D0PVA/uURK7B5ay8ZPM 0iMNA7pSDeotwV0dHq13phAweuLFfZZezMPf26C9sht7mJmJQR5U6OmOTdsQtakew5le e57w/xxLACL7oma+Bl8SMVqt2wGSRhbdK0QS38S9aMcc6a9wT68cZltK5rAQft2IkXHv Jq+9F94V24RQ61F3uLC3ctBKVjwa+esxGIZv5/EXMom64adSjo1cFWF4WTnmqnW2DEV8 JSGQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i5si980309edj.107.2019.09.26.02.25.20; Thu, 26 Sep 2019 02:25:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388438AbfIYJMJ (ORCPT + 99 others); Wed, 25 Sep 2019 05:12:09 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:47167 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387927AbfIYJMH (ORCPT ); Wed, 25 Sep 2019 05:12:07 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 46dXPf4fyyz1rSBb; Wed, 25 Sep 2019 11:12:06 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 46dXPf4DQfz1qqkL; Wed, 25 Sep 2019 11:12:06 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id FXGkXWStI10e; Wed, 25 Sep 2019 11:12:04 +0200 (CEST) X-Auth-Info: o4u4qXuuFLlQh1zBWTsqWbrOIzRBQ+Y0XzcSt5tgRFY= Received: from localhost.localdomain (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 25 Sep 2019 11:12:04 +0200 (CEST) From: Lukasz Majewski To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, krzk@kernel.org, Lukasz Majewski Subject: [PATCH v2 2/2] spi: Introduce dspi_slave_abort() function for NXP's dspi SPI driver Date: Wed, 25 Sep 2019 11:11:43 +0200 Message-Id: <20190925091143.15468-3-lukma@denx.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190925091143.15468-1-lukma@denx.de> References: <20190924110547.14770-1-lukma@denx.de> <20190925091143.15468-1-lukma@denx.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This change provides the dspi_slave_abort() function, which is a callback for slave_abort() method of SPI controller generic driver. As in the SPI slave mode the transmission is driven by master, any distortion may cause the slave to enter undefined internal state. To avoid this problem the dspi_slave_abort() terminates all pending and ongoing DMA transactions (with sync) and clears internal FIFOs. Signed-off-by: Lukasz Majewski --- Changes for v2: - None --- drivers/spi/spi-fsl-dspi.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index bec758e978fb..2c0f211eed87 100644 --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c @@ -1006,6 +1006,25 @@ static void dspi_init(struct fsl_dspi *dspi) SPI_CTARE_FMSZE(0) | SPI_CTARE_DTCP(1)); } +static int dspi_slave_abort(struct spi_master *master) +{ + struct fsl_dspi *dspi = spi_master_get_devdata(master); + + /* + * Terminate all pending DMA transactions for the SPI working + * in SLAVE mode. + */ + dmaengine_terminate_sync(dspi->dma->chan_rx); + dmaengine_terminate_sync(dspi->dma->chan_tx); + + /* Clear the internal DSPI RX and TX FIFO buffers */ + regmap_update_bits(dspi->regmap, SPI_MCR, + SPI_MCR_CLR_TXF | SPI_MCR_CLR_RXF, + SPI_MCR_CLR_TXF | SPI_MCR_CLR_RXF); + + return 0; +} + static int dspi_probe(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; @@ -1030,6 +1049,7 @@ static int dspi_probe(struct platform_device *pdev) ctlr->dev.of_node = pdev->dev.of_node; ctlr->cleanup = dspi_cleanup; + ctlr->slave_abort = dspi_slave_abort; ctlr->mode_bits = SPI_CPOL | SPI_CPHA | SPI_LSB_FIRST; pdata = dev_get_platdata(&pdev->dev); -- 2.20.1