Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1804701ybn; Thu, 26 Sep 2019 02:27:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqxFGdV1yut3hqoG0WSITvuZ6c1PhGBNXj8zZoDYXDbTA2OHnntKbW8NSVMcuqz0KVoEBkmo X-Received: by 2002:a17:906:d0d2:: with SMTP id bq18mr2145500ejb.233.1569490064848; Thu, 26 Sep 2019 02:27:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569490064; cv=none; d=google.com; s=arc-20160816; b=OW6Zlyucnco4cZV24bafxUyseC19X0S4PxATYoSLuBayICmI/7H9SfKv5Hdc8jRdXc 29o5WP13Loq5Ia/qoh6UVtPX5Lu7RtYtS5aX7Tm86CZBix4ta6i0C/Z2EYaNGtO8SnEV z/1hNd07N31MptNziuVpn89rS/cgzKsRbiD+nxarnPDFgXlonP+4ZHB/uI0dloTcG3NZ 60JeCaqI3CEU8tmwU7ixYFaB5LmV/3aK3o/1fKH3070OYsUEUnCcXRY82ypmYXpFD3Bu n/+UEkBrn31GY2F6/7dxAApuhRquG5xKOBzTAQrRD3aT4o0Ry0vLHsRYIle2B1Dm4EU6 WK7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=ZZGk1175G8uwjvxdK1U1C4fRiS6VV+Ha9+4WTc5Wkb8=; b=im+l4mMLVTD5II+IklXYi/6aJkfK+hks+OSOuJPSgubnCAEDB0zsUKybbL9xjW2qXh qk/C6iDV9EcJgjIlqGA3qif7ri3TS6Z5s02iX+rNWDD7wER7mrEHyYryokzGxt4e8SZz mu/hYqDo9A7VjoVBzLW+mfqwC+5m8+TFbRDZKRTHux2L+IlXat7w2MrduDMqkSbyPMdV z/yuzUlaxVtwnrlEF0q1vftasik+Vo8tjkQ6wDg9fgEhIULOp0oSH4FIlDE8a4zvz0x6 p8FDAGWPg8adWQuqrZFALAE/jwsG1rf6TqMDlkvi+ONCAIi2e/M/+QNcX5OD6CCHqRmk 7PNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q10si964126eda.293.2019.09.26.02.27.21; Thu, 26 Sep 2019 02:27:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389974AbfIYKdx (ORCPT + 99 others); Wed, 25 Sep 2019 06:33:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33166 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389655AbfIYKdx (ORCPT ); Wed, 25 Sep 2019 06:33:53 -0400 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A07EF4FCC7 for ; Wed, 25 Sep 2019 10:33:52 +0000 (UTC) Received: by mail-qt1-f197.google.com with SMTP id x25so5417831qtq.2 for ; Wed, 25 Sep 2019 03:33:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZZGk1175G8uwjvxdK1U1C4fRiS6VV+Ha9+4WTc5Wkb8=; b=dvG5VfrUgpiHFfaM3c2/tfx+THJeK/4wtKXeYdmaAlZcqou7tnNRCi+CIo5TRnRktm YPCGo4fodCBli0toR1QrTlloCta1q0zfJPqmrVfK8Mv+uhPGD7MeV3Q8MvBT9xQp2VKD +PgOoNIxe87SbXBLS7v+gn38HndmNPTB0gMYYMqwO5dubI7fSRZvEzX3iRnoPcz9FKZh +3oo6wnO9QGYvMUFHXr4ajRIRAFi/o4/rU67cb5zwJ0+uruCiykq8n8m5weW3J/ZKgm7 3MeH14rOvbpQptUEf/q3q3cgwlJhNEACrRDKCVr2Y08XcYyYo01kZdY5iWHu+iN9iQ67 Z3HA== X-Gm-Message-State: APjAAAUH+Mh9P2Bt2KgTnM68ljbk2gwr+uGfVXZjzrrZQiS422P7JwxF 7NBbJisBFBpkEkqApf0PALEUxiJ2dIc4ioHea5f1I/YxIQ78MLpYLoXI3a6tiGC3XdbBxJQpKeh rkJF9SIe/07UvBZdwBlyuhMtX X-Received: by 2002:ac8:16d9:: with SMTP id y25mr7908735qtk.72.1569407632039; Wed, 25 Sep 2019 03:33:52 -0700 (PDT) X-Received: by 2002:ac8:16d9:: with SMTP id y25mr7908708qtk.72.1569407631903; Wed, 25 Sep 2019 03:33:51 -0700 (PDT) Received: from redhat.com (bzq-79-176-40-226.red.bezeqint.net. [79.176.40.226]) by smtp.gmail.com with ESMTPSA id x59sm2645454qte.20.2019.09.25.03.33.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2019 03:33:51 -0700 (PDT) Date: Wed, 25 Sep 2019 06:33:43 -0400 From: "Michael S. Tsirkin" To: Matt Cover Cc: davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, Jason Wang , Eric Dumazet , Stanislav Fomichev , Matthew Cover , mail@timurcelik.de, pabeni@redhat.com, Nicolas Dichtel , wangli39@baidu.com, lifei.shirley@bytedance.com, tglx@linutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH net-next] tuntap: Fallback to automq on TUNSETSTEERINGEBPF prog negative return Message-ID: <20190925063142-mutt-send-email-mst@kernel.org> References: <20190920185843.4096-1-matthew.cover@stackpath.com> <20190922080326-mutt-send-email-mst@kernel.org> <20190922162546-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 22, 2019 at 03:46:19PM -0700, Matt Cover wrote: > Unless of course we can simply state via > documentation that any negative return > for which a define doesn't exist is > undefined behavior. In which case, > there is no old vs new behavior and > no need for an ioctl. Simply the > understanding provided by the > documentation. Unfortunately this isn't sufficient: software can easily return a wrong value by mistake, and become dependent on an undefined behaviour. -- MST