Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 25 Sep 2019 13:38:54 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To:     Jerry Snitselaar <jsnitsel@redhat.com>
Cc:     linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-integrity@vger.kernel.org,
        Matthew Garrett <mjg59@google.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [RFC PATCH] tpm: only set efi_tpm_final_log_size after
 successful event log parsing
Message-ID: <20190925103854.GC6256@linux.intel.com>
References: <20190918191626.5741-1-jsnitsel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190918191626.5741-1-jsnitsel@redhat.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Sep 18, 2019 at 12:16:26PM -0700, Jerry Snitselaar wrote:
> +	if (tbl_size < 0) {
> +		pr_err("Failed to parse event in TPM Final Event log\n");

FW_BUG?

> +		goto calc_out;
> +	}
> +
>  	memblock_reserve((unsigned long)final_tbl,
>  			 tbl_size + sizeof(*final_tbl));
> -	early_memunmap(final_tbl, sizeof(*final_tbl));
>  	efi_tpm_final_log_size = tbl_size;
>  
> +calc_out:
> +	early_memunmap(final_tbl, sizeof(*final_tbl));

out_calc

>  out:
>  	early_memunmap(log_tbl, sizeof(*log_tbl));
>  	return ret;
> -- 
> 2.23.0
> 

/Jarkko