Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <e6d097c176d4a4bb4fe5664fe4199f3025d22182.camel@perches.com>
Subject: Re: [PATCH] toplevel: Move ipc/ to kernel/ipc/: don't check the ipc
 dir
From:   Joe Perches <joe@perches.com>
To:     Yunfeng Ye <yeyunfeng@huawei.com>, apw@canonical.com,
        mingo@kernel.org, Andrew Morton <akpm@linux-foundation.org>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date:   Wed, 25 Sep 2019 09:32:33 -0700
In-Reply-To: <04acff22-430b-9ed7-f700-b644c0632cdd@huawei.com>
References: <04acff22-430b-9ed7-f700-b644c0632cdd@huawei.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.32.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2019-09-25 at 20:37 +0800, Yunfeng Ye wrote:
> After the commit 76128326f97c ("toplevel: Move ipc/ to kernel/ipc/: move
> the files"), we met some error messages:
> 
>   ./scripts/checkpatch.pl:
>   "Must be run from the top-level dir. of a kernel tree"
> 
>   ./scripts/get_maintainer.pl:
>   "The current directory does not appear to be a linux kernel source tree.
> 
> Don't check the ipc dir in checkpatch.pl and get_maintainer.pl.

Thanks.

Maybe the commit subject could use "scripts:"
or something similar and not "toplevel:".

Trivially, it one day it'd be good to use the
same routine and output message too.

> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
> ---
>  scripts/checkpatch.pl     | 2 +-
>  scripts/get_maintainer.pl | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 93a7edf..6117d0e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1097,7 +1097,7 @@ sub top_of_kernel_tree {
>  	my @tree_check = (
>  		"COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
>  		"README", "Documentation", "arch", "include", "drivers",
> -		"fs", "init", "ipc", "kernel", "lib", "scripts",
> +		"fs", "init", "kernel", "lib", "scripts",
>  	);
> 
>  	foreach my $check (@tree_check) {
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 5ef5921..2e42aeb 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -1109,7 +1109,6 @@ sub top_of_kernel_tree {
>  	&& (-d "${lk_path}drivers")
>  	&& (-d "${lk_path}fs")
>  	&& (-d "${lk_path}init")
> -	&& (-d "${lk_path}ipc")
>  	&& (-d "${lk_path}kernel")
>  	&& (-d "${lk_path}lib")
>  	&& (-d "${lk_path}scripts")) {