Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1821622ybn; Thu, 26 Sep 2019 02:44:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqyBUJTDPR3INsCh3jSBjn2p9gdb+xfmJ9FTBOfZ2odijRyF9oFBGYzhtDlcICrHeklyftmU X-Received: by 2002:a17:906:b6d5:: with SMTP id ec21mr2113659ejb.33.1569491095717; Thu, 26 Sep 2019 02:44:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569491095; cv=none; d=google.com; s=arc-20160816; b=JrpUmAYcZy0HfG3nBT1mf9V3Ewmdev+k5XnexWbLEoHKEq++M0shdNMp667SKcj/Lv eF+aN06HUkpoZwWq6TgUUWMXO4yqAbg9Fl+8jM3T9f7Vz+ZdhL3WgEpZKWTTzl75GaQm 5rYni/SbtTrd1Uv/rAH7BJiirIFnWRUSHLyghVlZ06l1f70bh3QEd5PbqDOiYDhuqYMA mDGUjdGMT5CCY+ZsFH45sFqmaURto7NF95JdIA0fpLjPXmPE7Us2r3QBdGTTIjxcXgEj wnjlLbTd6slweV/IM2h+pTWDk0hh6/JVeYYiS6H/5pw3Wid1YbIldz9Ua+BdjEfWcqSo G1SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=DPN5lOgMk4ewWDxp79xsQgrrgk+HRYTm042wneV3BNw=; b=DnVAyDBcUbdDJFnPUlbFP9bT1FH5LZbd90UEZA6T8s8l2OvsJco6Dl8ZhiPLEYjGJ8 IEc1h1iqyo6mimVaRBBXJg5/10XYen8LaccUvXIHaEQUhO9n22acwHKznxsYISUynpPI j+nmyAl4Thkj8HeGRtgZ1vL/21nn7PyYUmjYN7EWxreO1qW/DDHl8XrGwgyVRbrdqw7G Kuhczp2/4N/Lgy3wu6CrxmE8BFCJxpXhRJ79iSg0BBCjx5o9XcdcubleR9/QQ4AsfRF0 FDIVf1IdIofYMsriOgWVJWiniYH2TlEQvYZ/P4xnUOKb2JJb6fR1vJ22WP79y+o84fMH QCLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p14si780947ejn.192.2019.09.26.02.44.32; Thu, 26 Sep 2019 02:44:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391625AbfIYPp0 (ORCPT + 99 others); Wed, 25 Sep 2019 11:45:26 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:36143 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732686AbfIYPpZ (ORCPT ); Wed, 25 Sep 2019 11:45:25 -0400 Received: by mail-pg1-f194.google.com with SMTP id t14so1964pgs.3; Wed, 25 Sep 2019 08:45:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DPN5lOgMk4ewWDxp79xsQgrrgk+HRYTm042wneV3BNw=; b=ZNhjTF1warj6FxoYw8HbBIqcs3/nvRe4FMfAB1pUTpEvN/yjVwtpVeV0yMytwHQkQU ffKFPAgvflpwVkqnNWHvZiuJaxP+qw0Kk/80T4+q2ny68k1MEns5bjNkV/OwdVCmAtJa Zf3ekP9+l/Qs/EsrnqmPSHOcY+xa2bDOjtGzzeF7pXhCQgHAOTIq7Hi0EM2bCoqWsPXz 75l+pk0m5D0K4HizZNp75kfllQFOlq/ScX9OWHzf5tKQw4X8dsCEaa579QwvzLA5Iw4Z vLG+e5xZSBJ3CgeEjYYxXWMJopHiSANBwCS7f1oWZ1uaCBT3/pyPUTfXoWED/bXTdJvF SRNA== X-Gm-Message-State: APjAAAV1o5GFM42Roi06qOznB1PEGKKmFeEhdkNvhLl+Bffat1rhRS+s X0WvdM0lHOCqwE7JX3JIXFfDjtMF X-Received: by 2002:a63:1749:: with SMTP id 9mr9114175pgx.387.1569426325049; Wed, 25 Sep 2019 08:45:25 -0700 (PDT) Received: from desktop-bart.svl.corp.google.com ([2620:15c:2cd:202:4308:52a3:24b6:2c60]) by smtp.gmail.com with ESMTPSA id j128sm9996393pfg.51.2019.09.25.08.45.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Sep 2019 08:45:24 -0700 (PDT) Subject: Re: [PATCH] scsi: core: Log SCSI command age with errors To: "Milan P. Gandhi" , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Cc: jejb@linux.ibm.com, martin.petersen@oracle.com References: <20190923060122.GA9603@machine1> From: Bart Van Assche Message-ID: Date: Wed, 25 Sep 2019 08:45:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190923060122.GA9603@machine1> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/22/19 11:01 PM, Milan P. Gandhi wrote: > + off += scnprintf(logbuf + off, logbuf_len - off, > + "cmd-age=%lus", cmd_age); Have you considered to change cmd-age into cmd_age? I'm afraid otherwise someone might interpret the hyphen as a subtraction sign... Thanks, Bart.