Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1822064ybn; Thu, 26 Sep 2019 02:45:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqxyYPMbdcmJhRBefTm2WyuzZ/Q6PGe5oREb3ATtbt8DIpWE8eZyucZNC3PkyvcCKp/szzZ7 X-Received: by 2002:a05:6402:1858:: with SMTP id v24mr2526586edy.130.1569491122698; Thu, 26 Sep 2019 02:45:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569491122; cv=none; d=google.com; s=arc-20160816; b=Hj/gJvz0laJG1VQQIzPUCLHCljNE3rCnAZe2WOmZdzeoYDYAHKRx1Bp5cTHPo6yPRa 05ReJAx6AOoxZ+YT51dDZj8bdkfRqlmKN3DTOAX/N00xk/6TeUfeelFgDRKpQArdODHk w+osqQ6s5U0/kKqk4WYHIFU2oFUCZbSuBq2scKnU7Tkx01P4Idz/eNFDMst1didVw8fo CusGp+6Guv70w3U7x9hn5BkNDDEKg6GFXduTG1JxMwnuMycfbBNrL27a0O1ch97HG22B nPk0yRIDWEa3XMhHCUxHuiVKcV3bo0Sisby4sJgaHwIEv8UD86ckl23omn9DWrYJ/23c 7F7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=Za0z0/d+OF97gXxJBqW0ve0g59BfVusCf1TvlBqBGsE=; b=rOlLqTMvs6Swyb3383O0FHmvBQXdX1SG390WastV90KVAreBDJwWsa9P8NaBuOu7F1 Fdpe5Ch8DC9SjIwfTXahzW0NaMaz0KKIsyHexussU0DhBFIOUr+Ylg/7P/zskGcN9LJF ReksnyaQoKwdGG7qFD2eDkJZCODX+WVR843jjRG7LDqKQH4zZUyVyJeodz4qzGJeK972 JsIXN+R6TloEYtIImT8iUjTi+vLvXU2aLr1WJooK5dkiw3DgHSyFfnek3w269YO+m6Jz plyQemloEDNWO2E4vk8pi2rW6tMX97HK5UQi+/gedonYZNC31bkAbKPpEq2YH1mvAlA/ OFmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xO44PUuo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b12si1067859edk.16.2019.09.26.02.44.59; Thu, 26 Sep 2019 02:45:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xO44PUuo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391929AbfIYQmk (ORCPT + 99 others); Wed, 25 Sep 2019 12:42:40 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:38307 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388566AbfIYQmk (ORCPT ); Wed, 25 Sep 2019 12:42:40 -0400 Received: by mail-pg1-f196.google.com with SMTP id x10so111141pgi.5 for ; Wed, 25 Sep 2019 09:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Za0z0/d+OF97gXxJBqW0ve0g59BfVusCf1TvlBqBGsE=; b=xO44PUuouNg4khLR1gDFRhyQqT912trQ0902JL/Vzy9vx824oUB91zxNRXRRHDbKC5 sjpgOhOGrjLY/Kf4OURBzzq6ID0y7CFF9sIMYBgCIVCYFeW6gwK45salaGLIJTjn+dYc PXKiRNaFdTyDjld/WwA2VUGXFFNmxNq6lStefWR70InMGafU2mKnQzPqVe3bkghDg5Ya XKXhz/TwHSiSwmGS6J8CDIoTmTtgGNq3kHE1LWxWSNIRIuHwwHeu+2pJExeNz/yBhdkB gNmi0Lorj1HFXFkTchuj+LhJFCRgmdfN1ycmCFzDuz1lXQiRle0sq1371yYZQpx7+sQi InHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Za0z0/d+OF97gXxJBqW0ve0g59BfVusCf1TvlBqBGsE=; b=GB+DELwaztQqqtULkAH5+rQL2Q8phbRiniyauAgVC7763k63eBfC3te4Yx3KVgPgmF sHI691rDLLdtOz9QxK13lHooDMQ2uIICIAnPlMl6bKuQk+OmnMB8vFsghztk2RnbrAcl hSb1xn0/Wm8p/TixeE0uINi6Dm21/df2kS6aevTaAPCaNAS4ogXs5XB9qymGQnGitBVq KeIdWqxY42/d/9toJNmGMwU8tJSD38MxHdkgTsiuQU3rFRErbTv+nOCkkgJktXWfiWS3 pRtLSScFvnSD/K3YKm9KVvakfOP5GR7flw6D9Hy0E9GWGPfpEvT9T4x7O9hGMT+snXu7 JqGQ== X-Gm-Message-State: APjAAAX9dRgi6oP1B/dkgT3GD7lMkZfASiflSqCj0Gb6CCeKyJytNjwd gMv2D0+1jK/c8aqR43PqBVDNBw== X-Received: by 2002:a17:90a:8c14:: with SMTP id a20mr7722011pjo.45.1569429758906; Wed, 25 Sep 2019 09:42:38 -0700 (PDT) Received: from [172.20.32.102] ([12.206.46.62]) by smtp.googlemail.com with ESMTPSA id f89sm3881236pje.20.2019.09.25.09.42.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Sep 2019 09:42:37 -0700 (PDT) Subject: Re: [PATCH] clocksource: mediatek: fix error handling To: Fabien Parent , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: tglx@linutronix.de, matthias.bgg@gmail.com References: <20190919191315.25190-1-fparent@baylibre.com> From: Daniel Lezcano Openpgp: preference=signencrypt Autocrypt: addr=daniel.lezcano@linaro.org; prefer-encrypt=mutual; keydata= mQINBFv/yykBEADDdW8RZu7iZILSf3zxq5y8YdaeyZjI/MaqgnvG/c3WjFaunoTMspeusiFE sXvtg3ehTOoyD0oFjKkHaia1Zpa1m/gnNdT/WvTveLfGA1gH+yGes2Sr53Ht8hWYZFYMZc8V 2pbSKh8wepq4g8r5YI1XUy9YbcTdj5mVrTklyGWA49NOeJz2QbfytMT3DJmk40LqwK6CCSU0 9Ed8n0a+vevmQoRZJEd3Y1qXn2XHys0F6OHCC+VLENqNNZXdZE9E+b3FFW0lk49oLTzLRNIq 0wHeR1H54RffhLQAor2+4kSSu8mW5qB0n5Eb/zXJZZ/bRiXmT8kNg85UdYhvf03ZAsp3qxcr xMfMsC7m3+ADOtW90rNNLZnRvjhsYNrGIKH8Ub0UKXFXibHbafSuq7RqyRQzt01Ud8CAtq+w P9EftUysLtovGpLSpGDO5zQ++4ZGVygdYFr318aGDqCljKAKZ9hYgRimPBToDedho1S1uE6F 6YiBFnI3ry9+/KUnEP6L8Sfezwy7fp2JUNkUr41QF76nz43tl7oersrLxHzj2dYfWUAZWXva wW4IKF5sOPFMMgxoOJovSWqwh1b7hqI+nDlD3mmVMd20VyE9W7AgTIsvDxWUnMPvww5iExlY eIC0Wj9K4UqSYBOHcUPrVOKTcsBVPQA6SAMJlt82/v5l4J0pSQARAQABtCpEYW5pZWwgTGV6 Y2FubyA8ZGFuaWVsLmxlemNhbm9AbGluYXJvLm9yZz6JAlcEEwEIAEECGwEFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4ACGQEWIQQk1ibyU76eh+bOW/SP9LjScWdVJwUCXAkeagUJDRnjhwAK CRCP9LjScWdVJ+vYEACStDg7is2JdE7xz1PFu7jnrlOzoITfw05BurgJMqlvoiFYt9tEeUMl zdU2+r0cevsmepqSUVuUvXztN8HA/Ep2vccmWnCXzlE56X1AK7PRRdaQd1SK/eVsJVaKbQTr ii0wjbs6AU1uo0LdLINLjwwItnQ83/ttbf1LheyN8yknlch7jn6H6J2A/ORZECTfJbG4ecVr 7AEm4A/G5nyPO4BG7dMKtjQ+crl/pSSuxV+JTDuoEWUO+YOClg6azjv8Onm0cQ46x9JRtahw YmXdIXD6NsJHmMG9bKmVI0I7o5Q4XL52X6QxkeMi8+VhvqXXIkIZeizZe5XLTYUvFHLdexzX Xze0LwLpmMObFLifjziJQsLP2lWwOfg6ZiH8z8eQJFB8bYTSMqmfTulB61YO0mhd676q17Y7 Z7u3md3CLH7rh61wU1g7FcLm9p5tXXWWaAud9Aa2kne2O3sirO0+JhsKbItz3d9yXuWgv6w3 heOIF0b91JyrY6tjz42hvyjxtHywRr4cdAEQa2S7HeQkw48BQOG6PqQ9d3FYU34pt3WFJ19V A5qqAiEjqc4N0uPkC79W32yLGdyg0EEe8v0Uhs3CxM9euGg37kr5fujMm+akMtR1ENITo+UI fgsxdwjBD5lNb/UGodU4QvPipB/xx4zz7pS5+2jGimfLeoe7mgGJxrkBDQRb/8z6AQgAvSkg 5w7dVCSbpP6nXc+i8OBz59aq8kuL3YpxT9RXE/y45IFUVuSc2kuUj683rEEgyD7XCf4QKzOw +XgnJcKFQiACpYAowhF/XNkMPQFspPNM1ChnIL5KWJdTp0DhW+WBeCnyCQ2pzeCzQlS/qfs3 dMLzzm9qCDrrDh/aEegMMZFO+reIgPZnInAcbHj3xUhz8p2dkExRMTnLry8XXkiMu9WpchHy XXWYxXbMnHkSRuT00lUfZAkYpMP7La2UudC/Uw9WqGuAQzTqhvE1kSQe0e11Uc+PqceLRHA2 bq/wz0cGriUrcCrnkzRmzYLoGXQHqRuZazMZn2/pSIMZdDxLbwARAQABiQI2BBgBCAAgFiEE JNYm8lO+nofmzlv0j/S40nFnVScFAlv/zPoCGwwACgkQj/S40nFnVSf4OhAAhWJPjgUu6VfS mV53AUGIyqpOynPvSaMoGJzhNsDeNUDfV5dEZN8K4qjuz2CTNvGIyt4DE/IJbtasvi5dW4wW Fl85bF6xeLM0qpCaZtXAsU5gzp3uT7ut++nTPYW+CpfYIlIpyOIzVAmw7rZbfgsId2Lj7g1w QCjvGHw19mq85/wiEiZZNHeJQ3GuAr/uMoiaRBnf6wVcdpUTFMXlkE8/tYHPWbW0YKcKFwJ3 uIsNxZUe6coNzYnL0d9GK2fkDoqKfKbFjNhW9TygfeL2Qhk949jMGQudFS3zlwvN9wwVaC0i KC/D303DiTnB0WFPT8CltMAZSbQ1WEWfwqxhY26di3k9pj+X3BfOmDL9GBlnRTSgwjqjqzpG VZsWouuTfXd9ZPPzvYdUBrlTKgojk1C8v4fhSqb+ard+bZcwNp8Tzl/EI9ygw6lYEATGCUYI Wco+fjehCgG1FWvWavMU+jLNs8/8uwj1u+BtRpWFj4ug/VaDDIuiApKPwl1Ge+zoC7TLMtyb c00W5/8EckjmNgLDIINEsOsidMH61ZOlwDKCxo2lbV+Ij078KHBIY76zuHlwonEQaHLCAdqm WiI95pYZNruAJEqZCpvXDdClmBVMZRDRePzSljCvoHxn7ArEt3F14mabn2RRq/hqB8IhC6ny xAEPQIZaxxginIFYEziOjR65AQ0EW//NCAEIALcJqSmQdkt04vIBD12dryF6WcVWYvVwhspt RlZbZ/NZ6nzarzEYPFcXaYOZCOCv+Xtm6hB8fh5XHd7Y8CWuZNDVp3ozuqwTkzQuux/aVdNb Fe4VNeKGN2FK1aNlguAXJNCDNRCpWgRHuU3rWwGUMgentJogARvxfex2/RV/5mzYG/N1DJKt F7g1zEcQD3JtK6WOwZXd+NDyke3tdG7vsNRFjMDkV4046bOOh1BKbWYu8nL3UtWBxhWKx3Pu 1VOBUVwL2MJKW6umk+WqUNgYc2bjelgcTSdz4A6ZhJxstUO4IUfjvYRjoqle+dQcx1u+mmCn 8EdKJlbAoR4NUFZy7WUAEQEAAYkDbAQYAQgAIBYhBCTWJvJTvp6H5s5b9I/0uNJxZ1UnBQJb /80IAhsCAUAJEI/0uNJxZ1UnwHQgBBkBCAAdFiEEGn3N4YVz0WNVyHskqDIjiipP6E8FAlv/ zQgACgkQqDIjiipP6E+FuggAl6lkO7BhTkrRbFhrcjCm0bEoYWnCkQtX9YFvElQeA7MhxznO BY/r1q2Uf6Ifr3YGEkLnME/tQQzUwznydM94CtRJ8KDSa1CxOseEsKq6B38xJtjgYSxNdgQb EIfCzUHIGfk94AFKPdV6pqqSU5VpPUagF+JxiAkoEPOdFiQCULFNRLMsOtG7yp8uSyJRp6Tz cQ+0+1QyX1krcHBUlNlvfdmL9DM+umPtbS9F6oRph15mvKVYiPObI1z8ymHoc68ReWjhUuHc IDQs4w9rJVAyLypQ0p+ySDcTc+AmPP6PGUayIHYX63Q0KhJFgpr1wH0pHKpC78DPtX1a7HGM 7MqzQ4NbD/4oLKKwByrIp12wLpSe3gDQPxLpfGgsJs6BBuAGVdkrdfIx2e6ENnwDoF0Veeji BGrVmjVgLUWV9nUP92zpyByzd8HkRSPNZNlisU4gnz1tKhQl+j6G/l2lDYsqKeRG55TXbu9M LqJYccPJ85B0PXcy63fL9U5DTysmxKQ5RgaxcxIZCM528ULFQs3dfEx5euWTWnnh7pN30RLg a+0AjSGd886Bh0kT1Dznrite0dzYlTHlacbITZG84yRk/gS7DkYQdjL8zgFr/pxH5CbYJDk0 tYUhisTESeesbvWSPO5uNqqy1dAFw+dqRcF5gXIh3NKX0gqiAA87NM7nL5ym/CNpJ7z7nRC8 qePOXubgouxumi5RQs1+crBmCDa/AyJHKdG2mqCt9fx5EPbDpw6Zzx7hgURh4ikHoS7/tLjK iqWjuat8/HWc01yEd8rtkGuUcMqbCi1XhcAmkaOnX8FYscMRoyyMrWClRZEQRokqZIj79+PR adkDXtr4MeL8BaB7Ij2oyRVjXUwhFQNKi5Z5Rve0a3zvGkkqw8Mz20BOksjSWjAF6g9byukl CUVjC03PdMSufNLK06x5hPc/c4tFR4J9cLrV+XxdCX7r0zGos9SzTPGNuIk1LK++S3EJhLFj 4eoWtNhMWc1uiTf9ENza0ntqH9XBWEQ6IA1gubCniGG+Xg== Message-ID: Date: Wed, 25 Sep 2019 18:42:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190919191315.25190-1-fparent@baylibre.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/09/2019 21:13, Fabien Parent wrote: > When timer_of_init fails, it cleans up after itself by undoing > everything it did during the initialization function. > > mtk_syst_init and mtk_gpt_init both call timer_of_cleanup if > timer_of_init fails. timer_of_cleanup try to release the resource taken. > Since these resources have already been cleaned up by timer_of_init, > we end up getting a few warnings printed: [ ... ] > This commit remove the calls to timer_of_cleanup when timer_of_init > fails since it is unnecessary and actually cause warnings to be printed. > > Signed-off-by: Fabien Parent Applied, thanks for the fix! In the future add the 'Fixes' tag please. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog