Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1822381ybn; Thu, 26 Sep 2019 02:45:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqzoNZJ0ZCgxkIS45ZVXdfi2PFRv17dN9iKminM+M+cvW41cdjOOdAARTlACqweameJJI1nG X-Received: by 2002:a17:906:244a:: with SMTP id a10mr2192157ejb.137.1569491140762; Thu, 26 Sep 2019 02:45:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569491140; cv=none; d=google.com; s=arc-20160816; b=HvdqNFPKApISoOUDDaVCybwsfkeHrIzdB0x5R/FysxfVdgrlurxKb6IHuYm1YzW2Jv l/rKpi4qEvHRLwxMVt6xu9t9zFQVhpFDky1R9TsFpdYdG3oX5QAIf9MhQlZ/X8l6Ia2D vxL0Tx6encOiMpnzKxJqUrg55qFEJC3oifBgN3hngH7oWIKB7lxquYleZNa9N0WaKm5V c04N19SMdU+mlDo51wwc5NuRYZVHW9MFok4hUdQ4om/Onqjf5MK4/b9nbSLpSstFGVTd hzMmKFFQD99mtRZiQLmLId5dpVHncxJH25or/wpQgugTOqP0rGVdvmxCx4skPsegVUcn wkqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=SldDdMCvb42kOlw4xzQW7gVTJLjho+01MgP87kKdXpk=; b=o89VTNFQHb8DIATKXAv0ZEY6T/S3sR5yw+RZhf1Fntr6mwAZLAuOh00Senqf1gS1Ym 8J7qNFlncoqf5cMaTop05ozZCD71gECRdXZifUIhszq/2OSl3o54iZIy1KqQFG/k2wod tSrsrSLWz6ZJLP8Y9AYVWbmoMuVObeE66e7WeBT0XeR5N26UXgFoZzRoSXxORoDtQVVB wfmbhwr8GEw5FjvxJTHmWubkE2/2+UiEufwmY23eedCpVr2dSXc1bzgUk5D7fCJDnuRr rKLsb2LQcGxpGbvH2Hla7mqICE3gbRUAAE/uD14QSE22SrwcG6wHue8G3jcSZSdGX3tA nHiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=axofkkkg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h51si1005973eda.85.2019.09.26.02.45.17; Thu, 26 Sep 2019 02:45:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=axofkkkg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392124AbfIYQrZ (ORCPT + 99 others); Wed, 25 Sep 2019 12:47:25 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:35814 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392099AbfIYQrY (ORCPT ); Wed, 25 Sep 2019 12:47:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=SldDdMCvb42kOlw4xzQW7gVTJLjho+01MgP87kKdXpk=; b=axofkkkgudCy wW1h64JlpzlwI9A+1kf4uxowV0hE6LS4aZnPVwdGiz26DHaspPObyClnZmIt5pwQJTpM9vDkQyx+y 8UyIzr92Z8lcASQSvjiu//j5k/5PvvyP5cycd+QFa5SKEKyxpMhrCeQaPHCfFIdIxLFEmRZI/4Bcy 7liZ0=; Received: from [12.157.10.118] (helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iDARf-0007uX-Ka; Wed, 25 Sep 2019 16:47:15 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 18588D01BD1; Wed, 25 Sep 2019 17:47:14 +0100 (BST) From: Mark Brown To: Lukasz Majewski Cc: kbuild test robot , krzk@kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown Subject: Applied "spi: Add call to spi_slave_abort() function when spidev driver is released" to the spi tree In-Reply-To: <20190925091143.15468-2-lukma@denx.de> X-Patchwork-Hint: ignore Message-Id: <20190925164714.18588D01BD1@fitzroy.sirena.org.uk> Date: Wed, 25 Sep 2019 17:47:14 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch spi: Add call to spi_slave_abort() function when spidev driver is released has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 9f918a728cf86b2757b6a7025e1f46824bfe3155 Mon Sep 17 00:00:00 2001 From: Lukasz Majewski Date: Wed, 25 Sep 2019 11:11:42 +0200 Subject: [PATCH] spi: Add call to spi_slave_abort() function when spidev driver is released This change is necessary for spidev devices (e.g. /dev/spidev3.0) working in the slave mode (like NXP's dspi driver for Vybrid SoC). When SPI HW works in this mode - the master is responsible for providing CS and CLK signals. However, when some fault happens - like for example distortion on SPI lines - the SPI Linux driver needs a chance to recover from this abnormal situation and prepare itself for next (correct) transmission. This change doesn't pose any threat on drivers working in master mode as spi_slave_abort() function checks if SPI slave mode is supported. Signed-off-by: Lukasz Majewski Link: https://lore.kernel.org/r/20190924110547.14770-2-lukma@denx.de Signed-off-by: Mark Brown Reported-by: kbuild test robot Link: https://lore.kernel.org/r/20190925091143.15468-2-lukma@denx.de Signed-off-by: Mark Brown --- drivers/spi/spidev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index 255786f2e844..3ea9d8a3e6e8 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -627,6 +627,9 @@ static int spidev_release(struct inode *inode, struct file *filp) if (dofree) kfree(spidev); } +#ifdef CONFIG_SPI_SLAVE + spi_slave_abort(spidev->spi); +#endif mutex_unlock(&device_list_lock); return 0; -- 2.20.1