Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 25 Sep 2019 14:05:19 -0700 (PDT)
Subject:     Re: [PATCH 04/32] riscv: Use pr_warn instead of pr_warning
In-Reply-To: <20190920062544.180997-5-wangkefeng.wang@huawei.com>
CC:     joe@perches.com, akpm@linux-foundation.org, mingo@redhat.com,
        davem@davemloft.net, acme@redhat.com, apw@canonical.com,
        peterz@infradead.org, ast@kernel.org, daniel@iogearbox.net,
        Greg KH <gregkh@linuxfoundation.org>,
        sergey.senozhatsky@gmail.com, pmladek@suse.com,
        Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org,
        wangkefeng.wang@huawei.com,
        Paul Walmsley <paul.walmsley@sifive.com>, aou@eecs.berkeley.edu
From:   Palmer Dabbelt <palmer@sifive.com>
To:     wangkefeng.wang@huawei.com
Message-ID: <mhng-77b10aea-889e-40f5-a698-b47d44ba606c@palmer-si-x1e>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 19 Sep 2019 23:25:16 PDT (-0700), wangkefeng.wang@huawei.com wrote:
> As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of
> pr_warning"), removing pr_warning so all logging messages use a
> consistent <prefix>_warn style. Let's do it.
>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@sifive.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  arch/riscv/kernel/module.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c
> index 70bb94ae61c5..b7401858d872 100644
> --- a/arch/riscv/kernel/module.c
> +++ b/arch/riscv/kernel/module.c
> @@ -315,8 +315,8 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab,
>  			/* Ignore unresolved weak symbol */
>  			if (ELF_ST_BIND(sym->st_info) == STB_WEAK)
>  				continue;
> -			pr_warning("%s: Unknown symbol %s\n",
> -				   me->name, strtab + sym->st_name);
> +			pr_warn("%s: Unknown symbol %s\n",
> +				me->name, strtab + sym->st_name);
>  			return -ENOENT;
>  		}

Acked-by: Palmer Dabbelt <palmer@sifive.com>

I'm assuming this is going in through some other tree, LMK if that's not the 
case.