Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1856455ybn; Thu, 26 Sep 2019 03:17:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqwfbUQGNRD8uukwz4gi+f/GHtv8HUfIBxSBxHL8yWP1q337yF8VrQhhv+JZs/9j445bFKQd X-Received: by 2002:a05:6402:a4b:: with SMTP id bt11mr2599306edb.175.1569493022366; Thu, 26 Sep 2019 03:17:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569493022; cv=none; d=google.com; s=arc-20160816; b=x+6TAshQ3o1xpcDjfVfpGS46WN4ECmZ345Bw1aGKyo0JRUQu027Byt3TrfJJnZm5/L 2Q3+ewEcbDkemsS5xWIh9qm5ohNVFuKo+fKDORrOaoauFdQlwNZ6mCBf9/pIZBYh7FIQ apr/uGPKRe14bW75KbfY+NkCW+vBooDZteQe7M1YJ5o/MeBNQL63jACSAF2QSIRlOM2r 2wQQZs0NhRz6U1Ss1saw/3XBykE+So5v53+yMsvpQOO9BsBGd+uoF/FuSWipct5mLKJO QL33oHrhcejVSahlY43oS4UvYfkXqrRYqVW0FuskKWOF/EZ9a146x+s02C5T0R5OdAMb krAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:to:from; bh=n3VsU1aBN2cfEJJpHMaELkGxoJWaJdn9iiz7yJFQ1jc=; b=HdN6YGqoZUbvB5OhD9rGHDVqeyHN6mK1iKdT8ZV+OVZObRyo684smRxB1EeJuhEH/1 /sp/919AMlaRWvI2XtPqeNbImDdkcUx1OIAGlIuNMndJT5DcrhPquT8NjBcU/Ht23/9m +TVbhBArC8NbSDu0H+cFvsuH5MW0MVv3bbb9Wdq42BztFgO4+xr2Lgo+f0Z4y6gu+O6s eVWYNXtJZ7UG/NRGqSGhHkk2xM1uKPURadpAHn/XrJhrbLbJcgyA7XnOlATDCe5KkwOE yJVu/xkXfk4cMdaE/W8+ILjYW9GhXWc0+34iozsQk4iTZPVOn1patXVblAWgPF+/u01C m0iQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c48si993315eda.100.2019.09.26.03.16.39; Thu, 26 Sep 2019 03:17:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390760AbfIZBbr (ORCPT + 99 others); Wed, 25 Sep 2019 21:31:47 -0400 Received: from inva020.nxp.com ([92.121.34.13]:45556 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726770AbfIZBbq (ORCPT ); Wed, 25 Sep 2019 21:31:46 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 4F62C1A04E6; Thu, 26 Sep 2019 03:31:44 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id B83BD1A08E8; Thu, 26 Sep 2019 03:31:37 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 7DB99402D5; Thu, 26 Sep 2019 09:31:29 +0800 (SGT) From: Shengjiu Wang To: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, lars@metafoo.de Subject: [PATCH V5 2/4] ASoC: fsl_asrc: update supported sample format Date: Thu, 26 Sep 2019 09:29:49 +0800 Message-Id: <45a7c383f43cc1dd9d0934846447aee653278c03.1569387932.git.shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ASRC support 24bit/16bit/8bit input width, which is data width, not slot width. For the S20_3LE format, the data with is 20bit, slot width is 24bit, if we set ASRMCR1n.IWD to be 24bits, the result is the volume is lower than expected, it likes 24bit data right shift 4 bits So replace S20_3LE with S24_3LE in supported list and add S8 format in TX supported list Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen --- sound/soc/fsl/fsl_asrc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index 4d3804a1ea55..584badf956d2 100644 --- a/sound/soc/fsl/fsl_asrc.c +++ b/sound/soc/fsl/fsl_asrc.c @@ -624,7 +624,7 @@ static int fsl_asrc_dai_probe(struct snd_soc_dai *dai) #define FSL_ASRC_FORMATS (SNDRV_PCM_FMTBIT_S24_LE | \ SNDRV_PCM_FMTBIT_S16_LE | \ - SNDRV_PCM_FMTBIT_S20_3LE) + SNDRV_PCM_FMTBIT_S24_3LE) static struct snd_soc_dai_driver fsl_asrc_dai = { .probe = fsl_asrc_dai_probe, @@ -635,7 +635,8 @@ static struct snd_soc_dai_driver fsl_asrc_dai = { .rate_min = 5512, .rate_max = 192000, .rates = SNDRV_PCM_RATE_KNOT, - .formats = FSL_ASRC_FORMATS, + .formats = FSL_ASRC_FORMATS | + SNDRV_PCM_FMTBIT_S8, }, .capture = { .stream_name = "ASRC-Capture", -- 2.21.0