Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1857172ybn; Thu, 26 Sep 2019 03:17:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqxwvVmiCT842eyZT94NO2y/8GefHg249FVPUO5RxnFJajQJXnrzkXWkxvCKPxXAI65GDZro X-Received: by 2002:a50:eb93:: with SMTP id y19mr2666177edr.94.1569493063187; Thu, 26 Sep 2019 03:17:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569493063; cv=none; d=google.com; s=arc-20160816; b=Nuok+bIO/4K3dnydC5GW0CzYY2VT5hTLOurT1BzIV/V3swrjp9PY74aQFaMCfPEYL6 7O3/Pqgf8QESsWYzfg9oza4DH1L6ezxGjaCaSAucz7vh3CknTEY7DvzgxmthJd5Tbo7Z jSMwQniaoVwl/xp1JwlF/XtWJzo2NKsc8n9zxO3uQpSl9HuzK+Rll2nBOT4Wjiy0+q87 YiGJ64g4LMeO5wBupcyHx/z9RaJWVy6SEmSk2oA9GkUeLEB6H83z1QE/WrXX2IPAKy3r JeKWopwTl76/oDUBbeXD7wXPicERCxgxTxFCBaWM7e6TUSTA6UYbkiOLO+jDhvCwFnfr Y23Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=g79iQ5954rtslsFt/AYMD/DbOLwNd1ZW6o8Fa9zuW40=; b=YOczD84n6NzEXTgkBEvrRygkpylTSu46BH2ZKWQGsQSqSNvZ97ZHKVhOgFnuEXDN5a hTfHva/W9hSwhMW4KfvWOJseQHU1q0j68SCv1m8Jr2uEXKyPrS0xfn9XuywruVuynZba ABV4S1IAUgTnjdmlsa6iMUXCTxyqc8XFD5B4DUl2ErIGH2m94nbvGT3RuF2UsPJVF5S3 eiS9iDrORlXhAzg/NRf8AtPWtuTjyG1p4/flIHKfwVcmAqhFIBLqrfqRwoTdk48Dj3lv R/mbF6GsUm7Uq54zkpqArty8ofKdiA5AmDVEwLPjO36nUH9QpHq/KGhPrlNlOURjit/3 wRdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q17si753722ejx.139.2019.09.26.03.17.19; Thu, 26 Sep 2019 03:17:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726982AbfIZCwC (ORCPT + 99 others); Wed, 25 Sep 2019 22:52:02 -0400 Received: from inva021.nxp.com ([92.121.34.21]:56076 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725768AbfIZCwC (ORCPT ); Wed, 25 Sep 2019 22:52:02 -0400 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id AA44D2004DD; Thu, 26 Sep 2019 04:51:59 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 173CF200049; Thu, 26 Sep 2019 04:51:55 +0200 (CEST) Received: from titan.ap.freescale.net (TITAN.ap.freescale.net [10.192.208.233]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 2A031402D5; Thu, 26 Sep 2019 10:51:49 +0800 (SGT) From: Biwen Li To: leoyang.li@nxp.com, shawnguo@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, ran.wang_1@nxp.com Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Biwen Li Subject: [v4,1/3] soc: fsl: handle RCPM errata A-008646 on SoC LS1021A Date: Thu, 26 Sep 2019 10:41:16 +0800 Message-Id: <20190926024118.15931-1-biwen.li@nxp.com> X-Mailer: git-send-email 2.9.5 X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Description: - Reading configuration register RCPM_IPPDEXPCR1 always return zero Workaround: - Save register RCPM_IPPDEXPCR1's value to register SCFG_SPARECR8.(uboot's psci also need reading value from the register SCFG_SPARECR8 to set register RCPM_IPPDEXPCR1) Impact: - FlexTimer module will cannot wakeup system in deep sleep on SoC LS1021A Signed-off-by: Biwen Li --- Change in v4: - rename property name fsl,ippdexpcr-alt-addr -> fsl,ippdexpcr1-alt-addr Change in v3: - update commit message - rename property name fsl,rcpm-scfg -> fsl,ippdexpcr-alt-addr Change in v2: - fix stype problems drivers/soc/fsl/rcpm.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/drivers/soc/fsl/rcpm.c b/drivers/soc/fsl/rcpm.c index 82c0ad5e663e..9a29c482fc2e 100644 --- a/drivers/soc/fsl/rcpm.c +++ b/drivers/soc/fsl/rcpm.c @@ -13,6 +13,8 @@ #include #include #include +#include +#include #define RCPM_WAKEUP_CELL_MAX_SIZE 7 @@ -29,6 +31,9 @@ static int rcpm_pm_prepare(struct device *dev) struct rcpm *rcpm; u32 value[RCPM_WAKEUP_CELL_MAX_SIZE + 1], tmp; int i, ret, idx; + struct regmap *scfg_addr_regmap = NULL; + u32 reg_offset[RCPM_WAKEUP_CELL_MAX_SIZE + 1]; + u32 reg_value = 0; rcpm = dev_get_drvdata(dev); if (!rcpm) @@ -63,6 +68,34 @@ static int rcpm_pm_prepare(struct device *dev) tmp |= value[i + 1]; iowrite32be(tmp, rcpm->ippdexpcr_base + i * 4); } + /* Workaround of errata A-008646 on SoC LS1021A: + * There is a bug of register ippdexpcr1. + * Reading configuration register RCPM_IPPDEXPCR1 + * always return zero. So save ippdexpcr1's value + * to register SCFG_SPARECR8.And the value of + * ippdexpcr1 will be read from SCFG_SPARECR8. + */ + scfg_addr_regmap = syscon_regmap_lookup_by_phandle(np, + "fsl,ippdexpcr1-alt-addr"); + if (scfg_addr_regmap && (1 == i)) { + if (of_property_read_u32_array(dev->of_node, + "fsl,ippdexpcr1-alt-addr", + reg_offset, + 1 + sizeof(u64)/sizeof(u32))) { + scfg_addr_regmap = NULL; + continue; + } + /* Read value from register SCFG_SPARECR8 */ + regmap_read(scfg_addr_regmap, + (u32)(((u64)(reg_offset[1] << (sizeof(u32) * 8) | + reg_offset[2])) & 0xffffffff), + ®_value); + /* Write value to register SCFG_SPARECR8 */ + regmap_write(scfg_addr_regmap, + (u32)(((u64)(reg_offset[1] << (sizeof(u32) * 8) | + reg_offset[2])) & 0xffffffff), + tmp | reg_value); + } } } } while (ws = wakeup_source_get_next(ws)); -- 2.17.1