Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1859072ybn; Thu, 26 Sep 2019 03:19:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqyLt6ox/BKTd5l/KxnZJphVpKYYXJZFu+m0DePpNrPLZsWG6LUFwMRsYuODqTvpIdcmeBXd X-Received: by 2002:a17:906:82d3:: with SMTP id a19mr2259453ejy.151.1569493165089; Thu, 26 Sep 2019 03:19:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569493165; cv=none; d=google.com; s=arc-20160816; b=td/HW+WLkJbQyNb/bqDJT/lmG9rTjo5dZLOQ/9HsHrQTxxm5WR5hVqC96ylhfFSj8l ujniwwwpRCrSej+lODM3+2vjreJBC4dKDLE24WKTpxefvMdVaWmPTyKrqjL3Gkvhw0zb /i7lxi8C1+BGsxK8MD2etlXOwEpzQ9FPzk46UnHDo/4BYSEKfm89aiCV48oL/Noa1dJP 3ESvz5v5gO0fTDBzpAZmdzILjmM1WVscSkBlPnYLDNFAtGL5215xKf2Ry25IkZdkLdLz WIrKhaHIloilpniAEFW/YHB3Vje6eNARpRmZ3ejAeHswYPq5IqlEKm8nr2a9IzEzQfeI HRSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:date:subject:cc:to:from; bh=Qxerm/dRUeQ92/itGshJdarR8Bt+UJXWRH8r7F8k8NU=; b=MTpVO2a6dLNVp7lW9WSjn3QLvkPiMfQm8JpPY/GhhShQPXGaR5/3iBD6+7QNQvdSYa 5lGacD/FeqXkfsh42Z12A87mZrX7xf6FewZ19Nm6HOiNfcI+MJpwCjwWN1c9Syja+G3a 63hC6XTjEyI/fbRFAxeJcgJYx3gy3MD0zZYqSqMFRw/h/dsjnVYJfDyag/LdXTCamUp1 xQTNFTR6c+MUUpBnFSb6m7/u+P+MGTg1Cn+i7xCMXj2FeucMfcOOSR27SrqeQHGDU0HZ EF6ghISkRODGr+HcPLM2NfX0f0/EZgQYIb6ol9HNINZM1ciNrx8wO7h05ZXYTeWW0vaX FI8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s42si961065edm.292.2019.09.26.03.19.01; Thu, 26 Sep 2019 03:19:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391856AbfIZEys (ORCPT + 99 others); Thu, 26 Sep 2019 00:54:48 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:48442 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728905AbfIZEys (ORCPT ); Thu, 26 Sep 2019 00:54:48 -0400 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x8Q4qKUi039370 for ; Thu, 26 Sep 2019 00:54:47 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2v8k15ydsv-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 26 Sep 2019 00:54:47 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Sep 2019 05:54:44 +0100 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 26 Sep 2019 05:54:40 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x8Q4sCc233423804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Sep 2019 04:54:12 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8DA5011C054; Thu, 26 Sep 2019 04:54:39 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 39E4311C04A; Thu, 26 Sep 2019 04:54:39 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 26 Sep 2019 04:54:39 +0000 (GMT) Received: from adsilva.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id CA78AA00D3; Thu, 26 Sep 2019 14:54:37 +1000 (AEST) From: "Alastair D'Silva" To: alastair@d-silva.org Cc: stable@vger.kernel.org, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Christophe Leroy , Qian Cai , Thomas Gleixner , Nicholas Piggin , Greg Kroah-Hartman , Allison Randal , Andrew Morton , Michal Hocko , Mike Rapoport , David Hildenbrand , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 1/6] powerpc: Allow flush_icache_range to work across ranges >4GB Date: Thu, 26 Sep 2019 14:54:07 +1000 X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190926045419.22827-1-alastair@au1.ibm.com> References: <20190926045419.22827-1-alastair@au1.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19092604-0012-0000-0000-00000350CDA7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19092604-0013-0000-0000-0000218B63B0 Message-Id: <20190926045419.22827-2-alastair@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-09-26_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=654 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909260048 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alastair D'Silva When calling flush_icache_range with a size >4GB, we were masking off the upper 32 bits, so we would incorrectly flush a range smaller than intended. This patch replaces the 32 bit shifts with 64 bit ones, so that the full size is accounted for. Signed-off-by: Alastair D'Silva Cc: stable@vger.kernel.org --- arch/powerpc/kernel/misc_64.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/misc_64.S b/arch/powerpc/kernel/misc_64.S index b55a7b4cb543..9bc0aa9aeb65 100644 --- a/arch/powerpc/kernel/misc_64.S +++ b/arch/powerpc/kernel/misc_64.S @@ -82,7 +82,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_COHERENT_ICACHE) subf r8,r6,r4 /* compute length */ add r8,r8,r5 /* ensure we get enough */ lwz r9,DCACHEL1LOGBLOCKSIZE(r10) /* Get log-2 of cache block size */ - srw. r8,r8,r9 /* compute line count */ + srd. r8,r8,r9 /* compute line count */ beqlr /* nothing to do? */ mtctr r8 1: dcbst 0,r6 @@ -98,7 +98,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_COHERENT_ICACHE) subf r8,r6,r4 /* compute length */ add r8,r8,r5 lwz r9,ICACHEL1LOGBLOCKSIZE(r10) /* Get log-2 of Icache block size */ - srw. r8,r8,r9 /* compute line count */ + srd. r8,r8,r9 /* compute line count */ beqlr /* nothing to do? */ mtctr r8 2: icbi 0,r6 -- 2.21.0