Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1859491ybn; Thu, 26 Sep 2019 03:19:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqyditjOMOZzrVoH3Cf8JmuaxSAfKjKfqU+K1K9eegnni7ukmPt5KKvIJoWUq0CUs+/huBH2 X-Received: by 2002:a50:f60d:: with SMTP id c13mr2633892edn.279.1569493187311; Thu, 26 Sep 2019 03:19:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569493187; cv=none; d=google.com; s=arc-20160816; b=KuTo61R7lChf3ozOYz2bzIx37DCTuEnQt9EeZiTjns/y+IvyfLmfT6xtksoaxCpn+W aFp/G0haneanhKOvbQSD9Isr4S2oHn2FebEf1KLNe4D72s4y8K3KsjAXBmVxXa7AjJS+ SWtrJmDRl0/CVTbGI0FkwKqeyv7ZDZsmV7SPms+NaLeK4+b8k+XM9p0VlNZViuCRDt+B dFC8Gn81oWFGQzKC062ZI5tNocwPqgHmKyZQpG/h+2PT3JwVjEJIMBG9mvGlhY/PwnxY I+yTOxBId8w/cqbRTkMHxylXWNNJ1kHi8E9YDhpg3+fab57bTAqNsNE8G1c4dfapx0hI D7+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:date:subject:cc:to:from; bh=ZpFnDwYDTXWl0oHMHv7Sd4yhuGNnXpKfI3CQouHAfas=; b=UCmz6mdAevvwfJ1DpZFQeBWk+ks35lpD8LO5kWchJzKJq3sRl0O0yJJDFWTKXqD49G oUnNR8C/Tey9MJq+t+8kPsMEA+7uDO9AQAT44DOTpxL6WfQa2sk3lYJ6ajIYX9miUt9h 4d1qZh8JmJhZC5B8IDEhQcS5TQ3vJBVNPjtzIbRNSl3YEOfuFurEgFizOtgLxvfTE3H6 edsSO0b+ONVGMzqwg62SMMhLlDis2y0StYuNdcWYCeH3hhe/GXMhCz1Ju6laIoYF7lrm CynjEYfTX6Q+LDRdfd/hdkUozx3dHbHsU1cRV6K6NDwPCo8HMUu4zHCfQdbLvTGSg3bP iq/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id by16si957171edb.30.2019.09.26.03.19.23; Thu, 26 Sep 2019 03:19:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391726AbfIZEz2 (ORCPT + 99 others); Thu, 26 Sep 2019 00:55:28 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:45554 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733188AbfIZEz2 (ORCPT ); Thu, 26 Sep 2019 00:55:28 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x8Q4qpom042804 for ; Thu, 26 Sep 2019 00:55:27 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2v8mmj4dex-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 26 Sep 2019 00:55:27 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Sep 2019 05:55:25 +0100 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 26 Sep 2019 05:55:19 +0100 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x8Q4tInX43975006 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Sep 2019 04:55:18 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CFAAFA4064; Thu, 26 Sep 2019 04:55:18 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7AE55A4062; Thu, 26 Sep 2019 04:55:18 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 26 Sep 2019 04:55:18 +0000 (GMT) Received: from adsilva.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 16DFEA00D3; Thu, 26 Sep 2019 14:55:17 +1000 (AEST) From: "Alastair D'Silva" To: alastair@d-silva.org Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Christophe Leroy , Allison Randal , Qian Cai , Thomas Gleixner , Nicholas Piggin , Greg Kroah-Hartman , Andrew Morton , Michal Hocko , Mike Rapoport , David Hildenbrand , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 6/6] powerpc: Don't flush caches when adding memory Date: Thu, 26 Sep 2019 14:54:12 +1000 X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190926045419.22827-1-alastair@au1.ibm.com> References: <20190926045419.22827-1-alastair@au1.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19092604-0012-0000-0000-00000350CDB9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19092604-0013-0000-0000-0000218B63C5 Message-Id: <20190926045419.22827-7-alastair@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-09-26_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=651 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909260048 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alastair D'Silva This operation takes a significant amount of time when hotplugging large amounts of memory (~50 seconds with 890GB of persistent memory). This was orignally in commit fb5924fddf9e ("powerpc/mm: Flush cache on memory hot(un)plug") to support memtrace, but the flush on add is not needed as it is flushed on remove. Signed-off-by: Alastair D'Silva --- arch/powerpc/mm/mem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c index a2758e473d58..9afb77a8c8d5 100644 --- a/arch/powerpc/mm/mem.c +++ b/arch/powerpc/mm/mem.c @@ -142,8 +142,6 @@ int __ref arch_add_memory(int nid, u64 start, u64 size, return -EFAULT; } - flush_dcache_range_chunked(start, start + size, FLUSH_CHUNK_SIZE); - return __add_pages(nid, start_pfn, nr_pages, restrictions); } -- 2.21.0