Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1859623ybn; Thu, 26 Sep 2019 03:19:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqxG9C/URFte4mNRtI2902qAA2eACcK2fEErSzDd58/4DjAD0oYZsQaKyqbajtq+5xmpGsP9 X-Received: by 2002:aa7:d508:: with SMTP id y8mr2608793edq.171.1569493193583; Thu, 26 Sep 2019 03:19:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569493193; cv=none; d=google.com; s=arc-20160816; b=D51ZXL5H8LqCbmXos1ab5k8Gip+ddlVJLJAnhUKEPjI1BTfgY4H+SSvQ5AVA8KRIKp hyhpc3VJl/HUBv+HP7NX7al86XcabnEvqed7TKwAgrevcmVhTCfa+FzhW9gEAI0ZpM6h V8mFqxOU5I/d+pYQc2R3CJSnIbp0xO3Z+AAdFevbDIHAq6Myryim9BhYNitKsm0rLd/f 0Yvht2KK7KAY1PksZmauW+Jdg+VWkfPAgd1qzMRRQ2+zvYkMDsesAqXjtvAP8ae9ENbK 0Qmg22khA2aaPTGdVcPff4WE6bIJljTJC/TcaFDGBxG95XmfElGM6QwHsJTc/iUMSIWl zhdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject:reply-to; bh=xQhoAUabi0ck+laQwaWiJC+2AXNGicrQtCWuvtB/rXI=; b=lWJZpSLePbTqrwVOl3IKMK3+jSev9cjQvHo1cu0b21065/43M6KyyHvZKiBoGGkhxC uQSX0afeZIYs+nqeJAbLgj7fnI+DFuvPgweN1+fA3csMWBlXKya67xv1hz1T3JIuYsVN 1UvHH/A63acLqVgmOZREAV5OHNUMJfNtfrk1OLbWxVxmTQKVuGS8HN50p3Ipf9g1YPrm WpDXEU3DLGfUABvUHRAJQe2WbbQMaiYPPd8UR+c6PxGe+QD0zpObtw6Pvo64kL0qEka/ hCNJdoOWUPNQLCY15F6upu/Tl2dHyaYcQZZFxsfFAghxUdZ2KScqE4/5Ir8vSZ8sQZGT 85kA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c6si1063151edc.291.2019.09.26.03.19.29; Thu, 26 Sep 2019 03:19:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388768AbfIZFBL (ORCPT + 99 others); Thu, 26 Sep 2019 01:01:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46862 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729017AbfIZFBK (ORCPT ); Thu, 26 Sep 2019 01:01:10 -0400 Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9AEE0C057F88 for ; Thu, 26 Sep 2019 05:01:10 +0000 (UTC) Received: by mail-pg1-f197.google.com with SMTP id h189so657332pgc.4 for ; Wed, 25 Sep 2019 22:01:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=xQhoAUabi0ck+laQwaWiJC+2AXNGicrQtCWuvtB/rXI=; b=hZG6F0aFCTa+DZT514GMCTNTBdekCuFrsUTcEt6yJNc6CW9WjSPgpDWOmeMoE0Go9P IC5Sola5Qw4zYQSQ3d1aOf93TLChy3IqP/exC06S27slWBGXPxJwn3s7kn8IMfDsc7ho Hxh3IUnCLCgs00GOQrPGyuTyyb0XE7CBe9hQ0QteUJg8cyKE/anNofBB3ur+W/MO66/W JmKdpqvgtQ3VfMdraciS4uDRGqzNaBbu1h4L+h/aUdt/6yFJWoyL4w/Mh51gubHZJV/J 4ojNqJu9XaG8rtDlhrnJ5YCaATSG42Z5bCzhguENsAGYvNt9MtO8x6RDoL7TuYEU+D5P XIxg== X-Gm-Message-State: APjAAAWxgnTSEoSGJlO+i+a6M57ZyKu0nm1OFkLLwLkwhw9ihM6N5beQ AI9qxC9o4+o2f+1ji7XquTaL0LtPEurIQxkVnU0OizWSyagzav9RV+xCPNlaAKNBV/HxHUi/TK5 sa/4yyjnVlaP54+Fr1cqOD+fm X-Received: by 2002:a17:902:8f92:: with SMTP id z18mr1885999plo.248.1569474069946; Wed, 25 Sep 2019 22:01:09 -0700 (PDT) X-Received: by 2002:a17:902:8f92:: with SMTP id z18mr1885962plo.248.1569474069536; Wed, 25 Sep 2019 22:01:09 -0700 (PDT) Received: from [10.76.0.124] ([125.16.200.50]) by smtp.gmail.com with ESMTPSA id 6sm836051pfa.162.2019.09.25.22.01.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Sep 2019 22:01:08 -0700 (PDT) Reply-To: mgandhi@redhat.com Subject: Re: [PATCH] scsi: core: Log SCSI command age with errors To: Bart Van Assche , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Cc: jejb@linux.ibm.com, martin.petersen@oracle.com, Laurence Oberman References: <20190923060122.GA9603@machine1> From: "Milan P. Gandhi" Organization: Red Hat Message-ID: <01be9696-b7ce-4601-0a0b-a7cbb234b1ce@redhat.com> Date: Thu, 26 Sep 2019 10:31:05 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/25/19 9:15 PM, Bart Van Assche wrote: > On 9/22/19 11:01 PM, Milan P. Gandhi wrote: >> +??? off += scnprintf(logbuf + off, logbuf_len - off, >> +???????????? "cmd-age=%lus", cmd_age); > > Have you considered to change cmd-age into cmd_age? I'm afraid otherwise someone might interpret the hyphen as a subtraction sign... Thanks for your suggestion Bart. Yes, it would be better to use cmd_age to avoid any confusion. I will change it and send the updated patch. Thanks, Milan.