Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1865529ybn; Thu, 26 Sep 2019 03:25:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqzDxIJiSP67Wpc9TwHuuVqA6VEbym2Usj77lHLRSbTOzzNz6WHOhcguSE3dbGErkPJtZ8aF X-Received: by 2002:a17:906:e290:: with SMTP id gg16mr2313781ejb.176.1569493556373; Thu, 26 Sep 2019 03:25:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569493556; cv=none; d=google.com; s=arc-20160816; b=z4lQduPa4JBm2/qRaPmsKNKMSSQj8tRuOJcmvwDWzwSx7fLgTH7ThuCIifXURUgda1 Zob/x29URglLmKq5MVdFmeGaimvs3hn4iA+RnVDH+rqHGnjx+Z9SpuRabmJiBn9Zy4H2 lrEQ2M4MVuTTyDcP1UdwPNvM2qMGqMvt6apADtwz6bx+yFZCxUv0zZU4OkhDBN2bJj/O ZlLpu3O6k5C1KvczdzpCb1SsFZTiEb36I9HnPY2DtoeTeVwTJrbnWL0iG40d1WE+sfov 5SZFlrJPtx16csf7VypoIBwK8oHbxtKspm8P/1YMP77hN0HWLngXJDDuDD3/sza/eEM0 fRnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=u/+FmsO2fNzcsmYglT3xz6RDpSXgM0989c2PSz8Zvf4=; b=Xwq46+LK4UJbKy+c2m0395cS3mWXYHQANXzo740DhbgYycsVpUQP/gM8BFtUWJmVwb CX6oiktKe2gV+pPwC/ue6ITBr6Q7xJw5/UvP/5zkGEhImUQWbHkntbIx0WJ1Xi0ay9gh darYgL5a4XYu5pJe+gydHxrgIyFx5kUfGPIS4K9UF+40HwqML0bU+Jnfzcgw/HSjtEQS EbLBkU5jVdK8lgNrhi2GnOf7GXBrvuLQKUUYd5bzl7ReamY6pO7SSTwhCcdTVJxAVoMs b5wvvjkgB4lV7z95cNxRsm48LG5FJ5q2meyKiBm8L3//f/Bk3+4wUB4AW8iblrvYfWNw PiLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=VFGoxo+2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id om23si742315ejb.194.2019.09.26.03.25.32; Thu, 26 Sep 2019 03:25:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=VFGoxo+2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728065AbfIZHMq (ORCPT + 99 others); Thu, 26 Sep 2019 03:12:46 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:55681 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727996AbfIZHMp (ORCPT ); Thu, 26 Sep 2019 03:12:45 -0400 Received: by mail-wm1-f68.google.com with SMTP id a6so1341239wma.5 for ; Thu, 26 Sep 2019 00:12:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=u/+FmsO2fNzcsmYglT3xz6RDpSXgM0989c2PSz8Zvf4=; b=VFGoxo+2NsxxwxjafuC2PpLHAFStjdosoGEbFmrM8SZ3rrImY4Sqc1/3J0DL/nSiek cKXmLnyFis+D0MbKrVE0ATCMolB8ETO3TmYRdu83WYIqnQN2/9Kr879GEZ2XHDJJp0Np sfEk1iSsp2VIf4BX2N7yHGkfOznLAcThCZOePG9i/g9qzTRvaEjv8bR5rGYL86uzXlQx FVWTg05Jc+tDb3dA6Y661ABAFal9Jdn4j3GNAfXvyNBLm7YFtNgG3YtiZnpvk0ZpjpRu SfIdUGBrMNXSt8Y7+NgK6sl1kd11BTn6K3rme6akMMJnevDRjfsXmJnf+0J+hfgcnGmm f3BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=u/+FmsO2fNzcsmYglT3xz6RDpSXgM0989c2PSz8Zvf4=; b=KPqFK8KG9jmLmUpL8f37yINExHz65VicJGJdPEtfS19c/QmidPvsuCf1I4WrdEDHRF 1ef2+lX51Zu5Wtxtyb11nvSOFXyabzpsP8mnA3fDYNXPy1n+GuCaxPurf1/SF47D86SL gj4Emr/AwvVd4z7SstfM+1ar7qtDjakJKCF6iNdB1aU8vlOGM3JSdx5DK7mYllVJgzdw iHXwdXUGIByyzBK/J1HpYe4m+nDoxmdo+uTQ9ILL0Ozy09bB0LoiWgcra/Ab1lJ5E8K5 nj3xvei4hjmburrUXkFQ3Jt573HkVXIC4uz7TtkXk1QFcaAYolgHNTnq7PFqKPAZsvw4 DuZg== X-Gm-Message-State: APjAAAWEn9+LgFpP9o3GXeqGVcBr1ctP5o6WZduJmEVYwYYeJKCP9ipm zePyfHbaEggLCsTbWnHCri5g5g== X-Received: by 2002:a1c:7c15:: with SMTP id x21mr1547161wmc.36.1569481960055; Thu, 26 Sep 2019 00:12:40 -0700 (PDT) Received: from [172.20.9.27] ([83.167.33.93]) by smtp.gmail.com with ESMTPSA id a14sm1398033wmm.44.2019.09.26.00.12.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Sep 2019 00:12:39 -0700 (PDT) Subject: Re: [PATCH 1/3 for-5.4/block] iocost: better trace vrate changes To: Tejun Heo Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, cgroups@vger.kernel.org References: <20190925230207.GI2233839@devbig004.ftw2.facebook.com> From: Jens Axboe Message-ID: <310739da-b606-6485-9979-9bc03a592265@kernel.dk> Date: Thu, 26 Sep 2019 09:12:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190925230207.GI2233839@devbig004.ftw2.facebook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/26/19 1:02 AM, Tejun Heo wrote: > vrate_adj tracepoint traces vrate changes; however, it does so only > when busy_level is non-zero. busy_level turning to zero can sometimes > be as interesting an event. This patch also enables vrate_adj > tracepoint on other vrate related events - busy_level changes and > non-zero nr_lagging. > > Signed-off-by: Tejun Heo > --- > Hello, Jens. > > I've encountered vrate regulation issues while testing on a hard disk > machine. These are three patches to improve vrate adj visibility and > fix the issue. Applied 1-3 for 5.4, thanks Tejun. -- Jens Axboe