Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 26 Sep 2019 14:09:22 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Hans Andersson <haan@cellavision.se>
Cc:     f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        antoine.tenart@bootlin.com,
        Hans Andersson <hans.andersson@cellavision.se>
Subject: Re: [PATCH] net: phy: micrel: add Asym Pause workaround for KSZ9021
Message-ID: <20190926120922.GD1864@lunn.ch>
References: <20190926075437.18088-1-haan@cellavision.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190926075437.18088-1-haan@cellavision.se>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Sep 26, 2019 at 09:54:37AM +0200, Hans Andersson wrote:
> From: Hans Andersson <hans.andersson@cellavision.se>
> 
> The Micrel KSZ9031 PHY may fail to establish a link when the Asymmetric
> Pause capability is set. This issue is described in a Silicon Errata
> (DS80000691D or DS80000692D), which advises to always disable the
> capability.
> 
> Micrel KSZ9021 has no errata, but has the same issue with Asymmetric Pause.
> This patch apply the same workaround as the one for KSZ9031.
> 
> Signed-off-by: Hans Andersson <hans.andersson@cellavision.se>

Fixes: 3aed3e2a143c ("net: phy: micrel: add Asym Pause workaround")

This is not the best fixes: tag, since it was not that change which
broke it. But going further back will be hard.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew