Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp2006144ybn; Thu, 26 Sep 2019 05:42:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqz51gu74SliLSCLlenx5F/dZ90hSRyyGfs6wzoEsi9DeajYeZOVR8OaIrE8BFxzdErSEhEd X-Received: by 2002:a17:906:3298:: with SMTP id 24mr2914349ejw.136.1569501749872; Thu, 26 Sep 2019 05:42:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569501749; cv=none; d=google.com; s=arc-20160816; b=jzKCqqjqeY6CraeFMqxZXKTxgXKOfxilvkUg83O4pZAFH6OIV83wtLSFzjATdsPXPE 181JoW3eQwV2KU6Q3V9Y4N3G/kJw4JQyweBq5pR5ov8NQA1F962rwUEQeSaesU3o2HRK ulJqTyOckhk8bQUDiTTsAl51sEj8117TyWtHfpQn9ft7wVm4lpc/OuQSXcnLt2x7uvqD Ofd0Lj7GFELuyEdUEKMXJymZNHjJ7J/yQxSf/ijoAtuk2WhwBKQd9mQFQxwHINVJ6efQ kZQFgkgGXyFdVE2pyeM+iFtT6P898SMb5whNy/S2lnyN3s9EXeQjaEcPCjbRZ8D/z4PD rXaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:mime-version :message-id:date:dkim-signature; bh=letqQmLXhJ26rePJwfyNH6mOlQABi2YzpNRsxYXK53E=; b=hk+dKtX7raifJRHbi1ns0nxuoT9JO89ERcDWNvBRpMX97BbnUfT47crvyb5xDZKvbU 4ZIne0RC1TaPc1sdY94V873YI+Muh9mP+/T2tn3mHK6LXtQdpi6hQ0z7BKsfOleKytcA wWpwuWMGXlaQK7EkGNeY0kljcpqwtM1ZoMCFy1H8+PzqX3TmEYUgW8E5AHyi85LLg3wx 6We3yCk3INd8hSXIw5yyKQ6ub+eAcCjh2WuulhR5y6EqZt4x4KTCmaEphwPqeuCtd2mi TJC/jevIxWvpnTJ8xDPhi6KU1MzhKMlI80VsitD6ZI2a3gOjPen7/rHXut567qixCvgA kFLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=gmrYnfSy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u3si964516ejj.47.2019.09.26.05.42.05; Thu, 26 Sep 2019 05:42:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=gmrYnfSy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733006AbfIYXnX (ORCPT + 99 others); Wed, 25 Sep 2019 19:43:23 -0400 Received: from mail-pf1-f202.google.com ([209.85.210.202]:56606 "EHLO mail-pf1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732977AbfIYXnV (ORCPT ); Wed, 25 Sep 2019 19:43:21 -0400 Received: by mail-pf1-f202.google.com with SMTP id m25so353582pfa.23 for ; Wed, 25 Sep 2019 16:43:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=letqQmLXhJ26rePJwfyNH6mOlQABi2YzpNRsxYXK53E=; b=gmrYnfSyTw1f26hABnX/14Tb9gHphBFSw9ysWsgslFndsIS/thnap2A+ID8uNwvGyr F7l1E+w5g3Hr1Imb/26usjnR+JYI70d9JOEXVJz4ZMI/wCTVSWWtM7AXAD0TpMP+Z6XM ASQTuWmoxQxoN/2VnRYGrfqpewkdqCwkbBsmhFCWZnCbYu4jWNlMSCV+iLV8uW0Q0Lif Ik3IeqlI2VjdwTtVN60S+lOApHVsy6ljioP7tLO7E+d94Pe8dMcMQ7iCbSfTOXez8EYh ugWmWP4uscscHN/HxOLgxnwxQQKqIVsRMCdzmFiETn6bUHWpv3JptiifMAgF+TJqPenD tb4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=letqQmLXhJ26rePJwfyNH6mOlQABi2YzpNRsxYXK53E=; b=kwf/cHyZ9uC3+iiEcFtwqcdW4OYQe+H9Bt5lo7jPwJuZerkzDr9wjSPRFxnKEAfNsD sdDUqyq1T1XHxqgFt9kDrQ7t/1gsBnt3ezI1U/YEQsW2ExlmTslYEH7aZJYncveir5c8 PqEe/abv4QerCYDtwJHRMgWRMbmDFxukyFlwTDlsxzzYHAUGbwV2gBDQieYHLZy2iK58 TvMfO1W3iTQsOILeQ5R3YNbn2Cm+/4OJR2lLF0OYPgHRbF16YdkAEGycvi9jA18fOReD 94o4kRoQABdl9hPc2slKJqrkogAfx7szOXNBQM8/gbDRNDMpm26OdwIilMJvdzJieqML VC6g== X-Gm-Message-State: APjAAAVegs2tEcIVOUMZ8qH+5L0XYPQbOuWaABq5sONKqQhk/TvFiyb4 lh9efTWc0IQQi97WVB4i1rE5GLaCKhY51BIC X-Received: by 2002:a63:2104:: with SMTP id h4mr428099pgh.295.1569454998771; Wed, 25 Sep 2019 16:43:18 -0700 (PDT) Date: Wed, 25 Sep 2019 16:43:11 -0700 Message-Id: <20190925234312.94063-1-allanzhang@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.23.0.351.gc4317032e6-goog Subject: [PATCH 0/1] bpf: Fix bpf_event_output re-entry issue From: Allan Zhang To: daniel@iogearbox.net, songliubraving@fb.com, netdev@vger.kernel.org, bpf@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Allan Zhang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org BPF_PROG_TYPE_SOCK_OPS program can reenter bpf_event_output because it can be called from atomic and non-atomic contexts since we don't have bpf_prog_active to prevent it happen. This patch enables 3 level of nesting to support normal, irq and nmi context. We can easily reproduce the issue by running neper crr mode with 100 flows and 10 threads from neper client side. Allan Zhang (1): bpf: Fix bpf_event_output re-entry issue kernel/trace/bpf_trace.c | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) -- 2.23.0.351.gc4317032e6-goog