Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC PATCH] xen/gntdev: Stop abusing DT of_dma_configure API
To:     Rob Herring <robh@kernel.org>,
        Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc:     linux-kernel@vger.kernel.org, Robin Murphy <robin.murphy@arm.com>,
        Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        xen-devel@lists.xenproject.org
References: <20190925215006.12056-1-robh@kernel.org>
From:   Julien Grall <julien.grall@arm.com>
Message-ID: <e898c025-32a7-1d2c-3501-c99556f7cdd4@arm.com>
Date:   Thu, 26 Sep 2019 10:49:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190925215006.12056-1-robh@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Rob,


On 9/25/19 10:50 PM, Rob Herring wrote:
> As the comment says, this isn't a DT based device. of_dma_configure()
> is going to stop allowing a NULL DT node, so this needs to be fixed.

And this can't work on arch not selecting CONFIG_OF and can select 
CONFIG_XEN_GRANT_DMA_ALLOC.

We are lucky enough on x86 because, AFAICT, arch_setup_dma_ops is just a 
nop.

> 
> Not sure exactly what setup besides arch_setup_dma_ops is needed...

We probably want to update dma_mask, coherent_dma_mask and dma_pfn_offset.

Also, while look at of_configure_dma, I noticed that we consider the DMA 
will not be coherent for the grant-table. Oleksandr, do you know why 
they can't be coherent?

Cheers,

-- 
Julien Grall