Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp2176277ybn; Thu, 26 Sep 2019 08:06:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqx0hUTudrrGGhOXkjfF8rypLFKOQXknez8LWuwjeEpno5kykCjYRoCRCKPMjQOYgMyHIc+9 X-Received: by 2002:a05:600c:290c:: with SMTP id i12mr3562619wmd.77.1569510387005; Thu, 26 Sep 2019 08:06:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569510386; cv=none; d=google.com; s=arc-20160816; b=c+JfxwS0qUL/bOoG64zI7X3z3kbdcT7EjFL48Cyo8BtpmAVVvHDsjEJIlU6wn1c0r9 p4Dkhf2PsDWo0ymfDlZpd1VulruB+Z40LxPUTzJX0QqTSIets8Chh92PQO/EUlyAr9gw frJnxiE13V7yqSfu/7fWRfycGY02YDZBMA9E4DjXpT36BwOOZYz+vXpl5xF3r7hcIMEi bhu04jFZQs7mAylZwpnY8ReaSoLFxB+oebx8nHeSu+BZK99oqmBMIEb+CsoIS6lEwJl+ JLpGOtUpVzLQRly3uAcu4oOj+QI/4xFrFUd6d3HSKvCoJCMT9jVdQjSlw+unxXYtv120 BxZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=xtkPkpjPrpLQmsDNk7AeQ5yhyxjhIB2F104oGv/w96M=; b=eazD/eHBMNxWhyZ1Nx+eUEx8g/M9BJ/U7cUJRN3fJsGGq6GTvx0aMVwy6so4ZaR6S1 SYK0jXaWhf/Zr+ewXQHtNutBm6cxlp6Jnd/58z0qY+jhi5KY7hWpwC51SCzhD+07DbkG GfrjzcqnCKwH/ddc4HFzjt4rQTuG8A/zZy/cPysgZnKFYOjlpUjizLem0BuGEhyRejOR k/miwKWv/jLSOEvv9Gg/iru8h1bHV5FZGorKz5cj/Jrzyxu8VoUbWo3q7Q//CCBe9lvH /MSMEuout3Ru/QW/B+IJ2tgQ51ZIZaqT8nG4R0y+V8/hW1qtjD13c/KeQeE8NZieLL8G DLPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y71si1614932ede.135.2019.09.26.08.06.00; Thu, 26 Sep 2019 08:06:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727240AbfIZPBY (ORCPT + 99 others); Thu, 26 Sep 2019 11:01:24 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:36316 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725813AbfIZPBY (ORCPT ); Thu, 26 Sep 2019 11:01:24 -0400 Received: from mail-pl1-f200.google.com ([209.85.214.200]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iDVGk-0007Pv-1P for linux-kernel@vger.kernel.org; Thu, 26 Sep 2019 15:01:22 +0000 Received: by mail-pl1-f200.google.com with SMTP id p8so1650228plo.16 for ; Thu, 26 Sep 2019 08:01:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xtkPkpjPrpLQmsDNk7AeQ5yhyxjhIB2F104oGv/w96M=; b=N9dQ0UqCmLJ4ZlYM3vA/y1waFN0ymtO0z82a3KVRkpGC+RFkaDQN2g7OR5t7jTbRss Nj7hXgSIEpDYL89Kid1veQLwzoXM3aJwWmiV7BRQLACf9SRWw5V9TNBpZaVZasOcfJ9t HVV6xl8vIk+fY+8knMwfl6UNc9JCGzVQxJrLp1Jd+cZOps/3Btw77mlr9Xf6MRmuwJHs Vzo2dweyjz6AXEKvJKr3dvN7kCynA72Br/uL/gkjKYnuktA4/gv3Da4L/dtSXQhZZDyg u5zR5j3gWPS2KemcuX54DyDhQgb+sWLsoiyhZrf5k/Ddwb8Fx6a5Znre3kbU3pK2Uktw AikA== X-Gm-Message-State: APjAAAUpALxt7PNhPDZdNqeBxFhjPWSZKMV6XM7ad4eGqJBYL05nFGl4 exyrtsnIwA9AAEKjWhYvYeV10nuBsb2s2aJ+vHB6wM5/NwHCaggfl5kf18vam6Z2fTOE0Vhtxh2 UokRZXikosbKEsOOuEuv01wxUH2agJvYBQ5TXpQOjPQ== X-Received: by 2002:a63:cf0a:: with SMTP id j10mr3759963pgg.388.1569510080736; Thu, 26 Sep 2019 08:01:20 -0700 (PDT) X-Received: by 2002:a63:cf0a:: with SMTP id j10mr3759931pgg.388.1569510080411; Thu, 26 Sep 2019 08:01:20 -0700 (PDT) Received: from [192.168.0.179] (c-24-20-45-88.hsd1.or.comcast.net. [24.20.45.88]) by smtp.gmail.com with ESMTPSA id q3sm2650205pgj.54.2019.09.26.08.01.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Sep 2019 08:01:19 -0700 (PDT) Subject: Re: [PATCH] staging: rtl8188eu: fix possible null dereference To: Larry Finger , gregkh@linuxfoundation.org, straube.linux@gmail.com, devel@driverdev.osuosl.org Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20190925213215.25082-1-connor.kuehl@canonical.com> From: Connor Kuehl Message-ID: <2f07d7cb-23a1-f5c0-af9f-1c3e19a7082c@canonical.com> Date: Thu, 26 Sep 2019 08:01:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/25/19 5:05 PM, Larry Finger wrote: > This change is a good one, but why not get the same fix at line 779? Ah yes! Thanks for pointing that out. I missed that. I will send a V2 shortly. Thank you, Connor > > Larry >