Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp2412285ybn; Thu, 26 Sep 2019 11:28:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqzcMorqtJU1cbI0uhOAk4Y8aI7/ih/ThSHQFi3gNf/O3fL+adKy6ZtgQnHsebcplOZLkQU0 X-Received: by 2002:a50:c2c2:: with SMTP id u2mr186859edf.220.1569522493139; Thu, 26 Sep 2019 11:28:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569522493; cv=none; d=google.com; s=arc-20160816; b=mqiK1Gm8O2DVNmavqmY5RmNI0nxkS+K4i+rBjq0lPk08/NlKml7n6SYz5LPINNKFEc Vr1D05TSaeMl0TJz4zZxbNDQ2SFHhnSAfPSRlgzuBt2ww7iVN4U3pRiWuvC92bHOSxWj XmfYcxIUa41hzb00SZeGiyrMEtgKdciEsLGOyLD3wVFHK/AXyBvb2Lj2BNjaLKSCdSTY Dc+cbsuMGc8pnhA4h/s5nd5KLg2ftory5Nb9gQhvRy3UNjNnuAC6dkhQFSqJ5Tw02JvG xtBnSetrQu/hsudRAcrvJM0XKOu83LlPYnZzMrZrrp7Hppk5dZ5VU/WaySrBlLGpTeXM bf0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=AugkIEvD7+r+PFx4d50SUNlVbq4ALnJeABueWXjTypQ=; b=ytwZeQUI37K0yXw6SEF73tIzzEKsEF3KXm0KPrRdY76JLTJILMzVIwqE+7fGn4DIFP Hd5jwQ8wFW4B/yHL5mIhYl6NA3+NoLbZPCJsqcNeNmE+Phm/b2ZecUvxStGblm39xrtN v5wRlHiSjrbZzcg4lqupjvXlYGR98OXzpDsniTsB/BpWVGLkMUvEN4cwCUxE6DUF0D5l 40fJG/kWCn7J8Bq8DWrzm4ybVlh1+TDh1qOaZbQ5KYt35oS5jRyYfzaKa0FKkR+RPltZ CG7f4qTFxrT7LbHN21Nk0icRLfrYraiQY5gQCtFOKqUmdYIm1uWGbBL2Zs0YK7zUb9hz 30xA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=omq5DJJD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j18si1535620ejv.201.2019.09.26.11.27.48; Thu, 26 Sep 2019 11:28:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=omq5DJJD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728344AbfIZSZA (ORCPT + 99 others); Thu, 26 Sep 2019 14:25:00 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:51916 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727796AbfIZSZA (ORCPT ); Thu, 26 Sep 2019 14:25:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=AugkIEvD7+r+PFx4d50SUNlVbq4ALnJeABueWXjTypQ=; b=omq5DJJDq8oshEHinGKpmGl9v 43qb+SBkAaKuYb4Jjqppv08P5rF2yoWgxlK/11R6UGp4EUBN3ZUu/+1AlsAZNnW6a+TGMYpyDbifd FnpYGX9M/TwL9BQpq67e8gjBg4Mm8szxbXSxb4OJ1xO7TIYVB2bNwR8RPws3iW0QnrupM=; Received: from [12.157.10.118] (helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iDYRe-0004SG-6f; Thu, 26 Sep 2019 18:24:50 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 86FA7D02DD8; Thu, 26 Sep 2019 19:24:48 +0100 (BST) Date: Thu, 26 Sep 2019 11:24:48 -0700 From: Mark Brown To: Ravulapati Vishnu vardhan rao Cc: Alexander.Deucher@amd.com, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Vijendar Mukunda , Maruthi Srinivas Bayyavarapu , Colin Ian King , Dan Carpenter , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list Subject: Re: [PATCH 4/5] ASoC: amd: added pmops for pci driver Message-ID: <20190926182448.GE2036@sirena.org.uk> References: <1569539290-756-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com> <1569539290-756-4-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JTVzY7YXrWvPVXom" Content-Disposition: inline In-Reply-To: <1569539290-756-4-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com> X-Cookie: Be careful! UGLY strikes 9 out of 10! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --JTVzY7YXrWvPVXom Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 27, 2019 at 04:37:38AM +0530, Ravulapati Vishnu vardhan rao wrote: > +static int snd_acp3x_suspend(struct device *dev) > +{ > + return 0; > +} > + > +static int snd_acp3x_resume(struct device *dev) > +{ > + return 0; > +} > + > +static const struct dev_pm_ops acp3x_pm = { > + .runtime_suspend = snd_acp3x_suspend, > + .runtime_resume = snd_acp3x_resume, > + .resume = snd_acp3x_resume, > + > +}; These operations are empty so they should just be removed. --JTVzY7YXrWvPVXom Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl2NAm8ACgkQJNaLcl1U h9AjzAf/UH1pDPCNMtAFU1c75tQQ88+9u6FIttYJDSACr7DGvasiGcA09dm6+N4N +HhIH338G/hCPzq8YLpT0mRv2KPofAecLo9bpMiWTLGU3Lk8j+MNqitNZlhTf/+/ ym4qJajutTJ3uoVnruc7L5YJX8pF2TB9dIkImSd0Nt73y3OQGOUBKgmyhlo7PYuZ 4HZtnnanVCkvOyIYcQxGcFZXRWna+sH/oUnKINuxJeHgRmAG6XrHpu4y1RkYB/EN Jpvg6NyRKMJDxYGiPSX5gAzPDlVR0qMcp+UFlf7OOqQUot7zwehbxhSYUALk3y9D UqDxncXlmBrURtifJVn3J8hUPOJJxg== =Y0dc -----END PGP SIGNATURE----- --JTVzY7YXrWvPVXom--