Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190906184712.91980-1-john.stultz@linaro.org>
 <20190906184712.91980-6-john.stultz@linaro.org> <20190923221150.lolc72yvuyazqhr6@DESKTOP-E1NTVVP.localdomain>
In-Reply-To: <20190923221150.lolc72yvuyazqhr6@DESKTOP-E1NTVVP.localdomain>
From:   John Stultz <john.stultz@linaro.org>
Date:   Thu, 26 Sep 2019 14:36:33 -0700
Message-ID: <CALAqxLWyNiaf_Fxa76t9nA9Ea++O1Tcisq_XpH9e1yZJP1YujA@mail.gmail.com>
Subject: Re: [RESEND][PATCH v8 5/5] kselftests: Add dma-heap test
To:     Brian Starkey <Brian.Starkey@arm.com>
Cc:     lkml <linux-kernel@vger.kernel.org>,
        Benjamin Gaignard <benjamin.gaignard@linaro.org>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Liam Mark <lmark@codeaurora.org>,
        Pratik Patel <pratikp@codeaurora.org>,
        Vincent Donnefort <Vincent.Donnefort@arm.com>,
        Sudipto Paul <Sudipto.Paul@arm.com>,
        "Andrew F . Davis" <afd@ti.com>,
        Christoph Hellwig <hch@infradead.org>,
        Chenbo Feng <fengc@google.com>,
        Alistair Strachan <astrachan@google.com>,
        Hridya Valsaraju <hridya@google.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        nd <nd@arm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Sep 23, 2019 at 3:12 PM Brian Starkey <Brian.Starkey@arm.com> wrote:
>
> I didn't see any response about using the test harness. Did you decide
> against it?

Hey! Spent a little time looking at this bit and just wanted to reply
to this point.  So first, apologies, I think I missed the suggestion
earlier. That said, now that I've looked a little bit at the test
harness, and at least at this point it feels like it makes it harder
to reason with than standard c code.  Maybe I need to spend a bit more
time on it, but I'm a little hesitant to swap over just yet.

I'm not particularly passionate on this point, but are you?  Or was
this just a recommendation to check it out and consider it?

thanks
-john