Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp2671177ybn; Thu, 26 Sep 2019 15:51:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqx1i5SFLrd+QzuyP6HEzI0eY8XnzeKqTuROuysmvsdk2UDYlmcMSfpMBxyBpFmMdxWJI+3r X-Received: by 2002:a50:ef02:: with SMTP id m2mr1360600eds.157.1569538272145; Thu, 26 Sep 2019 15:51:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569538272; cv=none; d=google.com; s=arc-20160816; b=qa4P7TyXIdNgE/JGRlCz0GZc8ecBtbF8nJE9aDjd5MPB7owpMIAYrXvmOmqGBUQEYl 7Hx0XPwqaCT1U6F4u2UZSTVxXCQwKRV79mz7vgpDj2vvIbb/cVeBeiahD+STL6kt/CsU dcn7C8nHhaJ+7CagiGMpiR4wCW6cAz5A8mKQKWKiEIl2f+9/soKOhJL9EbQcP2ONxRdv 0heh9qYQp0n9+nUxOo4/h/6t1jvUZ0swPrfFYi21B0aKWMGAaB+f4IW2JHFfj/1fJRb+ rzROiJaP+K7Yfy8GDk3NOwsPg7RCaz7jcyZc63xXvmhKB7a4AJhUgWUFFyxBCplHcF1/ QjeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=lkqdPMP70e7GXR5MeU+HFZxi3MVOSyE19Z1KhocSsvc=; b=QL9l7ExMy0gArxZled9/tnavd/iIK7Uedk1SqRPqLWalmBxLerJyPj8tU4cspingq1 b0m5kQIOyLieLlRj5GE1ZAlVlj+77I2AQudX9S/LlvQ47+H42EpjUiKgqWLdASvGd/5d QbcvDobF5g/umIfz0eEIY1N2R/tmQKYCWkEhBzl82jHMkG9feXRgecP7bwfp40TpwCiy V0n18ztPQUR21SHoZOflO5xekoa/o7dc00YyKAojveAlXahhGFaC9p0APJdc+9KkAZ9o hvlTUc5fybrRxurVgwfjh0o2v+z3D5hDgxk91x09hi9D9JNgdQ0j1lTleEzKbK4im8D6 SwVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=j3nmnooQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x45si409597edd.388.2019.09.26.15.50.48; Thu, 26 Sep 2019 15:51:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=j3nmnooQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728336AbfIZWsf (ORCPT + 99 others); Thu, 26 Sep 2019 18:48:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:54386 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbfIZWsf (ORCPT ); Thu, 26 Sep 2019 18:48:35 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C83DB207FF; Thu, 26 Sep 2019 22:48:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569538115; bh=rZUFsoQvVrC9Thqs802fO93uxeiJR0VRRll9tLwihFU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=j3nmnooQxycEwo1uKREgSaxDhUb/HNIkhTGY2sQ9DBbbALr/wayasTfVdTMLfPqBr xFUQXgVYpYBqRie3+IFJOKiC+MZSpcTChSGyChR50ua98i+36tz12Ft0PG+95AqL0Q iYAOxcqtx8MnvSICHVl1FMyilQt03ete43r2IpLQ= Date: Thu, 26 Sep 2019 15:48:34 -0700 From: Andrew Morton To: Vitaly Wool Cc: Linux-MM , linux-kernel@vger.kernel.org, Markus Linnala , stable@kernel.org, Dan Streetman , Vlastimil Babka Subject: Re: [PATCH] z3fold: claim page in the beginning of free Message-Id: <20190926154834.132f40363f5805a7a5cb347a@linux-foundation.org> In-Reply-To: <20190926104844.4f0c6efa1366b8f5741eaba9@gmail.com> References: <20190926104844.4f0c6efa1366b8f5741eaba9@gmail.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Sep 2019 10:48:44 +0200 Vitaly Wool wrote: > There's a really hard to reproduce race in z3fold between > z3fold_free() and z3fold_reclaim_page(). z3fold_reclaim_page() > can claim the page after z3fold_free() has checked if the page > was claimed and z3fold_free() will then schedule this page for > compaction which may in turn lead to random page faults (since > that page would have been reclaimed by then). Fix that by > claiming page in the beginning of z3fold_free(). > I take it from the email headers that a Cc: was intended?