Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp2760238ybn; Thu, 26 Sep 2019 17:27:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqwkQIF+xfJvA8Ic59ZoKgfV8bPiqCabCXR+URrZNgaS8O8imDibgKcUnv/JpjJ9yUil2NoU X-Received: by 2002:aa7:d508:: with SMTP id y8mr1670531edq.171.1569544041978; Thu, 26 Sep 2019 17:27:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569544041; cv=none; d=google.com; s=arc-20160816; b=nyNeX0qzEDKu+iQV8/WHbzVPSvuC8H5S3U1ErBOnV92ZjRFxPdFmcXYMa59nIuHW51 DSbYsXgBKw/WNcCY9iINz+uDLVbXw3Bl+RvwtIRu0T2vt/nw0q4kW/0D08D09itoVqJn cxm15LUnNTh6N9qIGqeS9LYz+gtIjO2BOYsZyta72gQR1n2jEYnWNesm8UzJ/D/Szzmq 6Ie+E69bZ2iD5rycLWAMA9OzXc0Z+aXDEINEU92zpTA50EIM/IwaddjHbT8BzHA9Lu5p OYJJPuoYKgr3QlZSkxCs7HUCV8WAh4HMls71kkbC9gTBREJOBt8INVqNnbpRTuO4Do0I I8sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=MDoHopVetDd/ID0m+/zdRqZFxmnQtClQZalMwkfcSrM=; b=slMCNEhyDbsJWwcBiIIpDCL63Y98BTke1+Qqvzgk0bkaQYDhyJ3oERKSYr5rLgE0/T n2lT7McyCgeuTIrO6A8uu57KkrqX/bxS+QyOSvwDDP+2IOER+DzAxbGcgD1akvbS5GG1 dy4ijqD/zwymdgPwGUXHk8IprdQkjxlQxwfaSfcWYaDkd0LhcKW336yXt0u1xaiPmVMl zVDakZ+kYLAOF4kYQIcimgxs6Rfc1xTn77W4u9F5XKiec/ozsW58WLTKqaU1R0cyqj1h aBJMtB3ZzJvlyUH5dS4Txb4moiVpaehiJqhWG++kM7iE3O6v+Wyb6J60KjtTh0Qy4Teh R6CA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a16si2001236ejb.54.2019.09.26.17.26.53; Thu, 26 Sep 2019 17:27:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726205AbfI0AY7 (ORCPT + 99 others); Thu, 26 Sep 2019 20:24:59 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:44994 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725808AbfI0AY6 (ORCPT ); Thu, 26 Sep 2019 20:24:58 -0400 Received: by mail-ot1-f67.google.com with SMTP id 21so755165otj.11; Thu, 26 Sep 2019 17:24:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MDoHopVetDd/ID0m+/zdRqZFxmnQtClQZalMwkfcSrM=; b=esP6iMYGDGzhd2yr3ZB5vGuLw1YMlsVq+M+KKOE/U00vUN1z6C647D+txTVmJ8m6Tl +Cz9tZWKUt6Qd1+2bW4FTsk7khk9a5UjnyE1n/Dju3U06iaSUfMUahy2NgJfpb/fRC+k kpyfGIZw8eiYdI25RuFUwEJn+bn/TLpRVovCLbcwfqRV3I3uT9A5Ch0o4Vm+eqMFEcSv yxfDBGvJFirA6iGM9TspT4+9FeFYbIXVb40EiDgPZJf6C2mrzhEAvqD5fQSQ0Pg8rdnI h8mO53yppJoWUpLr+JnSV79JRkCoZsNbLQPmLtD44JhL/267OrDg9XgZVg0x4Xlz4PHk f32Q== X-Gm-Message-State: APjAAAWL0bHNftWvPDv0Orl5A9XpvfIy2xYC0O2OvIIan4jbu4kReVEP iUlxH36dgO1wbAsnrXai0VJlu5Y= X-Received: by 2002:a9d:3e52:: with SMTP id h18mr1048250otg.275.1569543897338; Thu, 26 Sep 2019 17:24:57 -0700 (PDT) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id j11sm339866otk.80.2019.09.26.17.24.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2019 17:24:56 -0700 (PDT) From: Rob Herring To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Robin Murphy , Florian Fainelli , Stefan Wahren , Frank Rowand , Arnd Bergmann , Marek Vasut , Geert Uytterhoeven , Simon Horman , Lorenzo Pieralisi , Oza Pawandeep Subject: [PATCH 00/11] of: dma-ranges fixes and improvements Date: Thu, 26 Sep 2019 19:24:44 -0500 Message-Id: <20190927002455.13169-1-robh@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series fixes several issues related to 'dma-ranges'. Primarily, 'dma-ranges' in a PCI bridge node does correctly set dma masks for PCI devices not described in the DT. A common case needing dma-ranges is a 32-bit PCIe bridge on a 64-bit system. This affects several platforms including Broadcom, NXP, Renesas, and Arm Juno. There's been several attempts to fix these issues, most recently earlier this week[1]. In the process, I found several bugs in the address translation. It appears that things have happened to work as various DTs happen to use 1:1 addresses. First 3 patches are just some clean-up. The 4th patch adds a unittest exhibiting the issues. Patches 5-9 rework how of_dma_configure() works making it work on either a struct device child node or a struct device_node parent node so that it works on bus leaf nodes like PCI bridges. Patches 10 and 11 fix 2 issues with address translation for dma-ranges. My testing on this has been with QEMU virt machine hacked up to set PCI dma-ranges and the unittest. Nicolas reports this series resolves the issues on Rpi4 and NXP Layerscape platforms. Rob [1] https://lore.kernel.org/linux-arm-kernel/20190924181244.7159-1-nsaenzjulienne@suse.de/ Rob Herring (5): of: Remove unused of_find_matching_node_by_address() of: Make of_dma_get_range() private of/unittest: Add dma-ranges address translation tests of/address: Translate 'dma-ranges' for parent nodes missing 'dma-ranges' of/address: Fix of_pci_range_parser_one translation of DMA addresses Robin Murphy (6): of: address: Report of_dma_get_range() errors meaningfully of: Ratify of_dma_configure() interface of/address: Introduce of_get_next_dma_parent() helper of: address: Follow DMA parent for "dma-coherent" of: Factor out #{addr,size}-cells parsing of: Make of_dma_get_range() work on bus nodes drivers/of/address.c | 83 +++++++++---------- drivers/of/base.c | 32 ++++--- drivers/of/device.c | 12 ++- drivers/of/of_private.h | 14 ++++ drivers/of/unittest-data/testcases.dts | 1 + drivers/of/unittest-data/tests-address.dtsi | 48 +++++++++++ drivers/of/unittest.c | 92 +++++++++++++++++++++ include/linux/of_address.h | 21 +---- include/linux/of_device.h | 4 +- 9 files changed, 227 insertions(+), 80 deletions(-) create mode 100644 drivers/of/unittest-data/tests-address.dtsi -- 2.20.1