Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp2834873ybn; Thu, 26 Sep 2019 18:52:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqzrOJ7CVq351aNJiZnTPlMVkWloNbrTbmepp0i2a4INj+w78aRA2qblj0KD3Bci3JQrXFw5 X-Received: by 2002:a17:906:b84d:: with SMTP id ga13mr5201610ejb.236.1569549143512; Thu, 26 Sep 2019 18:52:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569549143; cv=none; d=google.com; s=arc-20160816; b=rGyi7UkfEHSweKq76NlcqtiDh8+njq2TqvOnDsk40FJyFEl0qucbqPjTNAFL+DSk0N Y2DbgZQZmZFs7c4/F+WiGAGnUxJbkhRToMeKBjjrK5R6fw9+jbFu7cfbE4JGFVCi5owk muSR6I9v7kVdLgbcUpSVHfWUlHiNNgHrXNCsfbG2vZxtyt63Wf46fYjvnHi9dxOCQiS/ NUSEeIqx0UaPoY7WcVXtdnjv+66qKGX2Re5jpMgVbD0YNvdg5uIC8yo+NwqaidMAgRtz tK2zmtAOq40ircGOuK/KGrj6sU3vNR6l2MfzO/ZQqgme63k30x4fDRUjd0uV0stDM/Z/ zXdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:to:from; bh=n3VsU1aBN2cfEJJpHMaELkGxoJWaJdn9iiz7yJFQ1jc=; b=Vr6jWbqmmvaMCU8VVyM2G6tb9jlKOEJCeOWpUcrptVrPbdeLvIeKc8egcL34KU5Nt7 f3JOtzWz7Ly+8cE5OQUMY5YJV1SdttqND8jKRm3M50agzthKK8lJcPDiBaGMdfnVFhsL 7pPhqbhBP4JRkauUNRelqkHveNhXFdMIfGQu71las9MYVMF6x6yFsgUmE+JbPwGVjpbs sCjO2CXcjRU8dgLVkvDhowszVBg//YXaGZsF8fhoDUYmx7qN1FjWwgTTuEpMIxUwlbwP IThDUaEaL2DfLneYO54V1NARO3OP98eDmz+uOoyor2yazALaQINY+NhI+uwlVRoyRc7Z 3UNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gl26si2034069ejb.17.2019.09.26.18.51.59; Thu, 26 Sep 2019 18:52:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728339AbfI0BsU (ORCPT + 99 others); Thu, 26 Sep 2019 21:48:20 -0400 Received: from inva020.nxp.com ([92.121.34.13]:51024 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbfI0BsG (ORCPT ); Thu, 26 Sep 2019 21:48:06 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 943BB1A0AB1; Fri, 27 Sep 2019 03:48:04 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 22ED21A02F3; Fri, 27 Sep 2019 03:47:58 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 0A8EF402EE; Fri, 27 Sep 2019 09:47:49 +0800 (SGT) From: Shengjiu Wang To: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, lars@metafoo.de Subject: [PATCH V6 2/4] ASoC: fsl_asrc: update supported sample format Date: Fri, 27 Sep 2019 09:46:10 +0800 Message-Id: <45a7c383f43cc1dd9d0934846447aee653278c03.1569493933.git.shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ASRC support 24bit/16bit/8bit input width, which is data width, not slot width. For the S20_3LE format, the data with is 20bit, slot width is 24bit, if we set ASRMCR1n.IWD to be 24bits, the result is the volume is lower than expected, it likes 24bit data right shift 4 bits So replace S20_3LE with S24_3LE in supported list and add S8 format in TX supported list Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen --- sound/soc/fsl/fsl_asrc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index 4d3804a1ea55..584badf956d2 100644 --- a/sound/soc/fsl/fsl_asrc.c +++ b/sound/soc/fsl/fsl_asrc.c @@ -624,7 +624,7 @@ static int fsl_asrc_dai_probe(struct snd_soc_dai *dai) #define FSL_ASRC_FORMATS (SNDRV_PCM_FMTBIT_S24_LE | \ SNDRV_PCM_FMTBIT_S16_LE | \ - SNDRV_PCM_FMTBIT_S20_3LE) + SNDRV_PCM_FMTBIT_S24_3LE) static struct snd_soc_dai_driver fsl_asrc_dai = { .probe = fsl_asrc_dai_probe, @@ -635,7 +635,8 @@ static struct snd_soc_dai_driver fsl_asrc_dai = { .rate_min = 5512, .rate_max = 192000, .rates = SNDRV_PCM_RATE_KNOT, - .formats = FSL_ASRC_FORMATS, + .formats = FSL_ASRC_FORMATS | + SNDRV_PCM_FMTBIT_S8, }, .capture = { .stream_name = "ASRC-Capture", -- 2.21.0