Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1547100464-7020-1-git-send-email-rayagonda.kokatanur@broadcom.com>
 <3d5497d8-7275-1461-8b59-b3695838be45@broadcom.com>
In-Reply-To: <3d5497d8-7275-1461-8b59-b3695838be45@broadcom.com>
From:   Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Date:   Fri, 27 Sep 2019 09:38:12 +0530
Message-ID: <CAHO=5PE_Y2sx1pVnG79_JD_AFU8Vtu+e6PfCnBZDVLAcms64ug@mail.gmail.com>
Subject: Re: [PATCH] dmaengine: bcm-sba-raid: Handle mbox_request_channel failure
To:     Vinod Koul <vinod.koul@intel.com>
Cc:     Dan Williams <dan.j.williams@intel.com>, dmaengine@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
        Ray Jui <ray.jui@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Vinod,

Did you get chance to review this fix?

Best regards,
Rayagonda


On Thu, Jan 10, 2019 at 11:06 PM Ray Jui <ray.jui@broadcom.com> wrote:
>
>
>
> On 1/9/2019 10:07 PM, Rayagonda Kokatanur wrote:
> > Fix kernel NULL pointer dereference error when mbox_request_channel()
> > fails to allocate channel.
> >
> > Fixes: 4e9f8187aecb ("dmaengine: bcm-sba-raid: Use only single mailbox channel")
> > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> > ---
> >  drivers/dma/bcm-sba-raid.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
> > index 72878ac5c78d..77ae74663a45 100644
> > --- a/drivers/dma/bcm-sba-raid.c
> > +++ b/drivers/dma/bcm-sba-raid.c
> > @@ -1690,7 +1690,7 @@ static int sba_probe(struct platform_device *pdev)
> >       sba->mchan = mbox_request_channel(&sba->client, 0);
> >       if (IS_ERR(sba->mchan)) {
> >               ret = PTR_ERR(sba->mchan);
> > -             goto fail_free_mchan;
> > +             goto fail_exit;
> >       }
> >
> >       /* Find-out underlying mailbox device */
> > @@ -1747,6 +1747,7 @@ static int sba_probe(struct platform_device *pdev)
> >       sba_freeup_channel_resources(sba);
> >  fail_free_mchan:
> >       mbox_free_channel(sba->mchan);
> > +fail_exit:
> >       return ret;
> >  }
> >
> >
>
> Looks good to me.
>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>