Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp3088416ybn; Fri, 27 Sep 2019 00:32:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqw5nO7sSDXWfh62LzOpBUngzGA2p3x41lHIq3SSqXixv6rwuqV24iv4vTxGaJwlR6NS9/bo X-Received: by 2002:a17:906:b6d5:: with SMTP id ec21mr6333830ejb.33.1569569541772; Fri, 27 Sep 2019 00:32:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569569541; cv=none; d=google.com; s=arc-20160816; b=Xvt4wTDHrm77UDu7AP7H5rntQL9QUk5snnSmeqNX1TI+XiC2FHX09UIfpO+5ltDoWx apQXhePkFDsWM0ebHZ8Zmx2trkhJecL4zTWKhX4WcoYXfyOvD7AylR5GKbRV4ybK+COI fvU6pd3AzqIoTd9O8C+7bfcHenhLXSdnTfR0NmxBdh72eA5rfqQyyCyDuKnODiqPwvwi KMxqJfQejOKCZEp5wjbwlivqqXKKkDNbiDAPS4fX74ExmIN8gzx8noX9zyr5E6iusalu MnA3E7rxDdk6ghwOLQU00FhG3n7Tp2eA5Kf3bGCFKrM94tvSeOoaTIOPJO7uXlqetU4m uWqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=yJZSaVSFe7VnNur8yANWzcRX8kxeGCXoWNSmokmstpo=; b=LO2zBuJI1J3WSco+V9l7VJeJ1lVKFb/Zj3Hy865FJ4T/wwbtl1HJbx1XR9PXWk5cS/ Q9npbWIKOkYRkYgyi8HpwEn11wLvWhNqZWECvjFV/F54mk8QL7vq+kH9JIelzHNFmQHo S9YaA9MxQg9WbhO2j+mR2yCM1wqwV2e9xqvGsGkM8TYwMz3RzvkbTVfO4I6IWgsdsSy8 DgGXL2xIsPqmxM8dsp8mPK2woClSMj2vuqzaO1i8TMbmyTcPizJoqbAFnbpujZrl3Z6W PQy1TNOm8iPRFzznqHkz7FfJzBn+1ojwIteCz7t8K68f/7/S9334NI+mReorb25Qx2IL QrhA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h26si1837290ejx.177.2019.09.27.00.31.56; Fri, 27 Sep 2019 00:32:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726396AbfI0HbO (ORCPT + 99 others); Fri, 27 Sep 2019 03:31:14 -0400 Received: from mail.monom.org ([188.138.9.77]:57162 "EHLO mail.monom.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725842AbfI0HbN (ORCPT ); Fri, 27 Sep 2019 03:31:13 -0400 Received: from mail.monom.org (localhost [127.0.0.1]) by filter.mynetwork.local (Postfix) with ESMTP id 0C383500587; Fri, 27 Sep 2019 09:31:12 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.monom.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (b9168f76.cgn.dg-w.de [185.22.143.118]) by mail.monom.org (Postfix) with ESMTPSA id D5EBC500483; Fri, 27 Sep 2019 09:31:11 +0200 (CEST) Date: Fri, 27 Sep 2019 09:31:11 +0200 From: Daniel Wagner To: Bart Van Assche Cc: qla2xxx-upstream@qlogic.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry() Message-ID: <20190927073111.jm3jjmm5gcr6ylc7@beryllium.lan> References: <20190926074637.77721-1-dwagner@suse.de> <5d5931ef-7ffa-3f3f-bb5e-5379c1716d04@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d5931ef-7ffa-3f3f-bb5e-5379c1716d04@acm.org> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > Should the following be added? > > Fixes: 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not > called from the completion path") Good point. Just send out and updated version > Anyway: > > Reviewed-by: Bart Van Assche Thanks! Daniel