Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
From:   "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
To:     Navid Emamdoost <navid.emamdoost@gmail.com>
CC:     David Airlie <airlied@linux.ie>, "kjlu@umn.edu" <kjlu@umn.edu>,
        Liviu Dudau <Liviu.Dudau@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "emamd001@umn.edu" <emamd001@umn.edu>,
        "smccaman@umn.edu" <smccaman@umn.edu>, nd <nd@arm.com>
Subject: Re: drm/komeda: prevent memory leak in komeda_wb_connector_add
Thread-Topic: drm/komeda: prevent memory leak in komeda_wb_connector_add
Thread-Index: AQHVdQrQ/2qKdtcMBE6ojSvUeSYtTg==
Date:   Fri, 27 Sep 2019 08:08:59 +0000
Message-ID: <20190927080852.GA25223@jamwan02-TSP300>
References: <20190925043031.32308-1-navid.emamdoost@gmail.com>
In-Reply-To: <20190925043031.32308-1-navid.emamdoost@gmail.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mutt/1.10.1 (2018-07-13)
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: dbaf78b7-5b03-4a1e-f992-08d74321f8d1
X-MS-Office365-Filtering-HT: Tenant
X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:VE1PR08MB5087;
X-MS-TrafficTypeDiagnostic: VE1PR08MB5087:|VE1PR08MB5087:|HE1PR0802MB2571:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <HE1PR0802MB257109EA29CD21DF6239CB07B3810@HE1PR0802MB2571.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:7691;OLM:7691;
x-forefront-prvs: 0173C6D4D5
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(7916004)(39860400002)(366004)(136003)(346002)(396003)(376002)(189003)(199004)(446003)(5660300002)(66476007)(478600001)(54906003)(58126008)(316002)(66556008)(81166006)(99286004)(66446008)(55236004)(64756008)(8936002)(81156014)(52116002)(2906002)(102836004)(229853002)(3846002)(6116002)(33716001)(14444005)(6916009)(66946007)(76176011)(25786009)(6506007)(386003)(256004)(26005)(186003)(33656002)(6512007)(8676002)(1076003)(9686003)(4326008)(486006)(6436002)(305945005)(86362001)(476003)(7736002)(6246003)(6486002)(71190400001)(71200400001)(66066001)(11346002)(14454004);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB5087;H:VE1PR08MB5006.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Message-Info-Original: mplRSBmQFRWDuSkEPtLpJhO/VBH6IFdZ77khwvSrDARPfa4m4Db6srWxRb+16mkzFWbBMrV6BJWYbwc5rglrJuOqN+fLHixXWZ+tUcOunJ3fl8cib+Yqnw9Feo/Np0CBupi0qvEGrT9lUQ1uXMoE82C0uJ8kxNz2AIH9jEVW6iahBJ64dRJYq+sAnOjuIb010Giq+ScoHDjs3GBz8wRYGr0ltPQlIZrenCLK683vgUOYZML3xxWbBJhHF3r2AABfzy8vdLxlc80TSDGaPJGk92VU9++Uxsns804v3hqxuc7ZSQ7t0lr0eZf5rNkFkTE+5uSNBwYX8+9Bp6ArwMAxamH/FoaWIVvtPZkCaBRNBxCddMKAtxqSNrHVdGJsCekWCTn0wK6Op5FgMD468BSWPrDRBzBXTgIgTDiq3HOzpH8=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9AB2ADE2338123448D05C93BCCB5DEE1@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5087
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(7916004)(39860400002)(396003)(346002)(376002)(136003)(189003)(199004)(99286004)(3846002)(5660300002)(6116002)(76176011)(386003)(1076003)(486006)(63350400001)(47776003)(446003)(126002)(336012)(11346002)(476003)(8936002)(316002)(26005)(36906005)(54906003)(8676002)(81166006)(81156014)(33716001)(6506007)(186003)(356004)(102836004)(14444005)(14454004)(229853002)(478600001)(70586007)(25786009)(86362001)(6862004)(8746002)(97756001)(58126008)(9686003)(33656002)(6486002)(6512007)(22756006)(76130400001)(2906002)(46406003)(26826003)(6246003)(70206006)(305945005)(4326008)(23726003)(66066001)(7736002)(50466002);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0802MB2571;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 75b8f8f1-0c86-4df0-e09a-08d74321f35e
X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(710020)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:HE1PR0802MB2571;
NoDisclaimer: True
X-Forefront-PRVS: 0173C6D4D5
X-Microsoft-Antispam-Message-Info: g/OY7NAwAQhSv4KImXkvLNHhSPZR/5gsXZe0dgKFskf8TU7ZuUeMJMFHSpEMhrD4DEjGlQ/yXtLWwTit+KkfPavZe3MHpcv6rfOs4sZpB4CPOEoRSD3McfYJLoqqvpQQc1A7J45Smbh8eMHUJ8kQWquFXFe22fUthFquyzJZnlgmLR4hIyV7Ty5nSLV/YEF4TWmgRiaPewojmsEo1pOVwwnTIGu/GEc9fgIDo3jDtbV0d3GikjfqqtnJU+n/iF6TwILyy4iTHcF3uVNPcj5gu3H8LwPwLZyIXjSuJANh3VqgzgNpwS8XwLlrqs1uBZx5HnS8/U+I6sAZ0qD5QhRTQ6p5HKTRmBjBb92es0NmssH0UuqcLJyHmXqHHky9rXC6+jLJDqUVolYOmYb0MMU9DQh05dzZNJTwt8Thf2HsJek=
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2019 08:09:08.2565
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: dbaf78b7-5b03-4a1e-f992-08d74321f8d1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2571
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 24, 2019 at 11:30:30PM -0500, Navid Emamdoost wrote:
> In komeda_wb_connector_add if drm_writeback_connector_init fails the
> allocated memory for kwb_conn should be released.
>=20
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/d=
rivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> index 2851cac94d86..75133f967fdb 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> @@ -166,8 +166,10 @@ static int komeda_wb_connector_add(struct komeda_kms=
_dev *kms,
>  					   &komeda_wb_encoder_helper_funcs,
>  					   formats, n_formats);
>  	komeda_put_fourcc_list(formats);
> -	if (err)
> +	if (err) {
> +		kfree(kwb_conn);
>  		return err;
> +	}

Thank you for the fix.

Will push it to drm-misc-fixes

Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.co=
m>

> =20
>  	drm_connector_helper_add(&wb_conn->base, &komeda_wb_conn_helper_funcs);
> =20