Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp3405438ybn; Fri, 27 Sep 2019 06:01:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqwqZ2hsZTj0gS+UmQEZA1sqvJtyFAd/0pEkeks0cUBJ9Kjix5a//M6L1o7A2qXwzSA8l9b8 X-Received: by 2002:ac2:47f8:: with SMTP id b24mr2783095lfp.134.1569589298728; Fri, 27 Sep 2019 06:01:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569589298; cv=none; d=google.com; s=arc-20160816; b=kCVUKox+vujM2v//LJoCfZHAt9sfP2o9WnREEydrytRPAM0sb5FBNLT1bahrWdl3PU ANStM/BVDpvn5YihD17cQ0byY1AOFMwRcdpjQL2VM65gdZwazx7+PKOhT8NwaWOTJ1DV mpBDxkFRyuHCoA5cJKnadPFMXn8QIxMuNjTFufaXUDDqJEvTueQeYgVET1D3Z/iTiDPF HWa58YKPTnx3/G5dwcMHQRDGdFwHWZeke2ForcX8RtnZ+neffoUn4t3dWuOy3H97q74S Zj0XjApNg5L21+AQLZ4YvjEvesL5v2DQSKUOYlD5ACrZfzdIx47VGIPE8+/bo6/1YRti KJ3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:message-id:subject:cc:to:from:date :dkim-signature; bh=SAuWQlcPcP/+t3peTIA6Zu0xhHezRgMop9OmrZRClOI=; b=Zk9CrlgyLel7vawezIXBbCpV3wRW5wEddHhxI/9P7lQB1LwfLHdYueIjsHEwMjm8z7 KXwiDKRioO4D47JYQnoez6zuEfcXRs0T5n2jpbFShzYJUM1TJ0lQPL1udIJPyD9w4U7q hYTO+6A7jFm/0hpJnMFkR/g+T2gUp6AajFftQC9cBtGXP5iNDCGGxBjv0+jrOdhzu/Le PbbQm5UvqTD+8Ide2X4JVfb2VVInnE2c0Ap6Yoh1c1ZmN6PLAS7hzb8r/3570gQko3/I G5wKrrTyzba1zgwmx1Ru5fE5HGGVIiHVWFMnQzEYMQmrrJ8D1WIx4n830VbQjMGwPk3U U0IQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KLGDBjTb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e22si2807622ejm.72.2019.09.27.06.01.13; Fri, 27 Sep 2019 06:01:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KLGDBjTb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727343AbfI0NA2 (ORCPT + 99 others); Fri, 27 Sep 2019 09:00:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:60568 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727076AbfI0NA2 (ORCPT ); Fri, 27 Sep 2019 09:00:28 -0400 Received: from localhost (173-25-179-30.client.mchsi.com [173.25.179.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1986217D9; Fri, 27 Sep 2019 13:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569589227; bh=ZRR5GpkwR6Aa/fDKrENAmahjuJ9MmYU6dJrGLK0V3IM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=KLGDBjTbXzad8oglmmKMJkBY3QdwZGNWEqTeYBha0ElHoxMTT2hrgqjCgjoXZxZNm 9OEB/HIJx2kyrPpqOTpDvWxP/FHkmbzA5zVt3lgky1adf7UXlzw+kdURO8B0TeJqAo 4q3SUtGL9Ed/I+iD/QrosE2eIpzuZ9UbjCd+0zPQ= Date: Fri, 27 Sep 2019 08:00:26 -0500 From: Bjorn Helgaas To: tiantao6 Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH] PCI: vc: fix warning: no previous prototype Message-ID: <20190927130026.GA40841@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1568205651-60209-1-git-send-email-tiantao6@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 11, 2019 at 08:40:51PM +0800, tiantao6 wrote: > From: tiantao > > drivers/pci/vc.c:351:5: warning: no previous prototype for > pci_save_vc_state [-Wmissing-prototypes] > int pci_save_vc_state(struct pci_dev *dev) > > drivers/pci/vc.c:388:6: warning: no previous prototype for > pci_restore_vc_state [-Wmissing-prototypes] > void pci_restore_vc_state(struct pci_dev *dev) > > drivers/pci/vc.c:412:6: warning: no previous prototype for > pci_allocate_vc_save_buffers [-Wmissing-prototypes] > void pci_allocate_vc_save_buffers(struct pci_dev *dev) > > Signed-off-by: Tian Tao Thanks, this was fixed incidentally by ca78410403dd ("PCI: Get rid of dev->has_secondary_link flag"). > --- > drivers/pci/vc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/vc.c b/drivers/pci/vc.c > index b39e854..111f6d3 100644 > --- a/drivers/pci/vc.c > +++ b/drivers/pci/vc.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include "pci.h" > > /** > * pci_vc_save_restore_dwords - Save or restore a series of dwords > -- > 2.7.4 >