Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp3480537ybn; Fri, 27 Sep 2019 07:02:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqzbqZZQVF36zwtz9+z2vHtALBufHBV8SsSJuEW3BFNfxgagbIBO7H7hgL/kd6S0fVpfHTdW X-Received: by 2002:a17:906:c72d:: with SMTP id fj13mr8192292ejb.36.1569592949781; Fri, 27 Sep 2019 07:02:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569592949; cv=none; d=google.com; s=arc-20160816; b=EIZB6mODhDT2rxZgKAhC8vfqzPoi2sxmFcfH83P3xib1XteJzBzy60dJE0to47xJP5 RnrauiXGxHT6TboxB6/vSwpE5iYnNKkhByzWt9aUU7WX6TFXj76n0cL1qEu2SQJHXQf4 sYXfhEMqbhfcQZSBWgNm3jVWtDR4IQmgXikft1dkPw5FfKt4TIb424dfNtRjp2Mqoil+ eZyOZDnxjgAZfg4Izhit/KCuErjesDJz495RFt0ftfrZPXPo7US3ocajCbhvK4TsarI4 sJZzLV5XDmsRFvpXgMU883UDtaHV3fmcbBipuQeA+8t5G5dB+3i8NvBR3McogQaUZAzu d+nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:in-reply-to :subject:cc:to:from:user-agent:references:dkim-signature; bh=RKXGJO67bSVwcMxapZtp3HQ/bxJlidvJPusHAL8DCEE=; b=JvDZ0wKcJFzE4OvPCALJ3IYAv6mdXyFXRM6pzWgIZkNYPfQMJsVBfS9q+4xGw7Vg7f /LqKofNzKPLQF1l2WEAW+uuBM1W7VF9MJPT3sWSzQoN7afh7e33Dd6jcP22Pzm2PlsU+ ZLV44T0nN9toE1+xsv6vGoXQkj7OeRCGO9fSPsuu3EpLrANfRv9y9b7c5m7WiM8TuCvN gZzAP2kYWOp+xELpRk23qgqCOw9wmVw6JsEaldoUqZm5UrWUSfRb6eob1g18lrzHEuPI 9RG6hc5cVwQatlZW8FlnwUSAiB/PvVgQhftw4/qLoVlrjsFO+IhaCMya8Fn3W0ihTUgR 525A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=QwhnczTv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8si1613966edd.355.2019.09.27.07.02.03; Fri, 27 Sep 2019 07:02:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=QwhnczTv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727334AbfI0OBq (ORCPT + 99 others); Fri, 27 Sep 2019 10:01:46 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:36787 "EHLO mail-wr1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726843AbfI0OBq (ORCPT ); Fri, 27 Sep 2019 10:01:46 -0400 Received: by mail-wr1-f43.google.com with SMTP id y19so2893096wrd.3 for ; Fri, 27 Sep 2019 07:01:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=RKXGJO67bSVwcMxapZtp3HQ/bxJlidvJPusHAL8DCEE=; b=QwhnczTvZSqyKTVGhoX1/k1O5JUcXrinwvEVzw/2GMgtscxYn2JQt+cGP8Y/nPnben Kx2+3Klv2P28K2aOxrY/0eRB2f5cU9PyoIlwiyjwYE6C1xryj4SNW5marQTWm6VzUGhh w0innW9sm1+Zk4kJlhf+Emm/+95/3hyFVnnxvzewx+UvSwA35qpjwyxBU32dYs6dZ/jQ eGEwyNz++7qiZYmA+uYRyv4jnrPCgSZ8F5yZr0FcnUJr4bjo4uAREFH3G4cdK+frUjnG 48EV8cVtDuYd09+Qk/tnwG3BrPSv+wlJbNh/BWXPqcoSUEwndWxTf69UZjKcWpsK5NTa q8wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=RKXGJO67bSVwcMxapZtp3HQ/bxJlidvJPusHAL8DCEE=; b=f6dK5ILjZUhb/s28G2d+UJv4gIquvaTPQneJOeAxoho9BC4xBxnfaTrYpAjc/mGu+k 25v84SkgWMFo4tv8/7sGzNYI1CdrHcjeHsyaEP+qHPixgRsiXsveUaeG6BGaDUuaiNv4 YrG9KkULCwZKadTVsd+Q0ySgb8RTS1EnYkk8bNdGha0k99tpkjXj6BG8fVL0CAivFhwO JyTx/F+2tpQIx/fVtCl0zC9qXucXrqCG7KYkkUSOOPxe9WxDSDG1ZQSLvX/PcSEOpjFI xGdrx2bUJVj9TxVpyUFShaVn4fp+z1hF+bjGFeJt0W1oWNeos0Gc7FYj8J8N5WBx67CC gqLA== X-Gm-Message-State: APjAAAXG9D2zspIdsmjDZNpUx8v8Ukf5lQkb5I7IhE4zPDOr91flPk1G 1+uir4onHAnA2Az6uJKIiG/WAg== X-Received: by 2002:a5d:4f04:: with SMTP id c4mr2443279wru.98.1569592904391; Fri, 27 Sep 2019 07:01:44 -0700 (PDT) Received: from localhost (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id f10sm4276096wml.4.2019.09.27.07.01.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Sep 2019 07:01:43 -0700 (PDT) References: <20190924153356.24103-1-jbrunet@baylibre.com> <20190924153356.24103-8-jbrunet@baylibre.com> <22415bc6-2550-d927-93e0-88f6aa2bee9d@baylibre.com> User-agent: mu4e 1.3.3; emacs 26.2 From: Jerome Brunet To: Neil Armstrong Cc: Jerome Brunet , Kevin Hilman , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] clk: meson: axg_audio: add sm1 support In-reply-to: <22415bc6-2550-d927-93e0-88f6aa2bee9d@baylibre.com> Date: Fri, 27 Sep 2019 16:01:42 +0200 Message-ID: <1jftkh25yx.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 27 Sep 2019 at 11:36, Neil Armstrong wrote: >> >> static struct clk_regmap spdifout_clk_sel = >> AUD_MST_MCLK_MUX(spdifout_clk, AUDIO_CLK_SPDIFOUT_CTRL); >> @@ -502,7 +522,6 @@ static struct clk_regmap tdmout_c_lrclk = >> AUD_TDM_LRLCK(out_c, AUDIO_CLK_TDMOUT_C_CTRL); >> >> /* AXG/G12A Clocks */ >> - > > Spurious line remove Oops, I'll migrate that to the appropriate change, Thx > >> static struct clk_hw axg_aud_top = { >> .init = &(struct clk_init_data) { >> /* Provide aud_top signal name on axg and g12a */ >> @@ -573,7 +592,185 @@ static struct clk_regmap g12a_tdm_sclk_pad_2 = AUD_TDM_PAD_CTRL( > > Small nit, but: > Reviewed-by: Neil Armstrong