Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Sverdlin, Alexander (Nokia - DE/Ulm)" <alexander.sverdlin@nokia.com>
To:     Marc Zyngier <maz@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Grant Likely <grant.likely@secretlab.ca>
CC:     "Sverdlin, Alexander (Nokia - DE/Ulm)" <alexander.sverdlin@nokia.com>,
        Mark Brown <broonie@kernel.org>,
        Jon Hunter <jonathanh@nvidia.com>,
        "Glavinic-Pecotic, Matija (EXT - DE/Ulm)" 
        <matija.glavinic-pecotic.ext@nokia.com>,
        "Adamski, Krzysztof (Nokia - PL/Wroclaw)" 
        <krzysztof.adamski@nokia.com>,
        "Bachorski, Tomasz (Nokia - PL/Wroclaw)" <tomasz.bachorski@nokia.com>,
        "Kosnikowski, Wojciech (Nokia - PL/Wroclaw)" 
        <wojciech.kosnikowski@nokia.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: [PATCH v2 2/3] genirq/irqdomain: Re-check mapping after associate in
 irq_create_mapping()
Thread-Topic: [PATCH v2 2/3] genirq/irqdomain: Re-check mapping after
 associate in irq_create_mapping()
Thread-Index: AQHVdURWbbMnVh4mSE22zcVCt2yGKQ==
Date:   Fri, 27 Sep 2019 15:00:44 +0000
Message-ID: <20190927150025.26481-3-alexander.sverdlin@nokia.com>
References: <20190927150025.26481-1-alexander.sverdlin@nokia.com>
In-Reply-To: <20190927150025.26481-1-alexander.sverdlin@nokia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 51c664f0-e556-4fe9-8e6b-08d7435b7911
x-ms-office365-filtering-ht: Tenant
x-ms-traffictypediagnostic: AM6PR0702MB3749:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <AM6PR0702MB3749BE77089707CE5029B34B88810@AM6PR0702MB3749.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-forefront-prvs: 0173C6D4D5
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(199004)(189003)(2616005)(2906002)(6436002)(71190400001)(446003)(71200400001)(50226002)(7736002)(6512007)(4326008)(14454004)(478600001)(52116002)(6486002)(25786009)(76176011)(305945005)(66066001)(102836004)(3846002)(386003)(81156014)(256004)(6116002)(186003)(486006)(8936002)(86362001)(8676002)(99286004)(316002)(81166006)(66556008)(5660300002)(66946007)(6506007)(1076003)(66476007)(36756003)(66446008)(110136005)(54906003)(26005)(11346002)(2501003)(64756008)(476003);DIR:OUT;SFP:1102;SCL:1;SRVR:AM6PR0702MB3749;H:AM6PR0702MB3527.eurprd07.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: nokia.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: iNpc4zovw+vbw9UvyaMVqNLAdv9DSOUz1D1hvEQRcd7am8bsgJ0alEXQmlDXmnNP1wQ3atbOgdZ+DWqhJJJ+pF4awhTXP0ceiN7LxJyTFgHkiKV7EBUqSSyjn9eJgQSvSx0BbQyhRA1vWroFjbcSuJ1Yw6qTddH+zzRCqIstKIMsPbjStWY6rG8DE9CoiFpQT+aUBNdGxvgsJHp+mXUqbaOB8NvrQIDCmkSw0axbYjScF/gTT/JFX0KQSzMm2ObzZF9QKHQADZD/pO+SJ6cekEKb6qN7eOJHAhFNRJVfIQ1ArmafAEKjsK3y30Ys+UKJ9MUgaUdEf5R3bi3Gbzb/7UUSUqsxP9ODLh+WmtB7wA3PdfJwBvrTwZBuc4a1wbAavcpw4ubRuqyOCoX7p9y8ZOKlShx06RpspqwIWXf9zJw=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51c664f0-e556-4fe9-8e6b-08d7435b7911
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2019 15:00:45.0032
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jVGVFc6M6QtYg0d6ASiAydFyPakely4Az2F2RSLmfAxVfJ4ogGot1LmfpfKwE3dwEOOtW1mcM8AyGirO8lSM67aJYHswiOoMhCQphon+VqU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0702MB3749
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Alexander Sverdlin <alexander.sverdlin@nokia.com>

If two irq_create_mapping() calls perform a mapping of the same hwirq on
two CPU cores in parallel they both will get 0 from irq_find_mapping(),
both will allocate unique virq using irq_domain_alloc_descs() and both
will finally irq_domain_associate() it. Giving different virq numbers
to their callers.

In practice the first caller is usually an interrupt controller driver and
the seconds is some device requesting the interrupt providede by the above
interrupt controller.

In this case either the interrupt controller driver configures virq which
is not the one being "associated" with hwirq, or the "slave" device
requests the virq which is never being triggered.

Reported-by: Krzysztof Adamski <krzysztof.adamski@nokia.com>
Reported-by: Tomasz Bachorski <tomasz.bachorski@nokia.com>
Reported-by: Wojciech Kosnikowski <wojciech.kosnikowski@nokia.com>
Cc: stable@vger.kernel.org
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
---
 kernel/irq/irqdomain.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index ccbb048..ad62c08 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -661,6 +661,7 @@ unsigned int irq_create_mapping(struct irq_domain *doma=
in,
 {
 	struct device_node *of_node;
 	int virq;
+	int ret;
=20
 	pr_debug("irq_create_mapping(0x%p, 0x%lx)\n", domain, hwirq);
=20
@@ -675,13 +676,6 @@ unsigned int irq_create_mapping(struct irq_domain *dom=
ain,
=20
 	of_node =3D irq_domain_get_of_node(domain);
=20
-	/* Check if mapping already exists */
-	virq =3D irq_find_mapping(domain, hwirq);
-	if (virq) {
-		pr_debug("-> existing mapping on virq %d\n", virq);
-		return virq;
-	}
-
 	/* Allocate a virtual interrupt number */
 	virq =3D irq_domain_alloc_descs(-1, 1, hwirq, of_node_to_nid(of_node), NU=
LL);
 	if (virq <=3D 0) {
@@ -689,8 +683,11 @@ unsigned int irq_create_mapping(struct irq_domain *dom=
ain,
 		return 0;
 	}
=20
-	if (irq_domain_associate(domain, virq, hwirq)) {
+	ret =3D irq_domain_associate(domain, virq, hwirq);
+	if (ret) {
 		irq_free_desc(virq);
+		if (ret =3D=3D -EEXIST)
+			return irq_find_mapping(domain, hwirq);
 		return 0;
 	}
=20
--=20
2.4.6