Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp3599714ybn; Fri, 27 Sep 2019 08:36:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqybn2H4zBeI0sM61Fz1hg9f7KN22DeyszO7LQkZIx8kZ0OfdrtZxqip2HViITY2k+lF5xd6 X-Received: by 2002:a17:906:b298:: with SMTP id q24mr8400858ejz.168.1569598601425; Fri, 27 Sep 2019 08:36:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569598601; cv=none; d=google.com; s=arc-20160816; b=KHc3BaDSWEoAdMf+/pMBWKog72wagKyxE0v6fm+b+Gyw+HOkqdjfPMhdBkMxtVQfRQ HLvcvfOE8gLuls0u9nN9koC+VkCimHHTqyunnj4iI0xtF86wpL/QLX73xw70xYS5hB1Q n698SL8YZP6mvjYd+jtnrqUEezyLQsOPLwKDQq2O+yVUqiYBF9+AW+6WSaZwCxYOeKMa 2o66iyRiF1d1IAxPLUsLmJykJjWr06oCWNIXeooVWAODMYeAo6vEHoNfmTzuGE+73xQ9 w6aM4GYumbB66EzDgjLOlsy0+iTiVw9zVwkG7w+4N5FCshnBKrvfv3cQr8iiKpiv6c6W Z12Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=57K7wMKvQpfcwscSwKB4kNNnnlmZTZVeEXUJkFXJ9j4=; b=P4JWCQ5Toy3yIxxn7BrVT3FpOsF5UCzOl2YfuQdFTAmxNMENQnbVtSxCMJgy5Uw14b LRS8/Cd7EORO/QA4oj2tqAYmKJ3g48rOH06nZJQFlR9LWFVstInK/FlxVhJXoFVXaiuf nqczByRCag7Eh6IPRyHb3kEa/HlhPvLp4Lke6rYzbXoIB6Mo+/5nDXUf6v0aFJD2p42g 2BjPzlYYwURD4fFS7++5LeW8yLcQ+fyI3RCmXS5ErVr4tlgl+P8L0Y+9nREEM5h0uuVI bsJ22zpTGbfEDeNoZa+ZMc/orDRDCstQ1oWjmlSz9qxSTL2xO9Mpfc8dXIBmuO7L3vtv roQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bt13si1742060edb.245.2019.09.27.08.36.16; Fri, 27 Sep 2019 08:36:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727416AbfI0PdK (ORCPT + 99 others); Fri, 27 Sep 2019 11:33:10 -0400 Received: from mga17.intel.com ([192.55.52.151]:51426 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727140AbfI0PdK (ORCPT ); Fri, 27 Sep 2019 11:33:10 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2019 08:33:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,555,1559545200"; d="scan'208";a="194521052" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006.jf.intel.com with ESMTP; 27 Sep 2019 08:33:05 -0700 Received: from andy by smile with local (Exim 4.92.1) (envelope-from ) id 1iDsEy-0001S5-2b; Fri, 27 Sep 2019 18:33:04 +0300 Date: Fri, 27 Sep 2019 18:33:04 +0300 From: Andy Shevchenko To: Cezary Rojewski Cc: Pierre-Louis Bossart , Navid Emamdoost , emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu, Liam Girdwood , Jie Yang , Mark Brown , Jaroslav Kysela , Takashi Iwai , Enrico Weigelt , Greg Kroah-Hartman , Thomas Gleixner , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids Message-ID: <20190927153304.GS32742@smile.fi.intel.com> References: <20190925161922.22479-1-navid.emamdoost@gmail.com> <13f4bd40-dbaa-e24e-edca-4b4acff9d9c5@linux.intel.com> <20190927025526.GD22969@cs-dulles.cs.umn.edu> <6966df25-e82c-1abe-6a0f-ff497dcda23b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6966df25-e82c-1abe-6a0f-ff497dcda23b@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 27, 2019 at 05:10:18PM +0200, Cezary Rojewski wrote: > I'm fine with solution #1 as I guess asking to wait for refactor is not an > option. Code deployment is delayed due to range of administrative decisions, > some of which should be uncovered on alsa-devel soon enough. The problem with solution #1 is freeing orphaned pointer. It will work, but it's simple is not okay from object life time prospective. -- With Best Regards, Andy Shevchenko