Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190903161655.107408-1-hridya@google.com> <20190927131912.pg7xtyfforiettgx@wittgenstein>
In-Reply-To: <20190927131912.pg7xtyfforiettgx@wittgenstein>
From:   Hridya Valsaraju <hridya@google.com>
Date:   Fri, 27 Sep 2019 11:11:15 -0700
Message-ID: <CA+wgaPOkMmVHYeKAx3bjBF_Yn=XAA8Jf7CbeJygy8xPTS06NdA@mail.gmail.com>
Subject: Re: [PATCH v3 0/4] Add binder state and statistics to binderfs
To:     Christian Brauner <christian.brauner@ubuntu.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>,
        Todd Kjos <tkjos@android.com>,
        Martijn Coenen <maco@android.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        "open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Android Kernel Team <kernel-team@android.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Sep 27, 2019 at 6:19 AM Christian Brauner
<christian.brauner@ubuntu.com> wrote:
>
> On Tue, Sep 03, 2019 at 09:16:51AM -0700, Hridya Valsaraju wrote:
> > Currently, the only way to access binder state and
> > statistics is through debugfs. We need a way to
> > access the same even when debugfs is not mounted.
> > These patches add a mount option to make this
> > information available in binderfs without affecting
> > its presence in debugfs. The following debugfs nodes
> > will be made available in a binderfs instance when
> > mounted with the mount option 'stats=global' or 'stats=local'.
> >
> >  /sys/kernel/debug/binder/failed_transaction_log
> >  /sys/kernel/debug/binder/proc
> >  /sys/kernel/debug/binder/state
> >  /sys/kernel/debug/binder/stats
> >  /sys/kernel/debug/binder/transaction_log
> >  /sys/kernel/debug/binder/transactions
>
> I'm sitting in a talk from Jonathan about kernel documentation and what
> I realized is that we forgot to update the documentation I wrote for
> binderfs in Documentation/admin-guide/binderfs.rst to reflect the new
> stats=global mount option. Would be great if we could add that after rc1
> is out. Would you have time to do that, Hridya?

Thanks for catching that Christian, sorry about the miss! I will send
out a patch ASAP to add the documentation.

Regards,
Hridya

>
> Should just be a new entry under:
>
> Options
> -------
> max
>   binderfs instances can be mounted with a limit on the number of binder
>   devices that can be allocated. The ``max=<count>`` mount option serves as
>   a per-instance limit. If ``max=<count>`` is set then only ``<count>`` number
>   of binder devices can be allocated in this binderfs instance.
> stats
>   <description>
>
> Thanks!
> Christian