Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp3779469ybn; Fri, 27 Sep 2019 11:13:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqx89r7rm2MpUWKnfqCG/6HMkIOe8918Alh0lIy8maRf6Ddm9jIVgg+gwyCXOSXoLxHb3zJV X-Received: by 2002:a17:906:9604:: with SMTP id s4mr9196288ejx.38.1569608008976; Fri, 27 Sep 2019 11:13:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569608008; cv=none; d=google.com; s=arc-20160816; b=qU3wTQF4ABIoUooIubBHzHJl7IWH9pH/hN88XERoywOpy9KTbAWl+ft0fdSqLU76lv 4Arug8wScuXDc0tRJldM25ahCxeuqVcjSAJfmJgJxVkz8gSKFg2aRIW7Oss7AQKkrEVh rcqDU+ggXu+eDT2nU0PdjqVT+bMEMLC5vsoLxiqvmEkN6W2NOf1DwR31b7w+OoDSjp+2 A6XEVbwHIJt7mxxUh224PnXxbJQzkkc73HlaPRlbOJHuNofCpWFqQMpp8oRMEgfUtqL1 1UEI6IcJP20ywYOxj56zkJbZAKXnlJCiC77aT95aQgku5PrBJglYevC9jjWxvUy2Ntfc bjSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=17UhB9lj87K7z7D08DRdOxJiMt6xF4eV6P70wKA4zns=; b=L2f7dVPEFwHmJXODxCpXlQ2wOOEAAwoXUpHXleIEDM0p0HpWVaI0Sr+zeC719qDG5Z vbJ24VoxrT1pR97vqlqEITJXu/+2gcCvNilsgayYsQ0BOqeqzNzg8Dh7RCpVwK2ojilX sWKLCuuRf4Xhlk8fV9/KcwrKjgqgFCvyThm9ucXwZ6zQigcDM3ZEG6eEnp4g7mKbuRHd rJFdtDdPHdsMh8WEC1lc2rqb4TUxgOiSyTqSBWfMHsx1wWbbKpgAbkZj9pGAs6MWV/BQ 0cCMbUeM4mvVx1rM6bSC6ID5z7XCQN4fTImYw7HszPgN92VYMmhbzdL7IQvv5Pxypq/g lV0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ot41si3327536ejb.215.2019.09.27.11.13.04; Fri, 27 Sep 2019 11:13:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728090AbfI0SMx (ORCPT + 99 others); Fri, 27 Sep 2019 14:12:53 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:35036 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726294AbfI0SMx (ORCPT ); Fri, 27 Sep 2019 14:12:53 -0400 Received: from localhost (231-157-167-83.reverse.alphalink.fr [83.167.157.231]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A4F39153E82CE; Fri, 27 Sep 2019 11:12:50 -0700 (PDT) Date: Fri, 27 Sep 2019 20:12:48 +0200 (CEST) Message-Id: <20190927.201248.2116783962888687419.davem@davemloft.net> To: navid.emamdoost@gmail.com Cc: emamd001@umn.edu, kjlu@umn.edu, smccaman@umn.edu, jakub.kicinski@netronome.com, john.hurley@netronome.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, frederik.lotter@netronome.com, oss-drivers@netronome.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nfp: flower: prevent memory leak in nfp_flower_spawn_phy_reprs From: David Miller In-Reply-To: <20190925182405.31287-1-navid.emamdoost@gmail.com> References: <20190925182405.31287-1-navid.emamdoost@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 27 Sep 2019 11:12:53 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost Date: Wed, 25 Sep 2019 13:24:02 -0500 > In nfp_flower_spawn_phy_reprs, in the for loop over eth_tbl if any of > intermediate allocations or initializations fail memory is leaked. > requiered releases are added. > > Signed-off-by: Navid Emamdoost Applied.