Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp3817332ybn; Fri, 27 Sep 2019 11:49:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqwtkaGcTBRewNPJD+fhREnP84pLEfYiMi/oZB+vfllPly+jX0gZGLjrgfnb0P/xeN9+17pO X-Received: by 2002:a17:906:7fda:: with SMTP id r26mr9310887ejs.170.1569610140107; Fri, 27 Sep 2019 11:49:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569610140; cv=none; d=google.com; s=arc-20160816; b=0g8BcOuwmGzzz7J4xOn1Ra8ZdU6wda3G7R51ILCWFaWdfCz316HN8rCCWdtE2ep5AJ 7NQ1FN/TUzTY69TWL56MYXOnOrqFPNw0rNoe8aSIKToBVzonvESq6J5yzf1bu/Z5h4+d rglsPZMHTCA+tr61JMA59ouOH6bJFPQM8adtZE3CaGqgb0LGY2BLci44oJXISXJ+qLuv ngJG1+lKCrj4dk6KrYtXs7m21RPZzhTP8HbEIdIpe4YBACXRal4UXtQDquMXNe3ZzdTt X0gWDLOqcR8GwEtlSzPVO554ZawI7a5Y4NlUF8lGf+HOu8pMPe8dCldmMbQjGeolt0XM QYlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:user-agent:subject:from :to:cc:references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=9urTYd1joZTADBKbrio8/BIUqy/Z/8h6l7Bz8twYFDo=; b=CLwsPHwtjNR1fn/5rBI3vkL7tUOBMkNB5IBSOtouf9pzuOrffnjHEFdnzLL3CuPEKf AV4paDlXxuz4/2wH/xruTYN0in7JFDiCiRBJ8WM2wopCIjtfbc7m1zMTu7yvy3DSaR96 YmxLSurb3eV3SrKAd1eM4hTXHtoxwGrsSrrIlwvIcX2hZGeAkurz25qlmMxyhaHVkio9 ABhkaT1X79Pl1q2dkTppUKqHGN1EAuj7J+fIOPMp32hqo3Va4+VD4lGpCDrc7/LqrV3C Q2iGXVUqDqyU/kBL88tSlMhlHgkzhOhCfQCGr9KwlNVr7d0F3lSWvs8DsRipvG3P/uKc m75g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Og+/hr+f"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id me23si3164516ejb.344.2019.09.27.11.48.35; Fri, 27 Sep 2019 11:49:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Og+/hr+f"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728657AbfI0Spu (ORCPT + 99 others); Fri, 27 Sep 2019 14:45:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:48308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726294AbfI0Sps (ORCPT ); Fri, 27 Sep 2019 14:45:48 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 312AA20872; Fri, 27 Sep 2019 18:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569609948; bh=2abY4RvzDrV7ZdSCeY547gsiUtUpdWNapfjq46d9c7Q=; h=In-Reply-To:References:Cc:To:From:Subject:Date:From; b=Og+/hr+fuIIOHhez7V7VPkBCoxZr4ITEX2BxG9MRmuniM2cx3yEsZsqBLv5Dhz6zE 46WzEkQRmPRYcDeFhLvYNDluemYdAfSlpVGU8Wt3b0qSvENOf3AFyj8hixS13h7We8 6m6I1ZlfILLt5xs6LB9Soh7Bj0Etq1lOJfpPdXE0= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: Cc: orsonzhai@gmail.com, baolin.wang@linaro.org, zhang.lyra@gmail.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Baolin Wang , mturquette@baylibre.com From: Stephen Boyd Subject: Re: [PATCH 1/2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle() User-Agent: alot/0.8.1 Date: Fri, 27 Sep 2019 11:45:47 -0700 Message-Id: <20190927184548.312AA20872@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Baolin Wang (2019-09-26 20:50:53) > The syscon_regmap_lookup_by_phandle() will never return NULL, thus use > IS_ERR() to validate the return value instead of IS_ERR_OR_NULL(). >=20 > Signed-off-by: Baolin Wang > --- > drivers/clk/sprd/common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Fixes tag?