Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp3826149ybn; Fri, 27 Sep 2019 11:57:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqzGguQhB2HTmLqeRdP1ejDqNNma943tGeJO2kGmJwbIJAu66RXfim8vlWMU6oKieuHxNjFX X-Received: by 2002:a17:906:493:: with SMTP id f19mr9016881eja.285.1569610644194; Fri, 27 Sep 2019 11:57:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569610644; cv=none; d=google.com; s=arc-20160816; b=VsLTC1H+8dD2PdiAj+yXu68x7e6jclHH0xhJzvSGxRhc0tA8aY3K/cmiR5wbHHTqep mljNLK3Zo320AwSEElmT9gvGJ0SHEKVcAQW6ml4a98Q128LO7sp/lCb4Mvv1X7VTimjL URsF+nyWLQVpqH+M7w8wXU3kV05ZVXaoX8AMDhZzWaFaR6QqlT0YIzf3Vjp7WEX4OEHV 4Ly1l/t8AZclnlSwnKvRDXSkJsNoYquiNTBxf9xUV9gf5yzUkpcfPb765n74y0Tzoh2n NO+XyiBH8mD5ohb82Npifz7500PVp5UNhSPibpE3LiQWyuQclHNuPDAu9yGDgAyZo07i WJdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Ve6xkYJFR+MQ0oyqG3oUQDG3Tsk/bX/7MOWE3Z0SpkQ=; b=CK0WL2C27JGikpgUsZkCVz8ZZc7C7tv+/l7TYoqq6m8Q3JKd3tGtHpLmEYzADL1MC6 HPNtsAYguhbu5+h4a5ilboU1x44J+QSZj/7x7WT6J3YfeCjp39L/IymSU/Gjb9zJHeol sc3g5zt56j9WTL4+v0vqjV0sVH6HYLuqKdmwGtv0JN49cflGnyDXlEdd9aTVMb1Gf6CP //ZzYpZLNlEiWcPtx/zkk3sf5aoxzpQfQAAtFM1rs3gr5rZITjRMIcWFN7DAA4d7QGY/ 5X8Mcg1oLIAwm36fX8Yojw3WvMGjcz0nRafi60oDFu2qjgA4f4BSzszBjs1KJN3Jidbi 3x2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w1si2137087eda.214.2019.09.27.11.56.59; Fri, 27 Sep 2019 11:57:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726922AbfI0S4O (ORCPT + 99 others); Fri, 27 Sep 2019 14:56:14 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:35558 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725790AbfI0S4O (ORCPT ); Fri, 27 Sep 2019 14:56:14 -0400 Received: from localhost (231-157-167-83.reverse.alphalink.fr [83.167.157.231]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C3520153F4373; Fri, 27 Sep 2019 11:56:11 -0700 (PDT) Date: Fri, 27 Sep 2019 20:56:10 +0200 (CEST) Message-Id: <20190927.205610.405337847364577843.davem@davemloft.net> To: navid.emamdoost@gmail.com Cc: jakub.kicinski@netronome.com, emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu, pablo@netfilter.org, john.hurley@netronome.com, colin.king@canonical.com, oss-drivers@netronome.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] nfp: abm: fix memory leak in nfp_abm_u32_knode_replace From: David Miller In-Reply-To: <20190927015157.20070-1-navid.emamdoost@gmail.com> References: <20190925215314.10cf291d@cakuba.netronome.com> <20190927015157.20070-1-navid.emamdoost@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 27 Sep 2019 11:56:13 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost Date: Thu, 26 Sep 2019 20:51:46 -0500 > In nfp_abm_u32_knode_replace if the allocation for match fails it should > go to the error handling instead of returning. Updated other gotos to > have correct errno returned, too. > > Signed-off-by: Navid Emamdoost Applied.