Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Song Liu <songliubraving@fb.com>
To:     Shuah Khan <skhan@linuxfoundation.org>
CC:     Song Liu <liu.song.a23@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin Lau <kafai@fb.com>, "Yonghong Song" <yhs@fb.com>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH] tools: bpf: Use !building_out_of_srctree to determine
 srctree
Thread-Topic: [PATCH] tools: bpf: Use !building_out_of_srctree to determine
 srctree
Thread-Index: AQHVdNDXBxSGfE5tmEyE9kgIwPwciqc/3XAAgAAFZoCAACTiAA==
Date:   Fri, 27 Sep 2019 21:15:24 +0000
Message-ID: <57756C81-5B82-4E56-9CF0-5C1C4A4FBEFC@fb.com>
References: <20190927011344.4695-1-skhan@linuxfoundation.org>
 <CAPhsuW5EncjNRGjt7F_BN2bNhRkf=uXVeDe6NCbJe=K2J+hdyA@mail.gmail.com>
 <5ec40572-5df9-0e5b-5a85-eb53be48b87d@linuxfoundation.org>
In-Reply-To: <5ec40572-5df9-0e5b-5a85-eb53be48b87d@linuxfoundation.org>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D6C6AF43DDFBD14B8925B24E4E06C797@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 68c45fa1-16b5-4257-c9fe-08d7438fd042
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2019 21:15:24.7497
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pzT4P4ntiSByp0037Hqeyp9HcRNpcWjfzwI+C+C1Y/8lnA61cRaLkHWmozD7W+PEMOj8MaGjF0qAApqiN6hnSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1453
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-09-27_09:2019-09-25,2019-09-27 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxscore=0
 lowpriorityscore=0 phishscore=0 priorityscore=1501 spamscore=0 bulkscore=0
 suspectscore=0 clxscore=1011 mlxlogscore=999 adultscore=0 malwarescore=0
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-1908290000 definitions=main-1909270178
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Sep 27, 2019, at 12:03 PM, Shuah Khan <skhan@linuxfoundation.org> wrot=
e:
>=20
> On 9/27/19 12:44 PM, Song Liu wrote:
>> On Thu, Sep 26, 2019 at 6:14 PM Shuah Khan <skhan@linuxfoundation.org> w=
rote:
>>>=20
>>> make TARGETS=3Dbpf kselftest fails with:
>>>=20
>>> Makefile:127: tools/build/Makefile.include: No such file or directory
>>>=20
>>> When the bpf tool make is invoked from tools Makefile, srctree is
>>> cleared and the current logic check for srctree equals to empty
>>> string to determine srctree location from CURDIR.
>>>=20
>>> When the build in invoked from selftests/bpf Makefile, the srctree
>>> is set to "." and the same logic used for srctree equals to empty is
>>> needed to determine srctree.
>>>=20
>>> Check building_out_of_srctree undefined as the condition for both
>>> cases to fix "make TARGETS=3Dbpf kselftest" build failure.
>>>=20
>>> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
>> The fix looks reasonable. Thanks!
>> However, I am still seeing some failure:
>> make TARGETS=3Dbpf kselftest
>> [...]
>> test_verifier.c
>> /data/users/songliubraving/kernel/linux-git/tools/testing/selftests/bpf/=
test_stub.o
>> /data/users/songliubraving/kernel/linux-git/tools/testing/selftests/bpf/=
libbpf.a
>> -lcap -lelf -lrt -lpthread -o
>> /data/users/songliubraving/kernel/linux-git/tools/testing/selftests/bpf/=
test_verifier
>> make[3]: test_verifier.c: Command not found
>> Is this just a problem with my setup?
>=20
> You are running into the second bpf failure because of the dependency
> on the latest llvm. This is known issue with bpf test and it doesn't
> compile on 5.4 and maybe even 5.3
>=20

Thanks for the clarification.=20

Acked-by: Song Liu <songliubraving@fb.com>