Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751019AbWABUTJ (ORCPT ); Mon, 2 Jan 2006 15:19:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751020AbWABUTJ (ORCPT ); Mon, 2 Jan 2006 15:19:09 -0500 Received: from mail.fh-wedel.de ([213.39.232.198]:11394 "EHLO moskovskaya.fh-wedel.de") by vger.kernel.org with ESMTP id S1751019AbWABUTI (ORCPT ); Mon, 2 Jan 2006 15:19:08 -0500 Date: Mon, 2 Jan 2006 21:18:47 +0100 From: =?iso-8859-1?Q?J=F6rn?= Engel To: Krzysztof Halasa Cc: Arjan van de Ven , Ingo Molnar , Adrian Bunk , Tim Schmielau , Linus Torvalds , Dave Jones , Andrew Morton , lkml , mpm@selenic.com Subject: Re: [patch 00/2] improve .text size on gcc 4.0 and newer compilers Message-ID: <20060102201847.GB9935@wohnheim.fh-wedel.de> References: <20051231150831.GL3811@stusta.de> <20060102103721.GA8701@elte.hu> <1136198902.2936.20.camel@laptopd505.fenrus.org> <20060102134345.GD17398@stusta.de> <20060102140511.GA2968@elte.hu> <1136227893.2936.51.camel@laptopd505.fenrus.org> <1136231656.2936.57.camel@laptopd505.fenrus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 23 On Mon, 2 January 2006 21:05:31 +0100, Krzysztof Halasa wrote: > Arjan van de Ven writes: > > > it's by far not only gains. And maintenance costs too. > > Anyway, distinctive "inlines" could help here, right? Not really. Your example, as Linus already explained, is a great example of how _not_ to inline stuff. If in doubt, don't inline. If a function is called just once, don't inline unless there are other good reasons for it. If you get a minimal gain (10 bytes) in text size, don't inline. The maintenance issue is more important. J?rn -- A defeated army first battles and then seeks victory. -- Sun Tzu - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/